Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp443933pxv; Wed, 30 Jun 2021 09:06:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzil+Sy6rtbwR+Iwr1WSbPRdOgE6d7Y3NXMefQ68nYo4iKvsJYYh8BvE0bVCLCyFsj6lg+P X-Received: by 2002:aa7:dd5a:: with SMTP id o26mr47347276edw.277.1625069176069; Wed, 30 Jun 2021 09:06:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625069176; cv=none; d=google.com; s=arc-20160816; b=M36byPUd1EShZ4pL4IcYp+L/POwHpSqE9EiUmk+BIrhlLBnhLTg/NPRfWbk6loD4Kc zQgloKIdmvuJygagyPDI7eq1JctJHY8qolilHcWLtqRh2ftM6bJ5X9+z1H5QepOT2hRi 19Oj2fump+ZmB1T362G50kYyUejBulLfidf76Ks88+N8MeyenFTneb+K5MuLUKJty4PU zdb8HpirPfTUUovR5WkzcM5xAKp9DPoFLHb/W1MCtLkZjdS7//3jkBokFe3ZmLVXeR1c DztFx7C2Q8XHFmTF2HRa6ZhPnF6vh5dHZlDeHPsnvAKQn2uIhF28yN59Qo0UOIocSLzf zzLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature:dkim-filter; bh=hFux6baM8u5np5HchDB/AtLhHlH6fHd6OrElJ/shkAU=; b=U5KHf72XpiguCb7SQYhj6GD/Yi/JBZ4+XDg/3ZyrVGE07dXXh3dArgBSCvdsi0fSuO d5KxCH62vd4nYojVMTSFmvJOOvr+mNbVkaxqe6wE8l8eZOUDoQWS/5+wBKs5YpUzHHoQ 8sa3giQH9ATj2dIrEkaPsLI6qr6S6+ELxjWLGkTYdA1nFUIHVinKDeEY9v6Wr6SQesQl K7q1Dtleu5P+6zI+RPjk9RqQ64LVTbCKuQ0BL+ViMKNv9S5meYXnQWMxitpSgcc0Ko9J YmJxEbGZWZBUAAZszG7XmpG74eFYfvGInkczu77c8FH2wIXiUDXDKpBL7hduZ5fGos5W 7C5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@fieldses.org header.s=default header.b=YSu253jm; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m19si7973376eje.174.2021.06.30.09.05.49; Wed, 30 Jun 2021 09:06:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@fieldses.org header.s=default header.b=YSu253jm; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235867AbhF3QIN (ORCPT + 99 others); Wed, 30 Jun 2021 12:08:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235866AbhF3QIM (ORCPT ); Wed, 30 Jun 2021 12:08:12 -0400 Received: from fieldses.org (fieldses.org [IPv6:2600:3c00:e000:2f7::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1094CC061756 for ; Wed, 30 Jun 2021 09:05:43 -0700 (PDT) Received: by fieldses.org (Postfix, from userid 2815) id 962A56482; Wed, 30 Jun 2021 12:05:42 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.11.0 fieldses.org 962A56482 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fieldses.org; s=default; t=1625069142; bh=hFux6baM8u5np5HchDB/AtLhHlH6fHd6OrElJ/shkAU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YSu253jmVxX4DIZ1dsQcGFtLl9YXK5bOtI5oraagDwo246dhXuAg1yRTq2l0htzqd JwZSnOe8KWDd2c7yQBkdo49YthLAaoUiinjJG1w9XHM/fymvZPaD4UBCMNpUc4wsup EYdsR3+k3kYWr/UyAvaW6iw2dCilsxD2DvZW5RPs= Date: Wed, 30 Jun 2021 12:05:42 -0400 From: Bruce Fields To: Chuck Lever III Cc: "Russell King (Oracle)" , Linux NFS Mailing List Subject: Re: 5.13 NFSD: completely broken? Message-ID: <20210630160542.GD20229@fieldses.org> References: <20210630155325.GD22278@shell.armlinux.org.uk> <1BF34FA4-EC1A-405D-AA8B-217BF94DA219@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1BF34FA4-EC1A-405D-AA8B-217BF94DA219@oracle.com> User-Agent: Mutt/1.5.21 (2010-09-15) Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Wed, Jun 30, 2021 at 03:55:16PM +0000, Chuck Lever III wrote: > > On Jun 30, 2021, at 11:53 AM, Russell King (Oracle) wrote: > > Has 5.13 been tested with nfsv3 ? > > > > Any ideas what's going on? > > Yes, fortunately! > > Have a look at commit 66d9282523b for a one-liner fix, it should apply > cleanly to v5.13. So was this a freak event or do we need some process change? Looks like the problem commit went in 3 days before 5.13. It was an mm commit so they're probably not set up to do nfsd testing, but nfsd is the only user of that function, right? It says it fixed a bug that could result in writing past the end of an array, so made sense that it was urgent. Sorry, just catching up! --b.