Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp531294pxv; Wed, 30 Jun 2021 11:09:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyrPeCHmUD4+BpZ8wBwim0jCLw2T2hAgWYPEON+BNlVwomg6EjHPVDSlDHdm4uND4AzkTYy X-Received: by 2002:a05:6602:1645:: with SMTP id y5mr8985202iow.7.1625076574503; Wed, 30 Jun 2021 11:09:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625076574; cv=none; d=google.com; s=arc-20160816; b=ekNZBwcyRnjvCTA70GMGm31OI+Z+6znvky3ALyEy8sUOSZcC9HEKkQx0lTiE5Ais7J n0nIp2P3KIS92b/i0y12J3l6mM0qpZWvzgDtxDw4nVy/7NyOuXurdWsZ34+RaKJ6My4W mdmEtoPCL6kQ18Cbrb8p5KofIMNM58xZSoexNBQ1mL+y4jnO7FrfNzEsd9tdNpDAv1xD NYDSxzurUEYmxX1q8FKi2Ux8vwXECrXZ+o/ZJUhqddD6w7uEwhxVgMiryuo8lUysD4h2 muFSMO5bf7S/VeWwPowjzJrQakZ167XVpib2oEuvYYrKgroKD4BHDzi0LfW6RuK5jnzC 0f0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature:dkim-filter; bh=ENwBHGTlXFV/KwOpGJpiR4dA/TpaBbXgtvlFSGBFyrk=; b=rKCjpffWQG1kmlPGkkUR6bc0tdRmHFW4FziMg6plHMCDu4Ef7dPXdvIKXnthXk6nDr BvoyHa4wUi9UtQrBQhWvKE9aIeLa5ZQkeHTkM/CtZ5boAKqNf0WqcGBjywBLhXYpQlJp IMQ2dJrRCT7mfVba69ezxzAbmsXDHUnpIkfqEVCP/MdeE1gdznmmmHc6HIArbHlejKSo 2gi97ImHyNEeg7thqmPNQOQ+E7UjQq6DURfwCWQEqNAdxn/jB5yJEncJ9iyySZOQiT6F UbmfbgNGB/4UpsEFObKFmNMzux7rfpNjuYwdES6ycH7PYkrGTYLynA9q30S6Xh9No9Fy j7pg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@fieldses.org header.s=default header.b=DK9O+6zH; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p18si24555515jam.60.2021.06.30.11.09.22; Wed, 30 Jun 2021 11:09:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@fieldses.org header.s=default header.b=DK9O+6zH; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229991AbhF3SKz (ORCPT + 99 others); Wed, 30 Jun 2021 14:10:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232694AbhF3SKy (ORCPT ); Wed, 30 Jun 2021 14:10:54 -0400 Received: from fieldses.org (fieldses.org [IPv6:2600:3c00:e000:2f7::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD20BC061756 for ; Wed, 30 Jun 2021 11:08:25 -0700 (PDT) Received: by fieldses.org (Postfix, from userid 2815) id 44CB56C07; Wed, 30 Jun 2021 14:08:24 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.11.0 fieldses.org 44CB56C07 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fieldses.org; s=default; t=1625076504; bh=ENwBHGTlXFV/KwOpGJpiR4dA/TpaBbXgtvlFSGBFyrk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DK9O+6zHZH5jh3H0xJDAEFRIFTqIV1d5jGXE6y0bw6thQSDdsk2xRMLpTcvHHX+LZ REuQ8x1LDH0fFuR4b7eXK8iTPXnm7tJIwlFDzZQRo+vanBRK4E+lROCyuBrJyR1Wh6 yzBeRP5KAqnA+gzsC92uvsqE6s7kPsYDxp7a/fDM= Date: Wed, 30 Jun 2021 14:08:24 -0400 From: Bruce Fields To: Chuck Lever III Cc: "Russell King (Oracle)" , Linux NFS Mailing List Subject: Re: 5.13 NFSD: completely broken? Message-ID: <20210630180824.GF20229@fieldses.org> References: <20210630155325.GD22278@shell.armlinux.org.uk> <1BF34FA4-EC1A-405D-AA8B-217BF94DA219@oracle.com> <20210630160542.GD20229@fieldses.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Wed, Jun 30, 2021 at 04:28:47PM +0000, Chuck Lever III wrote: > The problem was discovered by static analysis, not a > crash report. IMO the fix should have waited for testing > and review by the NFS community. This close to a final > release, the fixes for the array overrun and page leak > could have gone into v5.13.1. I hope automation will > take care of all of this very soon. Years ago I had a cron job that fetched a few trees and ran cron jobs on them nightly. "Automatic" testing always ends up requiring more manual intervention than I expect, but maybe I should give that another shot.... --b.