Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Neil Brown <neilb@suse.de>
CC:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH v3 0/3] Bulk-release pages during NFSD read splice
Thread-Topic: [PATCH v3 0/3] Bulk-release pages during NFSD read splice
Thread-Index: AQHXdA2dfQ0L7epND02Y4GSFtLC88qs5uFIAgAA8EAA=
Date:   Fri, 9 Jul 2021 02:58:09 +0000
Message-ID: <618CC460-3C8E-464A-B6F5-77C9F1DC82EE@oracle.com>
References: <162575623717.2532.8517369487503961860.stgit@klimt.1015granger.net>
 <162578659050.31036.16278478540386858207@noble.neil.brown.name>
In-Reply-To: <162578659050.31036.16278478540386858207@noble.neil.brown.name>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?z+yr39jyP2k63teuUx8F2u4tcQV4qAcUmPamtGCrA8XUiPEjyEjCIMgAZo5Z?=
 =?us-ascii?Q?kBwcx8ERU3tHATHeqv3Qu/fEctLtTrN6kLttKCOnv2YAEyA6AR+kEoNoeui3?=
 =?us-ascii?Q?bN3CCNUVMGQLAMnzvk58BAYmO4/stBcUO+QrBGd/4q2c/EvwlOPOtQtkB9LN?=
 =?us-ascii?Q?gO0sPtuVR5Q0KWgimt3IQF5pjtqRRboTLJQHh0U7LdJDFvIDBVf9GkIQKAnI?=
 =?us-ascii?Q?EgcyJebBQsbnr5iY1t653APSH7nSwRH87JTuibbJfnrado4rxxyExbQnWLxZ?=
 =?us-ascii?Q?jh4IoMAGbafzDlI3m5d+pA20lGUwi9QDIjzHqedZ7b3pXKEbt0g6woQHHYkk?=
 =?us-ascii?Q?qHI0TID6nArOsPCmK5XhLNbOyJuomlrT6wjF62LUt6xn3mQ1jBSZDAmq+reo?=
 =?us-ascii?Q?akxywA+LPHNYMRCkL1dX5BIac61AMgWPWLh+grYwRpBJIpt1T4rs5lKQWZy/?=
 =?us-ascii?Q?ZGSGeyb2YA3UsmmFoVVaA8RXPlqzvrFxFYyUkgd9wMuxQ4oVz9TrOZjboybR?=
 =?us-ascii?Q?BK7Lcd68+63RFHpL8PpcHxuu0bcY5ZK/nWUzfDmhZaWzdqbDsaWMOWqvzbB9?=
 =?us-ascii?Q?bqX2Y9Xaa/jwcf5Vr10kWx6AiEI2/+ol5ZslY/LAWlik0v0s0XkAJnJevrTS?=
 =?us-ascii?Q?rYtmZp9pOyW7rLDAqZyV5biV59iLXUVxlh+nePUOs1LBugOXB/IsUSTb+FpW?=
 =?us-ascii?Q?nhXLy8FiC3ltY+GN5W8FpC4sF/8y/6GOAib+yUDhSTZmytpZp2s9v9r0wi06?=
 =?us-ascii?Q?mXrXmIIWZaOlHebkdF7QE9tzUN1NoyvfDl+cdePMBMoT4PcxjLZSQ0aQgjpY?=
 =?us-ascii?Q?J1AIc1EetygHY4LZJ9teNXstA0fUf4TV13hgcgkCQyMzBF4m6MqQfppLTDHy?=
 =?us-ascii?Q?c/7ANuri9Mb1OEBKnq7duFuNB4LgR5VrUG3K+oHJpEh6FpcsAAOa0tn2fzr5?=
 =?us-ascii?Q?RxM7DWDbEchjePMhTVXsKjN/QACh0V7mbqcvjaaDARhbpihoNOcz4G3OT4Ke?=
 =?us-ascii?Q?kBXG4M5EjUf2fpGqeDtdYIz267GGEMihl7RuoOAA/ilDJXQzDhBuwYOTw5R4?=
 =?us-ascii?Q?H3gogAa6f7ho9Hst4Rzi5T0S5f5PK6sFzaXQ9kNGNUQkmaszTf46cM837kvu?=
 =?us-ascii?Q?gAmaMSJm0DXX58uJpRpMC+caMnn/H71ie8SZnWiUiKS6898F4bIIfRQtyqYR?=
 =?us-ascii?Q?kQ1eJmiTEAdHBdL4lYOx4B6f6WduGUG6geYpkUB4zbqJHw2+PlSIkYD/9h0M?=
 =?us-ascii?Q?eRE5XquktTNSDHMkZr7FrVFmq+PjCQmYy/DJfmLTQqoKDBCzCALQaVGjFYNy?=
 =?us-ascii?Q?ss27vcds+Csqeutma2DhYdLB?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <CE2F3FFB157CCD4691D772731541EC37@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4688.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bbf608a0-d38a-4821-6e32-08d942856263
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jul 2021 02:58:09.7586
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5r0R07DEYz6CCSJ2I+kDqfZ/+ipNhimzwhFCaIsgsmbYd4JupoLU/4tbzIxWqcxUJ1jx9vrB7EjVq0JOBv7wPA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2870
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10039 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=999
 phishscore=0 adultscore=0 suspectscore=0 spamscore=0 malwarescore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2104190000 definitions=main-2107090011
X-Proofpoint-GUID: uZjybirfwqyUG-o8a0QmBMXp0SCUPF2v
X-Proofpoint-ORIG-GUID: uZjybirfwqyUG-o8a0QmBMXp0SCUPF2v
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Jul 8, 2021, at 7:23 PM, NeilBrown <neilb@suse.de> wrote:
>=20
> On Fri, 09 Jul 2021, Chuck Lever wrote:
>>=20
>> In this version of the series, each nfsd thread never accrues more
>> than 16 pages. We can easily make that larger or smaller, but 16
>> already reduces the rate of put_pages() calls to a minute fraction
>> of what it was, and does not consume much additional space in struct
>> svc_rqst.
>>=20
>> Comments welcome!
>=20
> Very nice.  Does "1/16" really count as "minute"? Or did I miss
> something and it is actually a smaller fraction?

6% is better than an order of magnitude fewer calls. I can drop
the "minute".


> Either way: excellent work.
>=20
> Reviewed-by: NeilBrown <neilb@suse.de>

Thanks!


> NeilBrown
>=20
>>=20
>> ---
>>=20
>> Chuck Lever (3):
>>      NFSD: Clean up splice actor
>>      SUNRPC: Add svc_rqst_replace_page() API
>>      NFSD: Batch release pages during splice read
>>=20
>>=20
>> fs/nfsd/vfs.c              | 20 +++++---------------
>> include/linux/sunrpc/svc.h |  5 +++++
>> net/sunrpc/svc.c           | 29 +++++++++++++++++++++++++++++
>> 3 files changed, 39 insertions(+), 15 deletions(-)
>>=20
>> --
>> Chuck Lever
>>=20
>>=20

--
Chuck Lever