Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp571583pxv; Thu, 15 Jul 2021 10:28:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwtet5czOS/+OPhP0/baUvsvqhhXTEvN9cbDZtQorTcfsH3N3XRSTzetpdCXGx4eqA+AnGR X-Received: by 2002:a92:364f:: with SMTP id d15mr3482887ilf.26.1626370136912; Thu, 15 Jul 2021 10:28:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626370136; cv=none; d=google.com; s=arc-20160816; b=ZUnMHzBauyp2p0bwzqNNBvg/J+g8KLjOO4eP2AWzjmlCifIIatEzfPoY06G08A5E3t nUOqQm3w5x/E2MfKuvv5m7oW4E+GBpd19GPr4usHbA0zbuKnXOlvYjuSVUdyfDvN44L4 aIX/sE5jNhrpP63o9+w1PU65t/o3QKFqXq1Czvz9gS2Qm99Nx/ZeR1yIlGyqDVXjWRVr nr1r00SaYRjwFwL6e0HfpHa8inLMd4+G0jdNV+2G3Ndusddyel2sruunggiK247hqynR ON6nBpWNi3obuqe76iwHjBlU+xoXWOJ8dImZ+l0+w0nGFNwq0gI3/4uj3YQvvQL6EeiL U0lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=A/iOWH/eq2vDhfxyVOdH70jsjaoCTAYD+XN2BGv/PRg=; b=Ww2v0VB2+dGI2QveHmb14uxJ+TNOv3YkddgmzbxYhG5Ak2LmciGYxeSosnniqClcdL buLRLkDYHH+15aFUWLaZy1fEiS0FOegI53FU62KzEiEg4VorW9ImnFOU+Xej37PrtLKr hDBBba6QKGkzE0LZ+i/hna+em0xkOmFvfs36KUS7CAhdgD8ueSen8FOZFrdxs6zGhCTn C+9x+uCcBPlFk0WNqE77QRMzxMwjq+90aRp0KesNMAQVwd+zAHysKjsUBJgifA1MZYvW 1q9vNDRkSw+Mj7MpTUUWOfa861NuYX2VowpljdOYNaVICUDBgYCGU06RI496gXH8RSJu y0cQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=a8tBS7GQ; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i9si8016956ioq.17.2021.07.15.10.28.44; Thu, 15 Jul 2021 10:28:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=a8tBS7GQ; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229553AbhGORaO (ORCPT + 99 others); Thu, 15 Jul 2021 13:30:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229506AbhGORaN (ORCPT ); Thu, 15 Jul 2021 13:30:13 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71DC5C06175F; Thu, 15 Jul 2021 10:27:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=A/iOWH/eq2vDhfxyVOdH70jsjaoCTAYD+XN2BGv/PRg=; b=a8tBS7GQNc7/QxHn26QkbWu1LJ oF//nu8vv7GY7MZKmx17DZ1MD7SC81IBUpbTVoTfPdv5YGjHA96QLvp0bXYNYNHt4GjDzeW+5bYNd qqJr6939/NH5eT4uXvHtur9iFrH8mdUEtkYUEO+fs1nGlCVKLeJmUGAwAp2gHUj9iuBSfVz3G5r2e NX42m7HRiIJmgk3u7baJqppizWoLU3fHkkeDTKLm49i9XdC6RD0gVJuvJI1K7ydpntrk4jjifvSuv 6UU5ht9aFS97snKG1FD189wiAZs7sTMViCj2R/oXRpTKTud7iroRh2LvWpsgOvCHCxy0MH4s0PJwX aX0F++mA==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4569-003ZP2-8Q; Thu, 15 Jul 2021 17:24:51 +0000 Date: Thu, 15 Jul 2021 18:24:33 +0100 From: Christoph Hellwig To: Josef Bacik Cc: Christoph Hellwig , NeilBrown , "J. Bruce Fields" , Chuck Lever , Chris Mason , David Sterba , linux-nfs@vger.kernel.org, Wang Yugui , Ulli Horlacher , linux-btrfs@vger.kernel.org Subject: Re: [PATCH/RFC] NFSD: handle BTRFS subvolumes better. Message-ID: References: <20210613115313.BC59.409509F4@e16-tech.com> <20210310074620.GA2158@tik.uni-stuttgart.de> <162632387205.13764.6196748476850020429@noble.neil.brown.name> <28bb883d-8d14-f11a-b37f-d8e71118f87f@toxicpanda.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <28bb883d-8d14-f11a-b37f-d8e71118f87f@toxicpanda.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Thu, Jul 15, 2021 at 01:11:29PM -0400, Josef Bacik wrote: > Because there's no alternative. We need a way to tell userspace they've > wandered into a different inode namespace. There's no argument that what > we're doing is ugly, but there's never been a clear "do X instead". Just a > lot of whinging that btrfs is broken. This makes userspace happy and is > simple and straightforward. I'm open to alternatives, but there have been 0 > workable alternatives proposed in the last decade of complaining about it. Make sure we cross a vfsmount when crossing the "st_dev" domain so that it is properly reported. Suggested many times and ignored all the time beause it requires a bit of work.