Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp5650958pxv; Wed, 21 Jul 2021 10:22:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxJn6+F6yc3gdiF824yunPUHAdjqjXUhpW1WKPXnIOnSvDjO3Gpvc7FNCdxZCUrQJmTcw+C X-Received: by 2002:a05:6402:185:: with SMTP id r5mr5570113edv.349.1626888121974; Wed, 21 Jul 2021 10:22:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626888121; cv=none; d=google.com; s=arc-20160816; b=NyXfbZS3ibLKTseYAsjkD7Rch+mchTcFX3PDuk51E96SZ2ES1sUQyB9DllvtJvgZiX jASHQ+bCqSK6d4xoA8WzvqW5vFI4Sae3KPTmcdfTJzIZh3147DtLhqw007/8S8nT4KYc gWsMTUuumUotfk1jEfZ/UZNMaPv0nW26IZ2OJ1qaVHyn0NLqAFhb73IrUjDcf8erRwnC 7fIccwiGcpG0wQmnz96595QKS93S3m0tmpzTk3a8xY1+STGjPoM7zV+fG7chAvjaXQ+7 3w2vZQJrx2WprUnRuPddbU8kmvC8nFHLucwfn3YMd4SRFMtKjhvfu1jhyGjEe8iq8B1i 1qbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=BIt0Yb9H5DHJEMvOYSUbKkxcwoKM/Ncp4O7tCakc/1Q=; b=Mp8PH3Iwxw18CixEcTuNI4Z7mS299nE+Y0U7jmlh0g/fZoZUAxDqLh3iEJmoLA4PY6 b5JyfuKK8HDBS4cx7vdITK3AHXDMXL4vtcFcqRS46Cxp8YIFIGWce3kcHOYDjhTO+1uZ U665NFIQZSru7c2UqLlbqSb/8mibhoRr3yAPVbe0u8BzSqW4KwZlmzYdr9LeA2DKnZYY n+Tva+Gr1OEJVbY/B9jvirjUAb9HDrMFm5E5jOvn19UuXG8mg6YXk/+/BzgkNGapaWV5 rrCFKyHVFSO2TOgA6RPsushLsrcL0aqnOPW6NPou22JWu/80lR5RzJN5QZg+GYBw8HuZ iaOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=eXyLgZrS; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ka6si9495768ejc.26.2021.07.21.10.21.38; Wed, 21 Jul 2021 10:22:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=eXyLgZrS; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235104AbhGUQjw (ORCPT + 99 others); Wed, 21 Jul 2021 12:39:52 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:54385 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229943AbhGUQjv (ORCPT ); Wed, 21 Jul 2021 12:39:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626888027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BIt0Yb9H5DHJEMvOYSUbKkxcwoKM/Ncp4O7tCakc/1Q=; b=eXyLgZrSPve50INxI3GJEvydet7VfEqLZPm7S1AIsNpq2WLQ7lu0V25UdMMjQTmjNFH0VG C/7cxK4HNxa4mM0JIQ326fMU4OPhrh+U/zKFBQ4Xar4i+cvhyS7oFBXbGeXgSkwWFtsiks 5lWvUmM5YOQ/bkonkZkUbgIYMvqVNPY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-386-GhHEOI8XMz2fV-_JkEc7ng-1; Wed, 21 Jul 2021 13:20:25 -0400 X-MC-Unique: GhHEOI8XMz2fV-_JkEc7ng-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0FF0C192CC46; Wed, 21 Jul 2021 17:20:23 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-112-62.rdu2.redhat.com [10.10.112.62]) by smtp.corp.redhat.com (Postfix) with ESMTP id A7BD35D9DD; Wed, 21 Jul 2021 17:20:15 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <0555748529d483fb9b69eceb56bf9ebc1efceaf1.camel@redhat.com> References: <0555748529d483fb9b69eceb56bf9ebc1efceaf1.camel@redhat.com> <162687506932.276387.14456718890524355509.stgit@warthog.procyon.org.uk> <162687509306.276387.7579641363406546284.stgit@warthog.procyon.org.uk> To: Jeff Layton Cc: dhowells@redhat.com, linux-fsdevel@vger.kernel.org, "Matthew Wilcox (Oracle)" , Anna Schumaker , Steve French , Dominique Martinet , Mike Marshall , David Wysochanski , Shyam Prasad N , Miklos Szeredi , Linus Torvalds , linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs-developer@lists.sourceforge.net, devel@lists.orangefs.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 02/12] netfs: Add an iov_iter to the read subreq for the network fs/cache to use MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <289703.1626888014.1@warthog.procyon.org.uk> Date: Wed, 21 Jul 2021 18:20:14 +0100 Message-ID: <289704.1626888014@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Jeff Layton wrote: > > - iov_iter_xarray(&iter, WRITE, &subreq->rreq->mapping->i_pages, > > + iov_iter_xarray(&iter, READ, &subreq->rreq->mapping->i_pages, > > What's up with the WRITE -> READ change here? Was that a preexisting > bug? Actually, yes - I need to split that out and send it to Linus. David