Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [nfs-utils PATCH 1/2] nfsdcltrack/sqlite: Fix printf format
To:     Petr Vorel <petr.vorel@gmail.com>, linux-nfs@vger.kernel.org
References: <20210722161545.26923-1-petr.vorel@gmail.com>
From:   Steve Dickson <steved@redhat.com>
Message-ID: <a186a8c6-26d5-e2e9-2950-8d4a743f901b@redhat.com>
Date:   Mon, 26 Jul 2021 12:31:13 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210722161545.26923-1-petr.vorel@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 7/22/21 12:15 PM, Petr Vorel wrote:
> sqlite.c: In function 'sqlite_remove_unreclaimed':
> sqlite.c:547:71: error: format '%ld' expects argument of type 'long int', but argument 4 has type 'time_t' {aka 'long long int'} [-Werror=format=]
>    547 |  ret = snprintf(buf, sizeof(buf), "DELETE FROM clients WHERE time < %ld",
>        |                                                                     ~~^
>        |                                                                       |
>        |                                                                       long int
>        |                                                                     %lld
>    548 |    grace_start);
>        |    ~~~~~~~~~~~
>        |    |
>        |    time_t {aka long long int}
> 
> Found in Buildroot riscv32 build.
> 
> Link: http://autobuild.buildroot.net/results/9bc1d43a588338b7395af7bc97535ee16a6ea2d9/build-end.log
> 
> Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
Both Committed... (tag: nfs-utils-2-5-5-rc1)

steved
> ---
>   utils/nfsdcltrack/sqlite.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/utils/nfsdcltrack/sqlite.c b/utils/nfsdcltrack/sqlite.c
> index f79aebb3..cea4a411 100644
> --- a/utils/nfsdcltrack/sqlite.c
> +++ b/utils/nfsdcltrack/sqlite.c
> @@ -46,6 +46,7 @@
>   #include <sys/stat.h>
>   #include <sys/types.h>
>   #include <fcntl.h>
> +#include <inttypes.h>
>   #include <unistd.h>
>   #include <sqlite3.h>
>   #include <linux/limits.h>
> @@ -544,7 +545,7 @@ sqlite_remove_unreclaimed(time_t grace_start)
>   	int ret;
>   	char *err = NULL;
>   
> -	ret = snprintf(buf, sizeof(buf), "DELETE FROM clients WHERE time < %ld",
> +	ret = snprintf(buf, sizeof(buf), "DELETE FROM clients WHERE time < %"PRIu64,
>   			grace_start);
>   	if (ret < 0) {
>   		return ret;
>