Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp6528679pxv; Thu, 29 Jul 2021 17:32:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJynTO4wjNOLdKKC8arT87nGJlb6e9+/SEIGHKnOcizroRBYZ8ltAbgTb4h5CF7gEdQkRhY8 X-Received: by 2002:a50:bb43:: with SMTP id y61mr8999491ede.22.1627605123926; Thu, 29 Jul 2021 17:32:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627605123; cv=none; d=google.com; s=arc-20160816; b=x4ke/PVu84o9M3mD5hlI+HgVR9O9veWl1dxhed/hyDHYXkKYfKl0KnVwBccPReTpI7 +zR34HVOzbevr9R+Klq5ivCNyyoF4cd1f020/NUK/JK4QrGcVSFNbzsbyJ7hsVoI0Yxh fAgigU95J3UKJyOsHMdbFh+z0SR2ur5gr5kCuSbyfOU5lBe0pqRrO79KBZefEyMROeKg ZuvRewgV6nb3RCmcGj62lse1ihSD5F/4BHUCyA3/6ZA0rCCwvs8UQtb0Tq/D4KNa3vqy Vemt+ntpQDA034w/Npke09xlZKBsy86kgddmRS7Lt4spYIFoDQlB2yfOSDdFNXAVAcz5 FXPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=XlS6JIET2ahgKktRyp1Qe3H7usbypoaogH5NBKCpzpc=; b=XLwurCKdr3EYeX7T8wxnF5H9q/EMQ+jm2HrEtV2kWgBM6KQjiT+EyPqj87APqN0Dj/ N0mCKMkMQgZxdadd/Ft027B8+E0g60x80UxAFDZC5Z2zIoH1bxekvTsMS8i0BZhzWere h39k5yG0ERGVvBxR6pCgg0mav4Y3GQ9KE6QSeFO5bUgQvB8p6y6U8B0AR1KIEWL1DbgC vwEIX9bEHKGwmbGagUFeirTO5XfXGyKDA52KfqNrsTU3fORwgOmtoIx8hG18kf4Ow7nk 4wk4MIVXjPYE9PFGg0kIVrF98pcEGxsIhWNrbJ/Tg5lwOvDBzBbr47NLRbrPUtbLUFZC gGVg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cq4si4397edb.74.2021.07.29.17.31.39; Thu, 29 Jul 2021 17:32:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231520AbhG3Ab2 (ORCPT + 99 others); Thu, 29 Jul 2021 20:31:28 -0400 Received: from zeniv-ca.linux.org.uk ([142.44.231.140]:42764 "EHLO zeniv-ca.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231181AbhG3Ab1 (ORCPT ); Thu, 29 Jul 2021 20:31:27 -0400 Received: from viro by zeniv-ca.linux.org.uk with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9GQi-0052xR-6k; Fri, 30 Jul 2021 00:31:12 +0000 Date: Fri, 30 Jul 2021 00:31:12 +0000 From: Al Viro To: NeilBrown Cc: Christoph Hellwig , Josef Bacik , "J. Bruce Fields" , Chuck Lever , Chris Mason , David Sterba , linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-btrfs@vger.kernel.org Subject: Re: [PATCH 04/11] VFS: export lookup_mnt() Message-ID: References: <162742539595.32498.13687924366155737575.stgit@noble.brown> <162742546551.32498.5847026750506620683.stgit@noble.brown> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <162742546551.32498.5847026750506620683.stgit@noble.brown> Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Wed, Jul 28, 2021 at 08:37:45AM +1000, NeilBrown wrote: > In order to support filehandle lookup in filesystems with internal > mounts (multiple subvols in the one filesystem) reconnect_path() in > exportfs will need to find out if a given dentry is already mounted. > This can be done with the function lookup_mnt(), so export that to make > it available. IMO having exportfs modular is wrong - note that fs/fhandle.c is * calling functions in exportfs * non-modular * ... and not going to be modular, no matter what - there are syscalls in it.