Received: by 2002:a9a:4c47:0:b029:116:c383:538 with SMTP id u7csp7559177lko; Fri, 30 Jul 2021 06:26:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzDGsIQnsLgDhswfEHnQ6Jy7rfHdYKxohNlkChgbWr2R8KLuiRD7alxV5xDJUuYdKp/8lCd X-Received: by 2002:a92:1942:: with SMTP id e2mr833426ilm.4.1627651611958; Fri, 30 Jul 2021 06:26:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627651611; cv=none; d=google.com; s=arc-20160816; b=K436KJPBWI4KCAzoldk64K35mIz2Lbv10/SgoY7cA89MEG5NjsH4dKxHKSaSoKNFJk Byxn+8HOvN2nrghet8Ey8KACJVYLowt7TqRPovwLPAb50BkPp3r0EwTtCdaUDnidt76H FNts/sFIvSJKmHdEfmctZ+4aRVB+SzN78Yiz9fJ5FEr53PQq3OZf0G6QsWCPBa8O1i4v 3V6pqQfkM7m3QH7T/6DzVIbBz8CahxkOE+gbutJ93qbiBQpI10MAxAl3yxy3OYP6FbyY XxvomaY8m1oJw5nKiw6muzsoE6eM/X0P3uQbtmI96yfqJ2C8Ij6cuAGiLGPdOQoqAqnX sWEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from :dkim-signature; bh=9VcuZIvScbJB6g6d0ufI7w9hFQSZu1svBZfTXQSpqzI=; b=O/0BPVTA1zo+qjJAqKy7r87aQTkvj7fsazb+KI2SxFO6MBt7ZRfhpJBLJcZT34RlXp Yyg8Qhe7mEfo4p8Cijjy6oOhxLjWXFxftevRo4yJDnVlP2RPXAwfbGKGO8xMy1haw1HE ounZswjRKLvSuTA3ajxev4n34uA8mdGh4uq+HQZddlhZWjX/ZExXkzrE1FRlU49dI5/Y VaTwctX7yF1yBQ4BLl5BBrm7OFLB0EpuuI9WxaMezg5eYxqS+kIrB55Rfm0NS2b1YOgr trBbpdDJtfRvarwWldXidd6WK7M3qhPWlamcQXN9z/SpgPYjTaJFsCJyDcKpf6N3uKwx euuQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="jAmne/qY"; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z4si1890708ioz.87.2021.07.30.06.26.27; Fri, 30 Jul 2021 06:26:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="jAmne/qY"; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230523AbhG3N0Z (ORCPT + 99 others); Fri, 30 Jul 2021 09:26:25 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:59358 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230480AbhG3N0Z (ORCPT ); Fri, 30 Jul 2021 09:26:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627651579; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=9VcuZIvScbJB6g6d0ufI7w9hFQSZu1svBZfTXQSpqzI=; b=jAmne/qYgf04QWvsRhGAU6cibJFVuia9qvLXxDlIXcfCQWEPo4ZYNXy9SBzScdqVa30HS0 rP691WlWjYxsL7Vk4zlSeZOn+z73QUCQc2JDIKYYymL7dlPa79cCBfpTlLAbRZWZpvCwoy FkI2s7Sm2HeoxG5REEXe/O63XIvHP6k= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-549-hdBCOFLCNPm5VdDAIjA_2w-1; Fri, 30 Jul 2021 09:26:16 -0400 X-MC-Unique: hdBCOFLCNPm5VdDAIjA_2w-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B7656802CB9; Fri, 30 Jul 2021 13:26:01 +0000 (UTC) Received: from [172.16.176.1] (ovpn-64-2.rdu2.redhat.com [10.10.64.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 59A625D9D5; Fri, 30 Jul 2021 13:26:01 +0000 (UTC) From: "Benjamin Coddington" To: "Trond Myklebust" , "Linux NFS Mailing List" Cc: "Pierguido Lambri" Subject: cto changes for v4 atomic open Date: Fri, 30 Jul 2021 09:25:59 -0400 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org I have some folks unhappy about behavior changes after: 479219218fbe NFS: Optimise away the close-to-open GETATTR when we have NFSv4 OPEN Before this change, a client holding a RO open would invalidate the pagecache when doing a second RW open. Now the client doesn't invalidate the pagecache, though technically it could because we see a changeattr update on the RW OPEN response. I feel this is a grey area in CTO if we're already holding an open. Do we know how the client ought to behave in this case? Should the client's open upgrade to RW invalidate the pagecache? Ben