Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Trond Myklebust <trondmy@hammerspace.com>
CC:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v2 0/7] XDR overhaul of NFS callback service
Thread-Topic: [PATCH v2 0/7] XDR overhaul of NFS callback service
Thread-Index: AQHXebMTaSxcscBFIk+X10jNgh8JrKtcBXKA
Date:   Fri, 30 Jul 2021 19:52:28 +0000
Message-ID: <02B12E59-E014-4CF6-9A5B-58E5F426F964@oracle.com>
References: <162637843471.728653.5920517086867549998.stgit@manet.1015granger.net>
In-Reply-To: <162637843471.728653.5920517086867549998.stgit@manet.1015granger.net>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?lA46NVGaNxeavar/syyuko69UewegdE9m4wxIgrjut6ze9DvDmC44rj9RIn/?=
 =?us-ascii?Q?r0t4Es9SoYQeHmMUmGl3ADxF341CNKUctQ/mzqm2KRSiMi8AESg1uVgnqeUo?=
 =?us-ascii?Q?UVRzAduu3kPp04xN/YTN22cZGHpDfgzFnXlOTv3hidmjmnY1biECc4pREpvq?=
 =?us-ascii?Q?7vwTQz1DKLFfPwwNY/TpAY1cdQr5mZf4Wv3cdFD49OAZEb/bLED4EX24QSt0?=
 =?us-ascii?Q?893xivTZD36kIzIF4dpSLM5sGNFj4zdzlHfG/Nt+e5YtFoq49kHKCc9p0vCI?=
 =?us-ascii?Q?VHx+lG7FP8Jy3Asmlse3u1dwzADdH6+XOaasAf328wSzcHmtUI2irvLyOnBs?=
 =?us-ascii?Q?dljwGL68aBicaZT2yOs9qxVPpbI/jRNKQryRWTK0sLKnuW/8nLMmKc11NVzn?=
 =?us-ascii?Q?e8vZMKmHhBtWRrCgxzqAafYpNo1dNHPj64xdVIOqSkG3znkmeqirc9TKBQTn?=
 =?us-ascii?Q?OdWNh3RCCGWCDYeFTP+To3bRn9IS1NMyuTHCGla47U7QUixNLHRGTezYYoRj?=
 =?us-ascii?Q?OYHKcg2eKVaDqYSUDWrOcGnUnJlY6sJDEAjazKLGu4TBB041sM7hS41SFZ4Y?=
 =?us-ascii?Q?DUwIIUUYlb/4ttZY+fXggGobArGdsXQXu9jjHcv5PHSr24xF1pugREo8w7KY?=
 =?us-ascii?Q?O8d9Op4dKo8Qjx6xhOLGp9VwGsyYqUqEd5mqsadailf9XaAVa8Xswvs9iYWQ?=
 =?us-ascii?Q?3AqRABAXlBEX5E6cA30565uhBxw5cFQ8iUgTgZXNav4O7dcrIX8QivgyteDd?=
 =?us-ascii?Q?g8hAIlvatbjd7a+XF8jRguxHRCoJ0dNvt5Aenm3e5p9qIdW6RLlVmU1sjixs?=
 =?us-ascii?Q?BIjcid8CyitU9TNZO9cPGqZ/j9PfNEiWi9DcMOJ/pEp5WiLVwM+OIkf5gTbM?=
 =?us-ascii?Q?8QXNiCgk5lzXuR2TZU08lxVrf0vHQ0aL7dk/LhkoD0tUp0mwQ+iqyE0AQe2j?=
 =?us-ascii?Q?Hu+9VY6cfv7Ni+bSwf4zABmAP8qiCXDQRx18i3TiFP6ylh3eZSlKmEkker2/?=
 =?us-ascii?Q?osRwmWkGaQCIFROz87A2zW7VojOzeaYMu2+Ir4W4et/mrzvkIbEMgR6smJWp?=
 =?us-ascii?Q?67tw2MMxHOZvUYzXedmRvyqgdKVF8UL/a02Nq399uf6ztr4+9hBiMVnrTpe2?=
 =?us-ascii?Q?HJG0ucSJ+YfcXIY57C77ZsSY91kOOdDG6k8MRjAiRffPH1rHHSXr5sDhWfbf?=
 =?us-ascii?Q?k8F0VqZo8aD87wBa6v40bYFcAziOsZRtYCPf4d24a6DUEwW55wEM4PNNf/W5?=
 =?us-ascii?Q?NqDBL0MAXNJTpDAxDDUwKA3iBENAHl07jPhdJQxJt9NPBoQEe1SFMbP0C0Pq?=
 =?us-ascii?Q?UXiJOA60pRXCuSuvsVtjKRk6?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <B166CED00475BB4690DE0D3A5EC4D206@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4688.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e22dfc57-6eec-4b21-7b2c-08d953938f9d
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jul 2021 19:52:28.1459
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 8j6ldByM3kAZWSihdjP0gkqRJA+t0Q32KgqPPb1/uzxa1272JzD8Tt1AxZ7A6O7lt12XCo2z7WBvmTyEilhe0Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5648
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10061 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0
 suspectscore=0 phishscore=0 mlxscore=0 bulkscore=0 mlxlogscore=999
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2107140000 definitions=main-2107300135
X-Proofpoint-GUID: yVzLTvE7xgB1P_W0vdMp5YQyQxWYHMcR
X-Proofpoint-ORIG-GUID: yVzLTvE7xgB1P_W0vdMp5YQyQxWYHMcR
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

Hi Trond-

> On Jul 15, 2021, at 3:52 PM, Chuck Lever <chuck.lever@oracle.com> wrote:
>=20
> Trond, please let me know if you want to take these or if I may
> handle them through the NFSD tree for v5.15. Thanks.

I've included these in the NFSD for-next topic branch:

https://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git/commit/?h=3Df=
or-next

They can be removed if you would like to take them through
your tree instead.

If I am to take these, Bruce and I would like an Acked-by:
from you.


> The purpose of this series is to prepare for the optimization of
> svc_process_common() to handle NFSD workloads more efficiently. In
> other words, NFSD should be the lubricated common case, and callback
> is the use case that takes exceptional paths.
>=20
> Changes since RFC:
> - Removed RQ_DROPME test from nfs_callback_dispatch()
> - Restored .pc_encode call-outs to prevent dropped replies
> - Fixed whitespace damage
>=20
> ---
>=20
> Chuck Lever (7):
>      SUNRPC: Add svc_rqst::rq_auth_stat
>      SUNRPC: Set rq_auth_stat in the pg_authenticate() callout
>      SUNRPC: Eliminate the RQ_AUTHERR flag
>      NFS: Add a private local dispatcher for NFSv4 callback operations
>      NFS: Remove unused callback void decoder
>      NFS: Extract the xdr_init_encode/decode() calls from decode_compound
>      NFS: Clean up the synopsis of callback process_op()
>=20
>=20
> fs/lockd/svc.c                    |  2 +
> fs/nfs/callback.c                 |  4 ++
> fs/nfs/callback_xdr.c             | 61 ++++++++++++++++---------------
> include/linux/sunrpc/svc.h        |  3 +-
> include/linux/sunrpc/svcauth.h    |  4 +-
> include/trace/events/sunrpc.h     |  9 ++---
> net/sunrpc/auth_gss/svcauth_gss.c | 47 +++++++++++++-----------
> net/sunrpc/svc.c                  | 39 ++++++--------------
> net/sunrpc/svcauth.c              |  8 ++--
> net/sunrpc/svcauth_unix.c         | 18 +++++----
> 10 files changed, 96 insertions(+), 99 deletions(-)
>=20
> --
> Chuck Lever
>=20

--
Chuck Lever