Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Bruce Fields <bfields@fieldses.org>
CC:     Thomas Huth <thuth@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        Trond Myklebust <trond.myklebust@hammerspace.com>,
        Anna Schumaker <anna.schumaker@netapp.com>,
        Luis Chamberlain <mcgrof@kernel.org>,
        Kees Cook <keescook@chromium.org>,
        Iurii Zaikin <yzaikin@google.com>,
        "linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
        Jia He <hejianet@gmail.com>,
        Pan Xinhui <xinhui.pan@linux.vnet.ibm.com>
Subject: Re: [PATCH 0/2] Fix /proc/sys/fs/nfs/nsm_use_hostnames on big endian
 machines
Thread-Topic: [PATCH 0/2] Fix /proc/sys/fs/nfs/nsm_use_hostnames on big endian
 machines
Thread-Index: AQHXiFazbCL8ap5xPUS5u/husB93Vqth0XgAgAAERgA=
Date:   Tue, 3 Aug 2021 14:24:05 +0000
Message-ID: <73F77F37-DF04-46C3-97C8-2DD7EC043BDF@oracle.com>
References: <20210803105937.52052-1-thuth@redhat.com>
 <20210803140846.GB30327@fieldses.org>
In-Reply-To: <20210803140846.GB30327@fieldses.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?nNYUqudniXGViQAvctpOT4uRK6v5YvLPb1uu51CwpL9ucxqu6IwHGIDLrctS?=
 =?us-ascii?Q?NR7B1/tROgK7rJdDKthO6DwYiIEhd71daxoFC3bvQ5TfFO0o9jXd+8RysOOv?=
 =?us-ascii?Q?8ZO3wyY0g7zTeCULASYCybUP1pmRHHqyXszrD7sOzhV4Uh1z1ZzzTbM3/jWy?=
 =?us-ascii?Q?ZU65bO9PDiAxbJPLQJNvm1WMheK80rh1Qjzftos7Px64xh9JNbdwe8qM+s0R?=
 =?us-ascii?Q?NTqQZjDzAPS6mMzuQTnzc2SjxKrgmSWK8tQxjjGucYHcxIFE9mfEl3Sbhkd1?=
 =?us-ascii?Q?Nw+HRwwnVsC14Nl2r+mCuqPIPx0GvwV8u0sm+rKDleA7gYPgmvY8kkOK2eFm?=
 =?us-ascii?Q?kVu+cj/hFxf+7ZFM4q7hDwPLxACLnbhvFqyrQ6UEtcLQ+RX9joYDrS0q5Fmu?=
 =?us-ascii?Q?g9AHTBj0Z96DjSdPnBnFR4Oksabw8UxHF3fEMKqHcMom18Fe+RVkIzZU+V1C?=
 =?us-ascii?Q?1SyHM/8E7q5bCCd5bhMIMS3CSfw2TF3h5eWWMuoKCvwVMEAr5QKbCo+3HdQL?=
 =?us-ascii?Q?p+7QVL3OQJERaBACz8ph4eHXORxRs14bvj9dfuPXGFuJVjogVQHwlyXaok6x?=
 =?us-ascii?Q?d6FJYiY+aUDSDts+Xm3ihCDURKUiufHbWvPL8ZrEr3r0WFw1laQMRDwnSlMi?=
 =?us-ascii?Q?SDzMFpG2oLRE/jVlKihFKjIAqpuDs+tPcgc/BNUHrCFI4l1QTZAQYJdbhryC?=
 =?us-ascii?Q?vE0ODyUV46k/HFjwYTlajuFu+1eHE2xsXJMDKdhMnDFzo1WYgxKgD6PXYzEm?=
 =?us-ascii?Q?MAeXJm0oAmICwQ0hwcAVRmwiFQThPWXuvpzNOOubCiYB/ZuizzBc8YoXB2bi?=
 =?us-ascii?Q?Je74t9QSfsYRkS+bHUfARJ6T8+r/l47VFK3io3x4wj/Iki+vTs1K+Qq6i4F5?=
 =?us-ascii?Q?iQaL5JVDwRlhkdKMXo9X255LVcq5G8RAzKjMdxFB/pISJauW7fshdD4ZjCfQ?=
 =?us-ascii?Q?SzBhJNOY6h3CVlc/q1geNv6dEPzNQ0sLFSF48PtFCPQ9C467wMISyNMRtmao?=
 =?us-ascii?Q?6lJ4ClEXtMffr2JV8XjqVp7NpfTL7mlZl+5+teJA6bZ4RSNw3JnfhFzxBzGZ?=
 =?us-ascii?Q?Ed88/Af0VELSr/2h6tGLeqLVpxmzewEQY/VbnfS1VP2PL0cB+h9A3x0VPZvO?=
 =?us-ascii?Q?n59y66djbiaQbNdPiq5B3BR6Qm0rrA2sIsk9zUXxXXPLuCmgILQENo/o6x6w?=
 =?us-ascii?Q?+27B9aFzRdBxXy8CqxLXkwA3zXtmgkHf6E8csju2DxaQJhG6jduVDBhZNy7Z?=
 =?us-ascii?Q?+rGiIAs+YUEgJQi2DENGBADIbJbe/538kqt3LhbvF2aiNLkgdOB/F/IA5DEp?=
 =?us-ascii?Q?n3Wak8j7Sl9YObLKi10izuMM?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <CE0B98FA7588494896FEAC76EEC295DC@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4688.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 60041475-4c9d-4272-e25f-08d9568a5965
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Aug 2021 14:24:05.4243
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: IjKBsoROYJBLmMqbWRf3qHrPEB+RZOpZvzFnhtviPV18vg/4b/9v1L+v19UdK6F9mmxDqBI6pdIfMA4zumRRxQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4306
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10064 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 phishscore=0
 spamscore=0 adultscore=0 suspectscore=0 mlxlogscore=999 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000
 definitions=main-2108030095
X-Proofpoint-GUID: V3CHRMlhZFcVoSh9WIYzFp1Rvm4EYh1_
X-Proofpoint-ORIG-GUID: V3CHRMlhZFcVoSh9WIYzFp1Rvm4EYh1_
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

Thanks for your review, Bruce. I'll watch for the additional Ack.

> On Aug 3, 2021, at 10:08 AM, J. Bruce Fields <bfields@fieldses.org> wrote=
:
>=20
> Looks good to me.  Could Chuck take it with nfsd stuff if somebody could
> ACK the sysctl part?
>=20
> --b.
>=20
> On Tue, Aug 03, 2021 at 12:59:35PM +0200, Thomas Huth wrote:
>> There is an endianess problem with /proc/sys/fs/nfs/nsm_use_hostnames
>> (which can e.g. be seen on an s390x host) :
>>=20
>> # modprobe lockd nsm_use_hostnames=3D1
>> # cat /proc/sys/fs/nfs/nsm_use_hostnames
>> 16777216
>>=20
>> The nsm_use_hostnames variable is declared as "bool" which is required
>> for the correct type for the module parameter. However, this does not
>> work correctly with the entry in the /proc filesystem since this
>> currently requires "int".
>>=20
>> Jia He already provided patches for this problem a couple of years ago,
>> but apparently they felt through the cracks and never got merged. So
>> here's a rebased version to finally fix this issue.
>>=20
>> Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=3D1764075
>>=20
>> Jia He (2):
>>  sysctl: introduce new proc handler proc_dobool
>>  lockd: change the proc_handler for nsm_use_hostnames
>>=20
>> fs/lockd/svc.c         |  2 +-
>> include/linux/sysctl.h |  2 ++
>> kernel/sysctl.c        | 42 ++++++++++++++++++++++++++++++++++++++++++
>> 3 files changed, 45 insertions(+), 1 deletion(-)
>>=20
>> --=20
>> 2.27.0

--
Chuck Lever