Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp3047017pxt; Mon, 9 Aug 2021 15:40:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzwS5jhEr1KGAdGzBmeZNpfXe6qtPHxZPeLFfNGzfSRtJFBFcMIRDqL7ZYlOv2JkbOsIusH X-Received: by 2002:a5e:8d06:: with SMTP id m6mr14045ioj.18.1628548835345; Mon, 09 Aug 2021 15:40:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628548835; cv=none; d=google.com; s=arc-20160816; b=ROxHVc/NsdB98ARN6VH7+p7c7v8NF/tnvuglSHFVJw10n4t5gUtqjs7cVmntyHwFjR oVrXeVVF+P1YErE5lbgoMwef7JDlb+qKUxE1xlwdDEgxUgwDAVcriJj6r+uSKa6voVSK f6pIBMsELinyCg9mbIHhtz8CTvUfIvIWfXBvME6U6Sybo+BnTgrBRI1LxtJhi/D3OBuU oKn2Ple/H7KmzNA1p/J1GmnyPxQWMgHrgAQJvKschpF1MXR7eNMmCLq77zQmRCXQOuGM SGSUfrUtc8hJOIgD35vrqGjVtyo0i29O9vHr3iJV2gltM4ks5jNgaY+Dc1+JbW4CqAKx rv5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version; bh=RTYB3u5kizoIG6eLk8Z5TNp6x9mo8pJAvqo9sxu44ic=; b=NotdBZ3q8E24vN7AT4rXhGXLOO6LSsBdwNgT8UEoNHtABt8lGeP4w+XBET3SB9S/P/ L307SR5PNOiPbemUdMt5IaW9k6AeBJhstqCh/am2ZtS6zxBdNmn8Udm2CS9sGhtZTUsk fTnq/pSThTsrARNn1EmMb7uyfCY/ICdI2mY8beVKIC8jKStBGtaY1S5XpBgk+fCRBWM4 z/izeoGby5KxnmYmvxVGnzKY8l5xgQLLvJskpv/Lsk3uRHV9RY4iFyNzwULJziNqYLJb PQos4FP3e5r50zao8wUncUOEC8cu4nkOBeEZZDb5mKumT8DjeqzlDOJWgDQD+rLby6Fa T36A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=netapp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c8si21513426ilq.88.2021.08.09.15.40.11; Mon, 09 Aug 2021 15:40:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=netapp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233894AbhHIUh5 (ORCPT + 99 others); Mon, 9 Aug 2021 16:37:57 -0400 Received: from mail-ed1-f44.google.com ([209.85.208.44]:39570 "EHLO mail-ed1-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233500AbhHIUh4 (ORCPT ); Mon, 9 Aug 2021 16:37:56 -0400 Received: by mail-ed1-f44.google.com with SMTP id t1so99574edd.6 for ; Mon, 09 Aug 2021 13:37:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RTYB3u5kizoIG6eLk8Z5TNp6x9mo8pJAvqo9sxu44ic=; b=uQTMRhjhCxXgvQyjwAnq/Xx50cPDJVHkfQTBR1ZHbkxSvC6A0979/fif9mUlgSCmgG AjLqFYXMgtKMGb7VKQ/l25Kk+D6UhgrX17hWetMJqwKe26pvKm5RrH8prn8pnBv2ZINh rxCnvGH3/ow451g1YfPRSnAuDwSX4QXprGzC+SeFakztIr4VU8gcgWi1ZARW3QZ/T8TL fTYk0SlcKVCgkl0KTCcWoHGtseo1nZ0o84wS/3hmqIwc3fIJrnQ3g+Jof8bbfQ59C+Un MhiuculTUnsRRExLULq7yIh41O7LsD7vGlIfZGqS2aFHAfDFr45QIo5g6Oe7tN3Jjsz/ sFWw== X-Gm-Message-State: AOAM5308m7Uux1YHqaUxXa2Cqv3gjy47K8cWhvKTrIC7+/oey47OQnNJ bW8ieDde6UJUYI0cab4+LnGcyuHYRY0Dh47o5Eg= X-Received: by 2002:a05:6402:1206:: with SMTP id c6mr190639edw.264.1628541454989; Mon, 09 Aug 2021 13:37:34 -0700 (PDT) MIME-Version: 1.0 References: <162670594361.468132.16222376053830760696.stgit@manet.1015granger.net> In-Reply-To: <162670594361.468132.16222376053830760696.stgit@manet.1015granger.net> From: Anna Schumaker Date: Mon, 9 Aug 2021 16:37:18 -0400 Message-ID: Subject: Re: [PATCH v2 0/6] Ensure RPC_TASK_NORTO is disabled for select operations To: Chuck Lever Cc: Trond Myklebust , Linux NFS Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Hi Chuck, On Mon, Jul 19, 2021 at 10:55 AM Chuck Lever wrote: > > This is a set of patches I've been toying with to get better > responsiveness from a client when a transport remains connected but > the server is not returning RPC replies. > > The approach I've taken is to disable RPC_TASK_NO_RETRANS_TIMEOUT > for a few particular operations to enable them to time out even > though the connection is still operational. It could be > appropriate to take this approach for any idempotent operation > that cannot be killed with a ^C. > > Changes since RFC: > - Dropped changes to async lease renewal and DESTROY_SESSION|CLIENTID > - Cleaned up some tracepoint issues I found along the way Is this the latest version of these patches? If so I can include them in my linux-next branch for 5.14. Thanks, Anna > > --- > > Chuck Lever (6): > SUNRPC: Refactor rpc_ping() > SUNRPC: Unset RPC_TASK_NO_RETRANS_TIMEOUT for NULL RPCs > SUNRPC: Remove unneeded TRACE_DEFINE_ENUMs > SUNRPC: Update trace flags > SUNRPC: xprt_retransmit() displays the the NULL procedure incorrectly > SUNRPC: Record timeout value in xprt_retransmit tracepoint > > > include/trace/events/sunrpc.h | 51 ++++++++--------------------------- > net/sunrpc/clnt.c | 33 ++++++++++++++++------- > 2 files changed, 35 insertions(+), 49 deletions(-) > > -- > Chuck Lever >