Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Anna Schumaker <anna.schumaker@netapp.com>
CC:     Trond Myklebust <trondmy@hammerspace.com>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v2 0/6] Ensure RPC_TASK_NORTO is disabled for select
 operations
Thread-Topic: [PATCH v2 0/6] Ensure RPC_TASK_NORTO is disabled for select
 operations
Thread-Index: AQHXfWrpQ+V2VrMKW0eAjD9LScOT9qtrwdoAgAAAbgA=
Date:   Mon, 9 Aug 2021 20:38:51 +0000
Message-ID: <82A33007-6AE7-49BF-84CF-F960DA1548E3@oracle.com>
References: <162670594361.468132.16222376053830760696.stgit@manet.1015granger.net>
 <CAFX2Jf=PvvsU8p+3i3OdLOwRCWDedBKhbhnNOe-RyaXx5LWUow@mail.gmail.com>
In-Reply-To: <CAFX2Jf=PvvsU8p+3i3OdLOwRCWDedBKhbhnNOe-RyaXx5LWUow@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?W3a5/GB/LIyjREYM1qA51zug6D+qVhbTxoJfHNX/VSD5M03feLLirRtf2Haf?=
 =?us-ascii?Q?afU3hzMRTXBm+IdgXKy1q5m/beYAzhYizUVNm/dj+KMDrpWKHv8odSBX74pa?=
 =?us-ascii?Q?ccmKggd+XvMaH7WGNExchILNTwKtq75lIqh7EZnQ9P9NGt3xg01m1lQNH2V1?=
 =?us-ascii?Q?e43SXOEAugWJcjZARfImetq5pUbgb6aOdt+ePgdZtcR8Ixy+PFOPZGRtQjrP?=
 =?us-ascii?Q?8sDG7l0Dct8ImRzvj4wkZsXm8WU/mbPCXQv3q0qITfAUd++DbFQVK+YMx8NT?=
 =?us-ascii?Q?AASrCXd+6Aa/kslyOixPWEBYSerf7QZcNTBysEfQMcIHpysu4NxVRqEaiP5y?=
 =?us-ascii?Q?gy8WaNuYek41eTQBVJ3qpQPD197HxRvx2QLli+RR5IFBXyFlrmaKX01kz1n1?=
 =?us-ascii?Q?tJ8PRsWFaBp0lYY1vh9z/CnWG7AFxjrAGpBzMFsYU8tvNKXPpETfLljWmg1Y?=
 =?us-ascii?Q?JcHgNHYsXP1SuGaIvvFE50OtDUGRR2OT+F09S9Py1kUP8O/AgQCIT1I9JQW4?=
 =?us-ascii?Q?iamLMhuj2lCOjVvd2Uikd0yWeXw3V6MUrCX/lfv1kuv3apS18eFpNQ2V+e1F?=
 =?us-ascii?Q?d2kUWHmOq04l/Z/P8v67at2KZjkIVYyKK4fC/BDtkWOE0N478MFI5rpGpEvf?=
 =?us-ascii?Q?Piba/HWzprCtZRqroUkKZ/GkcG0UrjAvfhcPVgyERwbzkj+DCocFUamoBYce?=
 =?us-ascii?Q?D8iXquxzsNW/zE71/vwjyE/9CHvJ0WOdQBmBdIh2Y0/yNwcyIXvOg5J9bNpg?=
 =?us-ascii?Q?lP/EyS5S+CtWlOrIdx2mx/yvGcr8DoF+D4/E2Zez7g2yRr2DHtcZlMDLCFh0?=
 =?us-ascii?Q?fLhz9Zb9f4/I8qiOvJut7+d9CvCdiN5/4Jgee8aAmFZD2hqguBHdrJ14fP7M?=
 =?us-ascii?Q?2AzixVBMiiMUq07uQS8Nnnsv1e9mOxT4ipY8pqGqpLZswX/R2y2jlyVOnf09?=
 =?us-ascii?Q?fPOGmOFhw/xbA/YNwfrA0zjD6MBUactf38KIDvOYeyhEZc1H+VKEvaEg/8tO?=
 =?us-ascii?Q?v4av4wFWe+KxRxRrpONgCnKqVcr9d/QMBGTeasiYZzELSzd3v0buepHLKdni?=
 =?us-ascii?Q?9bRbRMin7F9lvfz3n4GBGiuPEpkL4lmKpn9vOlVA3t2ySKBuCO0q+Gkrts0a?=
 =?us-ascii?Q?XN0pGdp4knVzrumDrp2rENNZsRsDlxxlKPG9cRvimb4tfZYrtlme9oKf+uno?=
 =?us-ascii?Q?HdCQNTqUQdJDsHsBQ0Ddr25RqJMp9HFZbsaXxiiyI4HgjsD87YnoPxDAqQAR?=
 =?us-ascii?Q?yEunKpJ83/H5fNn+HzpUeKkr+laig59pH8JyBPR+OC44X50HDpl9XDm9cdI9?=
 =?us-ascii?Q?f3bupai20CYRvHdP4sbkXkiyw8c2KHOQhj1BI1bR3Hi8Lw=3D=3D?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <59E1E3378A9A614E9D93294D18A5984F@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4688.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e76716c1-aa9b-41a3-a058-08d95b75b264
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Aug 2021 20:38:51.0800
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: LLWIwiIUsdoPbYpLQwrU4egpEwCcY4RzDfb4hmZQJr90HD2aexcJuc0O78+V3WMLtM80L9LGyaY7emPlsyf5Iw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2517
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10071 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 mlxscore=0
 phishscore=0 spamscore=0 mlxlogscore=999 malwarescore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000
 definitions=main-2108090146
X-Proofpoint-GUID: x17gGHJBMMkTEKgflweRuH_BjqdtHbHv
X-Proofpoint-ORIG-GUID: x17gGHJBMMkTEKgflweRuH_BjqdtHbHv
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Aug 9, 2021, at 4:37 PM, Anna Schumaker <anna.schumaker@netapp.com> wr=
ote:
>=20
> Hi Chuck,
>=20
> On Mon, Jul 19, 2021 at 10:55 AM Chuck Lever <chuck.lever@oracle.com> wro=
te:
>>=20
>> This is a set of patches I've been toying with to get better
>> responsiveness from a client when a transport remains connected but
>> the server is not returning RPC replies.
>>=20
>> The approach I've taken is to disable RPC_TASK_NO_RETRANS_TIMEOUT
>> for a few particular operations to enable them to time out even
>> though the connection is still operational. It could be
>> appropriate to take this approach for any idempotent operation
>> that cannot be killed with a ^C.
>>=20
>> Changes since RFC:
>> - Dropped changes to async lease renewal and DESTROY_SESSION|CLIENTID
>> - Cleaned up some tracepoint issues I found along the way
>=20
> Is this the latest version of these patches? If so I can include them
> in my linux-next branch for 5.14.

AFAIR v2 is the latest, yes. Thanks!


> Thanks,
> Anna
>=20
>>=20
>> ---
>>=20
>> Chuck Lever (6):
>>      SUNRPC: Refactor rpc_ping()
>>      SUNRPC: Unset RPC_TASK_NO_RETRANS_TIMEOUT for NULL RPCs
>>      SUNRPC: Remove unneeded TRACE_DEFINE_ENUMs
>>      SUNRPC: Update trace flags
>>      SUNRPC: xprt_retransmit() displays the the NULL procedure incorrect=
ly
>>      SUNRPC: Record timeout value in xprt_retransmit tracepoint
>>=20
>>=20
>> include/trace/events/sunrpc.h | 51 ++++++++---------------------------
>> net/sunrpc/clnt.c             | 33 ++++++++++++++++-------
>> 2 files changed, 35 insertions(+), 49 deletions(-)
>>=20
>> --
>> Chuck Lever

--
Chuck Lever