Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Anna Schumaker <schumaker.anna@gmail.com>
CC:     Trond Myklebust <trondmy@hammerspace.com>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v2 0/7] XDR overhaul of NFS callback service
Thread-Topic: [PATCH v2 0/7] XDR overhaul of NFS callback service
Thread-Index: AQHXebMTaSxcscBFIk+X10jNgh8JrKtcBXKAgBEqtgCAAAQagA==
Date:   Tue, 10 Aug 2021 18:16:26 +0000
Message-ID: <BA8CF63B-5328-42C3-AE69-92766C0EF556@oracle.com>
References: <162637843471.728653.5920517086867549998.stgit@manet.1015granger.net>
 <02B12E59-E014-4CF6-9A5B-58E5F426F964@oracle.com>
 <CAFX2JfkSG5Qe4_svtunwRhMvwdN=bNP0VtuSFtU6siDihjWpZA@mail.gmail.com>
In-Reply-To: <CAFX2JfkSG5Qe4_svtunwRhMvwdN=bNP0VtuSFtU6siDihjWpZA@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?G8l16s9lqU/lGEEcTxKgCUatxj3tovEv1rtGPPW+0UnomFh+aj/Lk8LqliK2?=
 =?us-ascii?Q?sX7vyxJ4U2PtGbo3LLWF7X2Zsmawj0SffGGdD3jq9b+dttQ+hICC25L/QdUE?=
 =?us-ascii?Q?M+6ZBJkufnAPWagVM5Z/xsyTcIPjo/fnmd7vbF+qrOR4dUCE1ARz41X1aUVe?=
 =?us-ascii?Q?zMFFEEAalQTu1nJUfrggQUwRL7MvVwJ1t+AixtXNscH5ORKeG4PdIhwHBMXn?=
 =?us-ascii?Q?eA3lVNhs4stB9b0Y6iHFDfIUffP7q+oZLG3otqhzu16T/3UIILYlVIK5hcU4?=
 =?us-ascii?Q?lgGqO/UH3eHFYlaMFtg4XnE/dO7CLjLBPC3+59teuXSX/SlfOlgHi1BnhipQ?=
 =?us-ascii?Q?dK55zIB5jiFFn5O/Q1OIoEx0LvZVbtno8iiENC+PyCS4mo/Xe90xZ83osK7u?=
 =?us-ascii?Q?n2tMUc3M4uT1ZGRJ/FeQyzqK4QTE2upt3FoP0N51KmU9dPikbXVHRDjjHOjW?=
 =?us-ascii?Q?K2vZ0TUIZ5fX70FkrS90hWjaCwniSDfly5xM65qJhm8ohYyi/I6Bf9XH/DTe?=
 =?us-ascii?Q?sqjseMYtoeDNgy3tJzNI2ydFR1g3zsJCwiHZH6+ROHj9NUt8mfSli7ASVIHe?=
 =?us-ascii?Q?vg3rGOF2/1W0WvzE/W7UVR5Y7fmiymUBUKnFVcEpPCHoAVvSWg5HHENvRQjq?=
 =?us-ascii?Q?3L+gRipxdi75RNeOkFL6ggTeXoc8jGxCL/+PCPH+0WVNJ+eeI1YHY+hFYeup?=
 =?us-ascii?Q?PkelzPeq3yN10/t6cNN05VDdez8GTIZJhF0aT0FN/+A/+MIM7xcMBaMvRQtg?=
 =?us-ascii?Q?FxoV96mrzspsP/dtchOIOCWvu3ROzq3eZeOuLcUy5G5T9uyknQTw/jsO8Gq7?=
 =?us-ascii?Q?Lw+Z7IUnHt6lJ4n3fswb7jIs9x/y/JXBpznmOalDnavndVDbyiG73uLkcULy?=
 =?us-ascii?Q?Mg73UxaRrdoKjgoDNpKWQctBUgTQVRWnPemub9LXz77gXvnx/5NJHTKvd907?=
 =?us-ascii?Q?qFqBdYPgSHmJfcSMyFjeEu3fW2Bcj0LtoTE8STFlgpN6NgJNtV6+omFRX7Up?=
 =?us-ascii?Q?BPGshX8me4a5j1ZPQj4P/uSFkfu5hyZ5ZJI5O/mxKLlLW3L/96thWz5Aw21f?=
 =?us-ascii?Q?LQ2DxdU9IPm9iMDGhU7kX7mzhs8LSHjXTlYIBQrZUvTIGN+87aWKGLtL40ox?=
 =?us-ascii?Q?WYjr/Wq3vbglCD5yS3OJ0Yhc27GbrDvLzULqNYYbCF6710taze9/0cpWZJNb?=
 =?us-ascii?Q?gPtwOre9JG7aStQXzHP3hBsSgxqV9gY2P3bdCAJcB5wU3ulp7wh+KK72FMYm?=
 =?us-ascii?Q?2X/OSFZPM48dprM7r+Y8QnVO821VSmXy5H/RunAbHeTPNqGZAEO53AlDbt4A?=
 =?us-ascii?Q?EfklXFvqAzmKbQ1YDcKAOPheNe9yoXtsVcgD++33vbcd3A=3D=3D?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <CF82650C934DA94199D5A93526DF484D@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4688.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 31a9c4ec-d9bf-4971-04c6-08d95c2af7a3
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Aug 2021 18:16:26.1448
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: oBctC+KMsPJ37q1BKLmTjlKEFfCLZ2b648JtcO5tMxQUgsdR99yQGx565ecLjF6wE8+5ZnkNTxLmyGniPqgogQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4212
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10072 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 bulkscore=0
 spamscore=0 phishscore=0 mlxlogscore=999 suspectscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000
 definitions=main-2108100120
X-Proofpoint-ORIG-GUID: 0FkjCjFC9jZPC8Y_TKkXKVUhNHaFLfoX
X-Proofpoint-GUID: 0FkjCjFC9jZPC8Y_TKkXKVUhNHaFLfoX
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Aug 10, 2021, at 2:01 PM, Anna Schumaker <schumaker.anna@gmail.com> wr=
ote:
>=20
> Hi Chuck,
>=20
> On Fri, Jul 30, 2021 at 3:53 PM Chuck Lever III <chuck.lever@oracle.com> =
wrote:
>>=20
>> Hi Trond-
>>=20
>>> On Jul 15, 2021, at 3:52 PM, Chuck Lever <chuck.lever@oracle.com> wrote=
:
>>>=20
>>> Trond, please let me know if you want to take these or if I may
>>> handle them through the NFSD tree for v5.15. Thanks.
>>=20
>> I've included these in the NFSD for-next topic branch:
>>=20
>> https://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git/commit/?h=
=3Dfor-next
>>=20
>> They can be removed if you would like to take them through
>> your tree instead.
>=20
> These look to be mostly client-side changes, so it would make sense to
> take them through the NFS tree. Would that cause problems now that
> they've been in your for-next branch for a while?

I've dropped them.


> Anna
>=20
>>=20
>> If I am to take these, Bruce and I would like an Acked-by:
>> from you.
>>=20
>>=20
>>> The purpose of this series is to prepare for the optimization of
>>> svc_process_common() to handle NFSD workloads more efficiently. In
>>> other words, NFSD should be the lubricated common case, and callback
>>> is the use case that takes exceptional paths.
>>>=20
>>> Changes since RFC:
>>> - Removed RQ_DROPME test from nfs_callback_dispatch()
>>> - Restored .pc_encode call-outs to prevent dropped replies
>>> - Fixed whitespace damage
>>>=20
>>> ---
>>>=20
>>> Chuck Lever (7):
>>>     SUNRPC: Add svc_rqst::rq_auth_stat
>>>     SUNRPC: Set rq_auth_stat in the pg_authenticate() callout
>>>     SUNRPC: Eliminate the RQ_AUTHERR flag
>>>     NFS: Add a private local dispatcher for NFSv4 callback operations
>>>     NFS: Remove unused callback void decoder
>>>     NFS: Extract the xdr_init_encode/decode() calls from decode_compoun=
d
>>>     NFS: Clean up the synopsis of callback process_op()
>>>=20
>>>=20
>>> fs/lockd/svc.c                    |  2 +
>>> fs/nfs/callback.c                 |  4 ++
>>> fs/nfs/callback_xdr.c             | 61 ++++++++++++++++---------------
>>> include/linux/sunrpc/svc.h        |  3 +-
>>> include/linux/sunrpc/svcauth.h    |  4 +-
>>> include/trace/events/sunrpc.h     |  9 ++---
>>> net/sunrpc/auth_gss/svcauth_gss.c | 47 +++++++++++++-----------
>>> net/sunrpc/svc.c                  | 39 ++++++--------------
>>> net/sunrpc/svcauth.c              |  8 ++--
>>> net/sunrpc/svcauth_unix.c         | 18 +++++----
>>> 10 files changed, 96 insertions(+), 99 deletions(-)
>>>=20
>>> --
>>> Chuck Lever
>>>=20
>>=20
>> --
>> Chuck Lever

--
Chuck Lever