Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp450787pxb; Wed, 25 Aug 2021 07:06:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy0ADLhS9h789xV6As3zk0UjAmK1dmD2lYOmtWrpjLLxZE7iCYDw5mfzOn0wTd+kLFVf+Fs X-Received: by 2002:a05:6638:185:: with SMTP id a5mr6807187jaq.31.1629900388297; Wed, 25 Aug 2021 07:06:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629900388; cv=none; d=google.com; s=arc-20160816; b=iFqEZfixK1Cw1/OC/MpnRJB6zxfwPzJHjWrZDSxTRzCcfpBh57AWwhCiqnXKy+au92 qtISrktr3fMeZqSplfXlyQHGwdb6I9l7mdAXrQO4zxIp9s9xHKcAgK1ec7A9owrJo336 DH2Copzvz/MqeBjtDB8eKF9KqLP6BWH00InJdwRhGbOnoRjakPI3BpGVtYI/0xbRqXwx nZvXynNH5EaMxL+MZlD2yaUTbjfTwxGQDMLhtn0ZfaF27uVCxxyEvhSauXl7+wbGGDK5 L3rzMO58lZdF5+Q4ncHwjAICTS6BLhl+I3RMNWpldlpNfinCnbnkCBoy3fXSmDB6Z3g1 FQtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=kE8Hzeh9FYFuKZ/G19btpp2uodcRTcaVsAerPbdqFCE=; b=uAQH6lD2MAByOX0iRPPdffwiL1vYDKKOmLpjfFmStHmjIcbqoRW2DJJBdZWKI1eQq2 MEAAylZYq4+XQaJNBqM7ISUVal9vcywlsDCJVSTJCzskEVaUTbRmUYLSLVPmWv1tu2R7 H/JIcfRVjPPlTYSlr/YlMZvsfs0nRHmRkwQOuNW9QVA/yPBY9yacO/lSZ3OYkQWaoR5R nY0LucDl3MdBuA+6TaMOFSPlc8UENQfQN+by0l91RAO3TEtvAC/NuhNDt5zL3qO27LdV JUh5ilyO2LqCGWGUYWy5ClwoeIpP6AILswwUNasdbtPMZXArasPav02y68kTCAFuyZTV K+Ew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=H9T1W8aU; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v16si21131583jal.55.2021.08.25.07.06.05; Wed, 25 Aug 2021 07:06:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=H9T1W8aU; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240782AbhHYOFP (ORCPT + 99 others); Wed, 25 Aug 2021 10:05:15 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:44835 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239601AbhHYOFN (ORCPT ); Wed, 25 Aug 2021 10:05:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629900267; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kE8Hzeh9FYFuKZ/G19btpp2uodcRTcaVsAerPbdqFCE=; b=H9T1W8aU6dFiayAryoqAZouyz1/N+VBNPEaoexKdb8l8VET3xSNjigaXAmJh6mJSgu0Nm7 UasECGeJBAX8YYZ+NqZfjUd6C0tMJQIAfkZdtf9YcPWwh6KfLbM69z3Pfo18cd/mtZL3Kw 0Q6d/Zc2jPOcs6x7Xsx/NgsmEIRoyJ4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-174-ASdezzy4PASj34NJfVUMLw-1; Wed, 25 Aug 2021 10:04:25 -0400 X-MC-Unique: ASdezzy4PASj34NJfVUMLw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 28BC01853026; Wed, 25 Aug 2021 14:04:24 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.36]) by smtp.corp.redhat.com (Postfix) with ESMTP id DB6F72B3DF; Wed, 25 Aug 2021 14:04:09 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <3d98729b59c2afcad1299a7742211bcdf1598623.camel@redhat.com> References: <3d98729b59c2afcad1299a7742211bcdf1598623.camel@redhat.com> <162431188431.2908479.14031376932042135080.stgit@warthog.procyon.org.uk> <162431201844.2908479.8293647220901514696.stgit@warthog.procyon.org.uk> To: Jeff Layton Cc: dhowells@redhat.com, linux-cachefs@redhat.com, Anna Schumaker , Steve French , Dominique Martinet , David Wysochanski , linux-afs@lists.infradead.org, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs-developer@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 10/12] fscache: Fix cookie key hashing MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2030820.1629900248.1@warthog.procyon.org.uk> Date: Wed, 25 Aug 2021 15:04:08 +0100 Message-ID: <2030821.1629900248@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Jeff Layton wrote: > What happens when this patch encounters a cache that was built before > it? Do you need to couple this with some sort of global cache > invalidation or rehashing event? At the moment, nothing. cachefiles generates a second hash value, but doing so is a duplication of effort. David