Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
From:   "NeilBrown" <neilb@suse.de>
To:     "J.  Bruce Fields" <bfields@fieldses.org>
Cc:     "Chuck Lever" <chuck.lever@oracle.com>,
        "Christoph Hellwig" <hch@lst.de>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] NFSD: drop support for ancient file-handles
In-reply-to: <20210826145129.GA3616@fieldses.org>
References: <162995209561.7591.4202079352301963089@noble.neil.brown.name>,
 <20210826145129.GA3616@fieldses.org>
Date:   Fri, 27 Aug 2021 07:41:49 +1000
Message-id: <163001410955.7591.12537036452359700992@noble.neil.brown.name>
Precedence: bulk

On Fri, 27 Aug 2021, J.  Bruce Fields wrote:
> On Thu, Aug 26, 2021 at 02:28:15PM +1000, NeilBrown wrote:
> > 
> > File-handles not in the "new" or "version 1" format have not been handed
> > out for new mounts since Linux 2.4 which was released 20 years ago.
> > I think it is safe to say that no such file handles are still in use,
> > and that we can drop support for them.
> > 
> > This patch also moves the nfsfh.h from the include/uapi directory into
> > fs/nfsd.  I can find no evidence of it being used anywhere outside the
> > kernel.  Certainly nfs-utils and wireshark do not use it.
> > 
> > fh_base and fh_pad are occasionally used to refer to the whole
> > filehandle.  These are replaced with "fh_raw" which is hopefully more
> > meaningful.
> 
> Oh boy, I will not miss those (fh_version == 1) cases in nfsfh.c.
> Excellent.

:-)

> 
> Looks like it just needs the following folded in.

Don't know how I missed those - so happy to have reliable reviewers!

Thanks,
NeilBrown