Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Olga Kornievskaia <olga.kornievskaia@gmail.com>
CC:     Trond Myklebust <trond.myklebust@hammerspace.com>,
        Anna Schumaker <anna.schumaker@netapp.com>,
        "chuck.level@oracle.com" <chuck.level@oracle.com>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [RFC 2/2] xprtrdma: remove re_implicit_roundup
 xprt_rdma_pad_optimize
Thread-Topic: [RFC 2/2] xprtrdma: remove re_implicit_roundup
 xprt_rdma_pad_optimize
Thread-Index: AQHXnb+FY8E/qRgqzkSgV7IMA6ztN6uMRLYA
Date:   Mon, 30 Aug 2021 16:57:25 +0000
Message-ID: <958545E7-7758-460C-BE3C-451DEA96969B@oracle.com>
References: <20210830165302.60225-1-olga.kornievskaia@gmail.com>
 <20210830165302.60225-3-olga.kornievskaia@gmail.com>
In-Reply-To: <20210830165302.60225-3-olga.kornievskaia@gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yA7T5uRaBcyFxS3Gj0xPze2jmOJzMyrAa1QQpxY0v5BG9TZlzNeXzhSr0hMp?=
 =?us-ascii?Q?HmGn5DJcoQrjlE+PYFzAfDtdb0hHlbG33Y1ovzIdsxbxdGYVw0/3kB3YWl+8?=
 =?us-ascii?Q?7+84tGyGP6zOahwNJgVAHKVEAAxGUPEcvTs1qiPwm/WtkwOktA1ZCQgKRSdr?=
 =?us-ascii?Q?S9H1ox2wFlZNS487VSh6GvU0L8MZglDNNUdUDGsTOBZaR9MiSriVQt6zXkgS?=
 =?us-ascii?Q?C5viYAxC3f9DpbbZLgXu051z3cz9e7uzbN0sFvVk6D/ssmFXspDnqBn/Mgs6?=
 =?us-ascii?Q?G4Tgvn7iBdD2u7CBo4VbFtWdlfy/DjeBr9V619u55fCqdoJncNlyQOx/80R5?=
 =?us-ascii?Q?2UqPgxW4eHbfTRbahEpXyYK57WL8AAStAu5mroYUotZBXH9OW2owZBmYEhvC?=
 =?us-ascii?Q?WoM2DNonswwq441lBqGBb7ykPKwDe1Nu/gId7gL428edrY77V/cyJtSy4c8j?=
 =?us-ascii?Q?RMf3767AnTU96twuXxbmM0aPlp8TblBDDVlP1ryIQGnELpWhrf1g257m1ekb?=
 =?us-ascii?Q?TEvf82FpeUsiVRIotsgP3YUKJIyEFia0kirgg7smu2CgmznsTVYPD0nKWiEL?=
 =?us-ascii?Q?Yz01SvhtEfqZ+IVGOSBr9wghl6R5ImMZV+mIfFGmiAnWGFn9lRSPVKiehj9J?=
 =?us-ascii?Q?Dx64lwG9smnGjKzerZfanvr/IMogLnBVXLu8DBv7iAWJ94+RCyoKz1WeceFJ?=
 =?us-ascii?Q?HC+DgM3zYGfWSfEZ0GctkwaeEOrZ+dhTsZF/aIhsa1rzfHzTekHkhMTolnvE?=
 =?us-ascii?Q?lN3IWSHwTSmNKrVbMrDekFfwqVZajMA1g4zJmq4jFbXizCA+w0j0vEu8KeJw?=
 =?us-ascii?Q?jgnKRPrm0PLvobiDz0k6e1D0xG2mqYDqWnfzY7V0mK8z72umqMKWVicLwzzt?=
 =?us-ascii?Q?fP4Tvulcszi22VKJUPk/pJaP26sVVNj6iIWHqM3wJH7uIZ1WuACXh+qC/JiJ?=
 =?us-ascii?Q?Jf/zZxYB5v1yyJGiQhLcSjTlY7BR8AjC93mvYuhtMKxqtDXegOBVWnSQAZlY?=
 =?us-ascii?Q?ydpRI9khAD7XsmQjdRwLI2uYaJGoFJp/gPg/Ssne0qFrcEC/yxVzqq/3RFv7?=
 =?us-ascii?Q?oi4VTbcALJnfnFGfW8FadRLk28cP7SWDIUUMYwIdc2xqnsqHjQwSQfoaW3Kp?=
 =?us-ascii?Q?6Lc/BKhgKUF27IlbpG9eRLhoZgPfHPiK0N7FrzkBs/QnYZ/qzl9EhxEoo6oX?=
 =?us-ascii?Q?iuu2yiuYmf8UIosnoOWBF1xg5x4V5cPgSzNyEf/ZvBNgC4l5kLlm2EPJpnat?=
 =?us-ascii?Q?CPrVyx5sYMenmnIEKgZZ/+jS8Y1fmcH8sOQ89jyMjaftoOCrrrlkTbSyNoMW?=
 =?us-ascii?Q?NPD4F2yIJcJvLedQASqW1xN3?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <74A18A6A4D698B47A66AFDEB77ECA360@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4688.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: adc1f969-559f-40bb-9f01-08d96bd73e6a
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Aug 2021 16:57:25.7457
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: GJT+p/TfAfENX/85rtRaTM1NZHYsa0vW5o6eOZWTA/EptLLSwt68c0PI4C+NqsG/RvU4pfIrWBZ9tjxfe479lg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5406
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10092 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0
 phishscore=0 mlxscore=0 malwarescore=0 mlxlogscore=999 bulkscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2107140000 definitions=main-2108300116
X-Proofpoint-ORIG-GUID: dRSh7HOEv1gryhlQLKgAwvXTYgTM_ZPC
X-Proofpoint-GUID: dRSh7HOEv1gryhlQLKgAwvXTYgTM_ZPC
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Aug 30, 2021, at 12:53 PM, Olga Kornievskaia <olga.kornievskaia@gmail.=
com> wrote:
>=20
> From: Olga Kornievskaia <kolga@netapp.com>
>=20
> Since RPC over RDMA layer no longer needs to manage XDR padding,
> remove existing code that managed whether or not client included
> extra space for the XDR padding.
>=20
> Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
> ---
> net/sunrpc/xprtrdma/transport.c | 8 --------
> net/sunrpc/xprtrdma/verbs.c     | 2 --
> net/sunrpc/xprtrdma/xprt_rdma.h | 6 ------
> 3 files changed, 16 deletions(-)
>=20
> diff --git a/net/sunrpc/xprtrdma/transport.c b/net/sunrpc/xprtrdma/transp=
ort.c
> index 16e5696314a4..e7b9d88f4483 100644
> --- a/net/sunrpc/xprtrdma/transport.c
> +++ b/net/sunrpc/xprtrdma/transport.c
> @@ -72,7 +72,6 @@ static unsigned int xprt_rdma_slot_table_entries =3D RP=
CRDMA_DEF_SLOT_TABLE;
> unsigned int xprt_rdma_max_inline_read =3D RPCRDMA_DEF_INLINE;
> unsigned int xprt_rdma_max_inline_write =3D RPCRDMA_DEF_INLINE;
> unsigned int xprt_rdma_memreg_strategy		=3D RPCRDMA_FRWR;
> -int xprt_rdma_pad_optimize;
> static struct xprt_class xprt_rdma;
>=20
> #if IS_ENABLED(CONFIG_SUNRPC_DEBUG)
> @@ -134,13 +133,6 @@ static struct ctl_table xr_tunables_table[] =3D {
> 		.extra1		=3D &min_memreg,
> 		.extra2		=3D &max_memreg,
> 	},
> -	{
> -		.procname	=3D "rdma_pad_optimize",
> -		.data		=3D &xprt_rdma_pad_optimize,
> -		.maxlen		=3D sizeof(unsigned int),
> -		.mode		=3D 0644,
> -		.proc_handler	=3D proc_dointvec,
> -	},
> 	{ },
> };

I have to NACK at least this hunk: my understanding is we
can't just remove /proc interfaces.


> diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c
> index aaec3c9be8db..d8650a3563ef 100644
> --- a/net/sunrpc/xprtrdma/verbs.c
> +++ b/net/sunrpc/xprtrdma/verbs.c
> @@ -205,14 +205,12 @@ static void rpcrdma_update_cm_private(struct rpcrdm=
a_ep *ep,
> 	unsigned int rsize, wsize;
>=20
> 	/* Default settings for RPC-over-RDMA Version One */
> -	ep->re_implicit_roundup =3D xprt_rdma_pad_optimize;
> 	rsize =3D RPCRDMA_V1_DEF_INLINE_SIZE;
> 	wsize =3D RPCRDMA_V1_DEF_INLINE_SIZE;
>=20
> 	if (pmsg &&
> 	    pmsg->cp_magic =3D=3D rpcrdma_cmp_magic &&
> 	    pmsg->cp_version =3D=3D RPCRDMA_CMP_VERSION) {
> -		ep->re_implicit_roundup =3D true;
> 		rsize =3D rpcrdma_decode_buffer_size(pmsg->cp_send_size);
> 		wsize =3D rpcrdma_decode_buffer_size(pmsg->cp_recv_size);
> 	}
> diff --git a/net/sunrpc/xprtrdma/xprt_rdma.h b/net/sunrpc/xprtrdma/xprt_r=
dma.h
> index d91f54eae00b..137866a83a3a 100644
> --- a/net/sunrpc/xprtrdma/xprt_rdma.h
> +++ b/net/sunrpc/xprtrdma/xprt_rdma.h
> @@ -74,7 +74,6 @@ struct rpcrdma_ep {
> 	struct ib_pd		*re_pd;
> 	unsigned int		re_max_rdma_segs;
> 	unsigned int		re_max_fr_depth;
> -	bool			re_implicit_roundup;
> 	enum ib_mr_type		re_mrtype;
> 	struct completion	re_done;
> 	unsigned int		re_send_count;
> @@ -441,11 +440,6 @@ rpcrdma_portstr(const struct rpcrdma_xprt *r_xprt)
> 	return r_xprt->rx_xprt.address_strings[RPC_DISPLAY_PORT];
> }
>=20
> -/* Setting this to 0 ensures interoperability with early servers.
> - * Setting this to 1 enhances certain unaligned read/write performance.
> - * Default is 0, see sysctl entry and rpc_rdma.c rpcrdma_convert_iovs() =
*/
> -extern int xprt_rdma_pad_optimize;
> -
> /* This setting controls the hunt for a supported memory
>  * registration strategy.
>  */
> --=20
> 2.27.0
>=20

--
Chuck Lever