Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp384765pxb; Wed, 1 Sep 2021 00:45:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz6G6O+lP2MjYsOjWzYxmsvdhCk/fmwe8tfITvtdifddpGm6ET7mA3oiNm9NCF1wiHEyyvf X-Received: by 2002:a02:860d:: with SMTP id e13mr6803993jai.12.1630482358090; Wed, 01 Sep 2021 00:45:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630482358; cv=none; d=google.com; s=arc-20160816; b=aFHqKLVhBGlIGcyT2OLgF9sMaQOKic/0tFkvFKQRtbD6qPyC8D9nNZhyP+ULS4nGDz AGYD8J3QJUobARgynkVFe59cxgpnv6oou3KrCHDKh+A7s8sXvWLW3cEjufW2AalC32Lm WOZozGRdNiTItcDTJFqwjhYfN29gimNCKPXFM0H2nxaFjOZTgwygHT4hysI0RQYHDajw nYidFxPFahrKYTZlf9lgbeCXdhqjfLZrU+IAJOdzqDElBdXQQKeVlrvuPn881g6xmDOC tZ7JXmrO67bYqjeNkL5wXEMv8c8t5Sp8Erdd6rdIt/fHjLhGcw7ORgUdwNYtl2oVZafb DmBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=XG4vlOBeUjwnyrBgDG1p23e2vO5mILDHFTr1lBz5U5U=; b=oZVpz1OJnP2jO+Kdxoy75+8bsCXRcLhn5iAQUYFoKkYWQv8+pstTd42kDsVZtq1xAV U1Ue2R8HdQbHag18HGXJ/MW+tZMW+cJqc4E15fqnl3R8CuuMkcmh8Sa7qJVZ5Cvc60tA XMhWZBMJj0S3QrjhB6PYuiEn9cEKfAYh9UmEBZcEtnBUXV+Lj3t2u6HiP34semNuPXAj u3mYj8ccv+UlqMFLu+VhXEqEEU2LvyGa6DE1ddHnGZG78bdZ3KQLDRfT7iXfJecHg4/l VIZygRGv5FSfgwV/GYtBbp4O1FbUc8ruVt5cFCsGehtU80uiV25IXlrSoqVKjEZAODRR 7HNQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q9si7077422ile.120.2021.09.01.00.45.24; Wed, 01 Sep 2021 00:45:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242649AbhIAHpI (ORCPT + 99 others); Wed, 1 Sep 2021 03:45:08 -0400 Received: from verein.lst.de ([213.95.11.211]:46575 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242765AbhIAHpF (ORCPT ); Wed, 1 Sep 2021 03:45:05 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 9FC1F68AFE; Wed, 1 Sep 2021 09:44:07 +0200 (CEST) Date: Wed, 1 Sep 2021 09:44:07 +0200 From: Christoph Hellwig To: NeilBrown Cc: "J. Bruce Fields" , Chuck Lever , Christoph Hellwig , linux-nfs@vger.kernel.org Subject: Re: [PATCH 1/2 v2] NFSD: drop support for ancient filehandles Message-ID: <20210901074407.GB18673@lst.de> References: <20210827151505.GA19199@lst.de> <163038488360.7591.7865010833762169362@noble.neil.brown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <163038488360.7591.7865010833762169362@noble.neil.brown.name> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org The content looks fine, but I still think moving the definition out of the uapi and removing the ancient file handles are different things that should be separate patches with separate commit logs explaining the story.