Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] gssd: fix crash in debug message.
To:     NeilBrown <neilb@suse.de>
Cc:     Linux NFS Mailing list <linux-nfs@vger.kernel.org>
References: <20210610150825.396565-1-steved@redhat.com>
 <627209c3-21dd-312e-c2dc-cc810108f7d1@redhat.com>
 <163116618506.12570.5744024691858636230@noble.neil.brown.name>
From:   Steve Dickson <steved@redhat.com>
Message-ID: <c4aeddc9-f2c1-d5dd-dc51-0db72f460ed9@redhat.com>
Date:   Thu, 23 Sep 2021 12:34:20 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <163116618506.12570.5744024691858636230@noble.neil.brown.name>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 9/9/21 1:43 AM, NeilBrown wrote:
> 
> A recent cleanup of debug messages added func and tid format specifiers
> to a debug message (when full hostname was different), but the func name
> and tid were NOT added as arguments.
> 
> Consequently there weren't enough args, random bytes of the stack were
> interpreted as a pointer, and rpc.gssd crashed (when -v was specified).
> 
> Fixes: b538862a5135 ("gssd: Cleaned up debug messages")
> Signed-off-by: NeilBrown <neilb@suse.de>
Committed... (tag: nfs-utils-2-5-5-rc3)

Thanks for the clean up!!

steved.
> ---
>   utils/gssd/krb5_util.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/utils/gssd/krb5_util.c b/utils/gssd/krb5_util.c
> index 6d059f332881..e3f270e948ac 100644
> --- a/utils/gssd/krb5_util.c
> +++ b/utils/gssd/krb5_util.c
> @@ -673,8 +673,8 @@ get_full_hostname(const char *inhost, char *outhost, int outhostlen)
>   	    *c = tolower(*c);
>   
>   	if (get_verbosity() && strcmp(inhost, outhost))
> -		printerr(1, "%s(0x%0lx): inhost '%s' different than outhost'%s'\n",
> -			inhost, outhost);
> +		printerr(1, "%s(0x%0lx): inhost '%s' different than outhost '%s'\n",
> +			 __func__, tid, inhost, outhost);
>   
>   	retval = 0;
>   out:
>