Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/1] mountstats: division by zero error on new mount when
 0==rpcsends
To:     Stig <thatsafunnyname@gmail.com>, linux-nfs@vger.kernel.org
References: <CAD9POpJSfbBYVgupAFxie_N6g2BQAUZ-qWV=tZFMHMJMmdqoYw@mail.gmail.com>
From:   Steve Dickson <steved@redhat.com>
Message-ID: <52652487-e2c5-a7b9-ec87-5a184a48c1ab@redhat.com>
Date:   Thu, 23 Sep 2021 12:39:24 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <CAD9POpJSfbBYVgupAFxie_N6g2BQAUZ-qWV=tZFMHMJMmdqoYw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 9/22/21 11:44 AM, Stig wrote:
> For https://bugzilla.linux-nfs.org/show_bug.cgi?id=367
> 
> When rpcsends is 0 this is the error seen when mounstats is run on a
> NFSv4.2 mount:
> 
>> sudo umount /fsx ; sudo mount /fsx ; mountstats /fsx
Committed... (tag: nfs-utils-2-5-5-rc3)

On future patches please use the proper 'Signed-off-by:' tag.

steved.

> ...
> RPC statistics:
>    0 RPC requests sent, 0 RPC replies received (0 XIDs not found)
> 
> SERVER_CAPS:
> Traceback (most recent call last):
>    File "mountstats.py.orig", line 1134, in <module>
>      res = main()
>    File "mountstats.py.orig", line 1123, in main
>      return args.func(args)
>    File "mountstats.py.orig", line 863, in mountstats_command
>      print_mountstats(stats, args.nfs_only, args.rpc_only, args.raw,
> args.xprt_only)
>    File "mountstats.py.orig", line 825, in print_mountstats
>      stats.display_rpc_op_stats()
>    File "mountstats.py.orig", line 486, in display_rpc_op_stats
>      (count, ((count * 100) / sends)), end=' ')
> ZeroDivisionError: division by zero
> 
> Fixed with:
> 
> diff --git a/tools/mountstats/mountstats.py b/tools/mountstats/mountstats.py
> index 23876fc..8e129c8 100755
> --- a/tools/mountstats/mountstats.py
> +++ b/tools/mountstats/mountstats.py
> @@ -482,8 +482,11 @@ class DeviceData:
>               count = stats[1]
>               if count != 0:
>                   print('%s:' % stats[0])
> +                ops_pcnt = 0
> +                if sends != 0:
> +                    ops_pcnt = (count * 100) / sends
>                   print('\t%d ops (%d%%)' % \
> -                    (count, ((count * 100) / sends)), end=' ')
> +                    (count, ops_pcnt), end=' ')
>                   retrans = stats[2] - count
>                   if retrans != 0:
>                       print('\t%d retrans (%d%%)' % (retrans, ((retrans
> * 100) / count)), end=' ')
>