Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp380280pxb; Thu, 30 Sep 2021 08:02:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwg0xfb1fcwXoSbwUyimkvG2w3v1UQoMPYS7xpoYXw/VPVcfCcH7OrIHv2qNzREHW5AaJG6 X-Received: by 2002:a63:e64a:: with SMTP id p10mr5418771pgj.263.1633014171289; Thu, 30 Sep 2021 08:02:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633014171; cv=none; d=google.com; s=arc-20160816; b=yT8Nh634lH9yNW6q5oP7qoK0XTe0+EDEb6PXG/Jft2/e7tIf0049tI+/P776IKE0sh tInXmnHFjvhJNUI0ZCk8YSB6hGsJx0NUBwDdbFx7DypzfeZ+m+A2NX65fVzi0TvAtKUR KwFbW7fVa4YzoBV0lSqjreZMr3TplS7X9PTMqFO5yPJ2bWFUCtsAlF9IOpmLaAzgUHFz MGj9GnUYpPVWcvr5Lba1xUYmVYGUSVHzlv04dlG24LAvvh3uvg+GMXP/sXu6K8z5k1DT RDUnvsUgLSIH3r1+nnttXEjzZCp/d5SoyEX/ioGzE6Zp4PXEVOmAYypncC61bZx/4yUm 3hUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=A09nBnh3+znqPTmyctOPsBC8fydwsZHVz2bjxrS6BRg=; b=DqA9cq8xPdCOIdWYhJ6+Bghq8XrJVq+N6ne2vBLPAMgrNzF3tNhkLWIM19WVfk3aV9 /5bxjgJa/fMwKti7MDhBm4feSPOmhcee+oMO/eweo6h+qqJtZ/1mHscn31O+DH8SbY+A gjAuBvGbqvq8NUVhHf17wfeHUQA/m67QD1b+46ed7OFPg9pYsH3ZroejtZPrHjHw6gCW RtF05V0t937aDn9bfQhtbUx7IdE6A6QUeosDkKFLDVVcBnPBTgO3tGtDMQjb5KOPsMf4 B+4qXGAYX0FXJQouqhoCbNBB3mJsMhjFzKsccmMuT3JGP5jJOJsiFv2w6C6PecdndvYV izQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Z460mong; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ij19si4669112plb.145.2021.09.30.08.02.21; Thu, 30 Sep 2021 08:02:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Z460mong; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349724AbhI3Obw (ORCPT + 99 others); Thu, 30 Sep 2021 10:31:52 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:47264 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348126AbhI3Obu (ORCPT ); Thu, 30 Sep 2021 10:31:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633012207; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=A09nBnh3+znqPTmyctOPsBC8fydwsZHVz2bjxrS6BRg=; b=Z460mongC9/NRYQPSD0687ALRmyjPInYaThZilibZdORqagpAxxDBcRsw+ZXY0FBuoZurf dGbqQKXWggWhaqwls5gG3iBG/Dre5Oo/GC1B0T0CJFr6Ei2iN++mJddMvsCvJoBtqh1QEN ohl+F0LOyRJ8FLDi1LNmR8fp0AM5kiE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-382-TJlGUIyeMpaBMoTMQvWhSA-1; Thu, 30 Sep 2021 10:30:01 -0400 X-MC-Unique: TJlGUIyeMpaBMoTMQvWhSA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6146E804148; Thu, 30 Sep 2021 14:29:26 +0000 (UTC) Received: from [10.10.66.66] (ovpn-66-66.rdu2.redhat.com [10.10.66.66]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0792F5C1A1; Thu, 30 Sep 2021 14:29:25 +0000 (UTC) From: "Benjamin Coddington" To: "Trond Myklebust" Cc: linux-nfs@vger.kernel.org Subject: Re: [PATCH 4/5] NFS: Further optimisations for 'ls -l' Date: Thu, 30 Sep 2021 10:29:23 -0400 Message-ID: <46C79084-3586-4B63-A55F-7A3B9ED547CE@redhat.com> In-Reply-To: <558be6c89090b38cc9b679a0893649c5067cff14.camel@hammerspace.com> References: <20210929134944.632844-1-trondmy@kernel.org> <20210929134944.632844-2-trondmy@kernel.org> <20210929134944.632844-3-trondmy@kernel.org> <20210929134944.632844-4-trondmy@kernel.org> <558be6c89090b38cc9b679a0893649c5067cff14.camel@hammerspace.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On 29 Sep 2021, at 16:35, Trond Myklebust wrote: > It is concerning, and indeed in our test we are seeing READDIR > amplification with these multiple process accesses. So scenarios like > the one you describe above are exactly the kind of issue I was looking > to fix with these patches. I spent some time trying to trigger the scenario I was concerned about, but I couldn't generate any op amplifications. Feel free to add my: Tested-by: Benjamin Coddington Reviewed-by: Benjamin Coddington for the series. Ben