Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp2331683pxb; Sat, 2 Oct 2021 13:45:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx1R1TNoOTvB5i1jsSbF+f/EMNJpn5ZVPIUaKmxyyt5dRJBoysTZJU/5yhoJfVkLxUdVD70 X-Received: by 2002:a17:907:6297:: with SMTP id nd23mr6464308ejc.62.1633207540276; Sat, 02 Oct 2021 13:45:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633207540; cv=none; d=google.com; s=arc-20160816; b=J1leJI/opJypaB2HKzqUcHJHiCh3KPmbxOfvtiOvdflfQsAf4sRJjDVBFEvyXIa/Tq wKFa78ok0INTZWH083RPWzXtNjWxaMTMVsUzGu0WE58rLaXOyX/rq/Q6GtVYjYV7h34s vutScVSGC55BM2CTHUc+m35j+Yp9+BGkWUBvQHM+50AhJWv3PKZy0rpDXJoNOrU1D8HJ ItTD3iS2VM90qymLmQI/TO1ZkIPZLLQAEX9XNwJQgcgfqWQ8BaSA0lPwCIo40LL9uaf0 sTjy0Xn+WpIz7uVNdvlxs01UUNYbNfCMk4SPEIo8/NabmaivGIZyU+z+1tA+KJZeknGf 4OJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature:dkim-filter; bh=178vheGxjIIKhJmjBZVo6FcDzuG0gUZPSktLqWVbKu4=; b=wFqEcDkT8NqxKMh6JkHRmY2C4Rdv5kM9dPL0wl3tEmipYjTnz64ByHIYdASKy5BMiL 2tL0ypVxK60AAIkaJp6EYnV11RpTYeXu9+pA+lejr/h/E9lGFDj/loSX8mI9m1BYDv7r KWZbLqwsQOWTx/iXsx4jOi4rdT/EUPe3KBOiiue3DoD/c3cvBkUAcHXXEGa2oNMW+XpL pKC54Iap4KT1wgaX0YGzQEWcmD5zlWPUSHl1cjVVM3k0y0Ij7hCvqyiAgb3HQfyXeE6m oD++k8Uc9dnz4qvhVv94IykIm7KTsd8D4YA0QPgJPnLRUMrRKuUSRKCh+biJ1EqBxjDP 8grQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@fieldses.org header.s=default header.b=i0ZRjoQm; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z7si11368825edr.15.2021.10.02.13.45.16; Sat, 02 Oct 2021 13:45:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@fieldses.org header.s=default header.b=i0ZRjoQm; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233967AbhJBUkd (ORCPT + 99 others); Sat, 2 Oct 2021 16:40:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229503AbhJBUkd (ORCPT ); Sat, 2 Oct 2021 16:40:33 -0400 Received: from fieldses.org (fieldses.org [IPv6:2600:3c00:e000:2f7::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 110CEC061714 for ; Sat, 2 Oct 2021 13:38:47 -0700 (PDT) Received: by fieldses.org (Postfix, from userid 2815) id AE1BC7048; Sat, 2 Oct 2021 16:38:46 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.11.0 fieldses.org AE1BC7048 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fieldses.org; s=default; t=1633207126; bh=178vheGxjIIKhJmjBZVo6FcDzuG0gUZPSktLqWVbKu4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=i0ZRjoQmW2NJeeRSKg67vdgcT3Au3/73Pud2ayYxzy2XA19XzHRJy/830HayuEZU1 ByWh+oVMYKiYO+oitd/eYuPa8VOlS9KAVpc2koCa0C+f3i0d5eRJzeXRTrpPPg+eYK ZRPHrDwkH62Uy1LlShbQAARZcsglunrudNnkcBhY= Date: Sat, 2 Oct 2021 16:38:46 -0400 From: "J. Bruce Fields" To: Chuck Lever Cc: linux-nfs@vger.kernel.org Subject: Re: [PATCH v1 0/2] NFSD: Clean ups for recent XDR work Message-ID: <20211002203846.GD26608@fieldses.org> References: <163303585936.5125.6042907247616993649.stgit@klimt.1015granger.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <163303585936.5125.6042907247616993649.stgit@klimt.1015granger.net> User-Agent: Mutt/1.5.21 (2010-09-15) Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Thu, Sep 30, 2021 at 05:06:09PM -0400, Chuck Lever wrote: > As we discussed, here are a couple of minor improvements for the > xdr_stream_subsegment() API added when the NFSv4 XDR functions were > recently overhauled. Notably, the second patch changes the NFSv2 and > NFSv3 decoders to work like the NFSv4 one. Looks good to me; applying. --b. > > --- > > Chuck Lever (2): > SUNRPC: xdr_stream_subsegment() must handle non-zero page_bases > NFSD: Have legacy NFSD WRITE decoders use xdr_stream_subsegment() > > > fs/nfsd/nfs3proc.c | 3 +-- > fs/nfsd/nfs3xdr.c | 12 ++---------- > fs/nfsd/nfs4proc.c | 3 +-- > fs/nfsd/nfsproc.c | 3 +-- > fs/nfsd/nfsxdr.c | 9 +-------- > fs/nfsd/xdr.h | 2 +- > fs/nfsd/xdr3.h | 2 +- > include/linux/sunrpc/svc.h | 3 +-- > net/sunrpc/svc.c | 11 ++++++----- > net/sunrpc/xdr.c | 32 +++++++++++++++++--------------- > 10 files changed, 32 insertions(+), 48 deletions(-) > > -- > Chuck Lever