Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp3818069pxb; Mon, 4 Oct 2021 10:14:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwUaoZnPBneS/YGXVK7f0nwdvpnmE9xYDN7TbAXpAbaExB1xwh4HkmawnofS7PYstBeVlLx X-Received: by 2002:a17:906:6a21:: with SMTP id qw33mr19637685ejc.326.1633367668142; Mon, 04 Oct 2021 10:14:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633367668; cv=none; d=google.com; s=arc-20160816; b=fh+QRV1mYl9B+QhtQflwh135i3Lbk8FLhO2j9wupTjNDPc5D+2ghcPHi6kzluQFzic eefZCNUaj5xf1ScTjjom714OID6eZtUiREZFpuQbDYkr6kAiN3jQKoq7LhULWr4EI1su qKdpKzjoQ3l6L3ucuJt8rOAx1SkNMmHbvIngwRiGs2MM3+nWAjBcZS0YxXCXbAe1RK2B OaBntHZUVEOtzcAexPXJ8PB5RUwtZSJLjJ/nmt/DZMtbtTMpnLGsZYMRPUWTdMvanqZX 7LkAc56ij7BUGT/6MhYLkIlRDCaTpJeMnk087AiaD3wOO74p7FcPH2Xn1Gu6AbxDXDAw JO+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:cc:to:from :subject; bh=06t0+YQ6FnxDp4cts7tZJmdI3bEknw9Y/MgxvpCtlIc=; b=dl2662Vlyq6TWaYeHwzB++ZtqVnEpf1LZuU4euGKKd+TMURdLo/mAV4U+EvOpceQL4 2GgchD9wKKC8Ltrpuh9fj79c0AQXjVVrPyJKEwqhmYGVEVCtK53vYTPIHUnVbV7e672g HEFVEGHfeWeV+72fNvb3V877FE8KKokAOYE6CmH06R1y2VPq0RnQCbQh0D935JN5sKSb C5hDoSyw1XIEm+rISdT03mj9y45aPnFfaOlIxZzZhx80TRpmIMPMl+3MSpvwyLhj+7K6 djDAFX12yKkQxjy6CLuwsQLA/gMmyyX/LuCZHf0UwZFgQ6RfsPeqAUwTotziqiinC4T/ fvaQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dd16si11399823edb.501.2021.10.04.10.14.02; Mon, 04 Oct 2021 10:14:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233529AbhJDOS1 (ORCPT + 99 others); Mon, 4 Oct 2021 10:18:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:47634 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233945AbhJDOSW (ORCPT ); Mon, 4 Oct 2021 10:18:22 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4741D611C1; Mon, 4 Oct 2021 14:16:33 +0000 (UTC) Subject: [PATCH 5/5] SUNRPC: Capture value of xdr_buf::page_base From: Chuck Lever To: bfields@fieldses.org Cc: linux-nfs@vger.kernel.org, linux-rdma@vger.kernel.org Date: Mon, 04 Oct 2021 10:16:32 -0400 Message-ID: <163335699259.3921.516265778231814195.stgit@klimt.1015granger.net> In-Reply-To: <163335690747.3921.13072315880207206379.stgit@klimt.1015granger.net> References: <163335690747.3921.13072315880207206379.stgit@klimt.1015granger.net> User-Agent: StGit/1.3 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org This value is usually zero, but will be non-zero more often in the future. Knowing its value can be important diagnostic information. Signed-off-by: Chuck Lever --- include/trace/events/sunrpc.h | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/include/trace/events/sunrpc.h b/include/trace/events/sunrpc.h index fb016308c185..9ea59959a2fe 100644 --- a/include/trace/events/sunrpc.h +++ b/include/trace/events/sunrpc.h @@ -62,6 +62,7 @@ DECLARE_EVENT_CLASS(rpc_xdr_buf_class, __field(size_t, head_len) __field(const void *, tail_base) __field(size_t, tail_len) + __field(unsigned int, page_base) __field(unsigned int, page_len) __field(unsigned int, msg_len) ), @@ -74,14 +75,17 @@ DECLARE_EVENT_CLASS(rpc_xdr_buf_class, __entry->head_len = xdr->head[0].iov_len; __entry->tail_base = xdr->tail[0].iov_base; __entry->tail_len = xdr->tail[0].iov_len; + __entry->page_base = xdr->page_base; __entry->page_len = xdr->page_len; __entry->msg_len = xdr->len; ), - TP_printk("task:%u@%u head=[%p,%zu] page=%u tail=[%p,%zu] len=%u", + TP_printk("task:%u@%u head=[%p,%zu] page=%u(%u) tail=[%p,%zu] len=%u", __entry->task_id, __entry->client_id, - __entry->head_base, __entry->head_len, __entry->page_len, - __entry->tail_base, __entry->tail_len, __entry->msg_len + __entry->head_base, __entry->head_len, + __entry->page_len, __entry->page_base, + __entry->tail_base, __entry->tail_len, + __entry->msg_len ) ); @@ -1496,6 +1500,7 @@ DECLARE_EVENT_CLASS(svc_xdr_buf_class, __field(size_t, head_len) __field(const void *, tail_base) __field(size_t, tail_len) + __field(unsigned int, page_base) __field(unsigned int, page_len) __field(unsigned int, msg_len) ), @@ -1506,14 +1511,17 @@ DECLARE_EVENT_CLASS(svc_xdr_buf_class, __entry->head_len = xdr->head[0].iov_len; __entry->tail_base = xdr->tail[0].iov_base; __entry->tail_len = xdr->tail[0].iov_len; + __entry->page_base = xdr->page_base; __entry->page_len = xdr->page_len; __entry->msg_len = xdr->len; ), - TP_printk("xid=0x%08x head=[%p,%zu] page=%u tail=[%p,%zu] len=%u", + TP_printk("xid=0x%08x head=[%p,%zu] page=%u(%u) tail=[%p,%zu] len=%u", __entry->xid, - __entry->head_base, __entry->head_len, __entry->page_len, - __entry->tail_base, __entry->tail_len, __entry->msg_len + __entry->head_base, __entry->head_len, + __entry->page_len, __entry->page_base, + __entry->tail_base, __entry->tail_len, + __entry->msg_len ) );