Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Trond Myklebust <trondmy@hammerspace.com>
CC:     Anna Schumaker <anna.schumaker@netapp.com>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 2/4] SUNRPC: Tracepoints should store tk_pid and cl_clid
 as a signed int
Thread-Topic: [PATCH 2/4] SUNRPC: Tracepoints should store tk_pid and cl_clid
 as a signed int
Thread-Index: AQHXuSmMxjFddCeKFUeHXkK0NyQQBavC+icAgAAFKIA=
Date:   Mon, 4 Oct 2021 15:59:32 +0000
Message-ID: <8777E390-8C00-413A-969B-5BBC454CBF2D@oracle.com>
References: <163335628674.1225.6965764965914263799.stgit@morisot.1015granger.net>
 <163335660381.1225.8730120749232774829.stgit@morisot.1015granger.net>
 <ce1a2ef5757fc96c21f2e6402021ca646dfbfa80.camel@hammerspace.com>
In-Reply-To: <ce1a2ef5757fc96c21f2e6402021ca646dfbfa80.camel@hammerspace.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?J/O7vZFqrwLFQVchaVjG71/DPZpqTBCIImFMpxUvypwW1WPAJNUSgXdjKN9/?=
 =?us-ascii?Q?iV9SvDjB07Mp59DeoJQMkm35Dr+bJo9EUafrnf4quwSgP8kubdZ/3za3U0lR?=
 =?us-ascii?Q?i/3NOPGHysUqvUVxWgdmAcFBj6CyKJ1YBqxMnTAGI9qrTsW9GuZO8rICKb/E?=
 =?us-ascii?Q?zCvwiWYU07KqoUY225tXvHiN9LkQ3xTTixAGHFMQqIFnyJgUnz5jRkU/N5do?=
 =?us-ascii?Q?vTVTl7o64NhCCz/gq3ogYSPJ4WTGBnyKU/wOCPeMBEdZRXqo9F21t35WJJ4S?=
 =?us-ascii?Q?MWlfXV1Le57LfbQthHmai/sTLE70FS9U2K+y8jfIC/n7vNcmTix2JYRlSNIh?=
 =?us-ascii?Q?tIFam2OTTriH0jLSOP672rwbjUTQ9vGD+Cn19FmZf8jdtwca0qb760U33i+0?=
 =?us-ascii?Q?eZiMerDSMk3Yu2Bp9CBr0GHHn12UNeS6M/kccCfPi8wAeP8mO0X/oEnTSPOp?=
 =?us-ascii?Q?xbQorlccnALWXWscs3ZYMf97bhY4ZnEIWGLsENAwO646RwhxGz+EwlilYx7W?=
 =?us-ascii?Q?kBFpwcVjrHN9f3+S8AdbrN0UqJmuT3ana9+Z2tU+0kgwAptt+VVzuww4j5LR?=
 =?us-ascii?Q?yRUE/NLmoKYFv4oRKMg5tXIHMl+ZBHwxtLzzjU6CbP/MI47Fz9XvUIhR6Ec4?=
 =?us-ascii?Q?FM5nDhkG7OHDPFcN3DVB5V5mrc2c++aZ+SAZQaouKyxWkn8K6uzjCP7+Ilxs?=
 =?us-ascii?Q?i7vTTWJTDZFTlzMDWMvrr1WGWmb8pXnTcjSnEa+FZQS1OIVp5eA1pbVzp4x0?=
 =?us-ascii?Q?KE5nllqFCaqQ7tBdIhkpmm70D3SoHvodqrKCEGcJIiAekUnwjKTfft4kgcGN?=
 =?us-ascii?Q?W4G5yoh6anSkckquBK+ZvzPRNdNOBmD/PjeH5F4HE7Zj+P/xQFBC/nxKLJnI?=
 =?us-ascii?Q?bZwWouTQUy5Rn4Ku+lW3uLT5//m0p8vMNQlf7lHNFYLFwRoyAXMkFyWrIYXH?=
 =?us-ascii?Q?f9JcKsdEsLJeNTzK7wr+JDO4tQ9NDNhSnn3ichGLAGr0XfO1DhHLTafReG0/?=
 =?us-ascii?Q?PXumg6VOiZAcka99YdBPvEJbNXhFaNLvSeqBftHQE/4aqVdoMJxmdKbQ4UUS?=
 =?us-ascii?Q?5a9RTQJezQzdDFMZFpvjnacURDA0Y24xuNhwhcYZlH9H1OP0urD3XKj0rda6?=
 =?us-ascii?Q?5JTqUoJTBTIIdYDR+cAM8uazqAwbjWImRXhDcA9+lCQF53w2jCOgjfOksUDU?=
 =?us-ascii?Q?+xkiA7zz5HiNgWAFHxXuy7x73Ba33tyjPoRK9WdfoI4+ETfmlCCGhjidnICE?=
 =?us-ascii?Q?Q80bnI4cgUgSX5eHZHOWO4VdcuuGZjZxNHzycoyiJD8Se2dvClNMrk70Bx05?=
 =?us-ascii?Q?pMoSpMz3uO7rn4Iw87CH4uuV?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2A0C6BE47533804BBBA00432E499E646@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4688.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a809059e-6a88-439a-d98b-08d9874ff486
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Oct 2021 15:59:32.3513
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: AGZC4ODh8hLBmpdHSLO2b9uXMiYvHtyTdvPYwThYY2X8dsJs97BDbxn5oldcNYMBRKYrL4paFngE1qq2xpP7gA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4212
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10127 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0
 phishscore=0 malwarescore=0 bulkscore=0 mlxlogscore=999 mlxscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110040109
X-Proofpoint-ORIG-GUID: 4VNlpErCpFJA58fefepcvRQNgAF-ZyYy
X-Proofpoint-GUID: 4VNlpErCpFJA58fefepcvRQNgAF-ZyYy
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Oct 4, 2021, at 11:41 AM, Trond Myklebust <trondmy@hammerspace.com> wr=
ote:
>=20
> On Mon, 2021-10-04 at 10:10 -0400, Chuck Lever wrote:
>> ida_simple_get() returns a signed integer. Negative values are error
>> returns, but this suggests the range of valid client IDs is zero to
>> 2^31 - 1.
>>=20
>> tk_pid is currently an unsigned short, so its range is zero to
>> 65535.
>>=20
>> For certain special cases, RPC-related tracepoints record a -1 as
>> the task ID or the client ID. It's ugly for a trace event to display
>> 4 billion in these cases.
>=20
> Ugh... I emphatically do not like the idea of an identifier field that
> is signed, whatever its range of validity may be.
>=20
> If we're going to change anything, then let's rather turn that
> identifier into a fixed size hex field in the traces.

A fixed-size field might be more legible for eyeballing large
complex traces, so I can do that.

Thanks for having a look!


--
Chuck Lever