Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 5 Oct 2021 11:22:24 -0400
From:   "J. Bruce Fields" <bfields@fieldses.org>
To:     Dai Ngo <dai.ngo@oracle.com>
Cc:     linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/1] st_courtesy.py: add more tests for Courteous Server
Message-ID: <20211005152224.GA23210@fieldses.org>
References: <20211004225320.25368-1-dai.ngo@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211004225320.25368-1-dai.ngo@oracle.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Precedence: bulk

On Mon, Oct 04, 2021 at 06:53:20PM -0400, Dai Ngo wrote:
> COUR3: Test OPEN file with OPEN4_SHARE_DENY_WRITE
> COUR4: Test Share Reservation. Test 2 clients with same deny mode
> COUR5: Test Share Reservation. Test Courtesy client's file access mode
>        conflicts with deny mode
> COUR6: Test Share Reservation. Test Courtesy client's deny mode conflicts
>        with file access mode

Thanks!

> @@ -73,6 +76,8 @@ def testLockSleepLock(t, env):
>  
>      c2 = env.c1.new_client(b"%s_2" % env.testname(t))
>      sess2 = c2.create_session()
> +    res = sess2.compound([op.reclaim_complete(FALSE)])
> +    check(res)

Nit: this is a separate bugfix, right?  I'd rather have that kind of
thing in a separate patch.

Also, you could just use new_client_session().

--b.