Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp3239984pxb; Sat, 9 Oct 2021 05:36:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwq8QHX/+R9f4AV4tdY/sFBS9VX95i98SzavA7eWsFzTEMdqivbk6ofoKV3qeDeJY+u+VVM X-Received: by 2002:a05:6402:1d15:: with SMTP id dg21mr24294972edb.96.1633783011727; Sat, 09 Oct 2021 05:36:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633783011; cv=none; d=google.com; s=arc-20160816; b=dn0VbEpjKWf6K+6YvlQdSQk8Z8yr/XIiNYdOUhw8rO6nNZY0mkN7kh5iyqPDbI5I/X 4G/FRwrBe2H+9U2ucqGfto4dip8kDYzNsdcN7AByrZ00NGBcCyZHRssh9DP9nkPRgxe9 UajiPVoDoaPQ9GikNoD6t8AsYELWc5iZRXl/4j2EQWAch6o4s53NehuSNfMLIyIvrrco e4kB0CNx5D8y2rGP6c6y0Q/tmDjVozrLMMcd8ojaXjIOza5vrZJcNBPhEsTLw5ypKjuT nYM2gQ3Y3dg7RwRiQ4NwgyTvhiXJHk5c6jHwpAaSD4g5huqiBdq6IJbCrKcDQy7OL/O+ ao4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=jdTmtgaMNwpebhIB6PoYaRSJghKCrcGVuFo7wht5iso=; b=ArAFN8HoYmt4dUCfLa0ce9Sy8D79LbfRobVlk59knDG1vXAcbliiOHfmkSZUYZ+5Hd dYL74lH0VLhQO4L6u6xXRVlLaujbH6i/Yk62ELnzd7NL9oCIXnZ9jU7FkkorwxLFp4d/ cB4fvcyn/cL0hVN0iwCp6O7rpcWDW0aqyiMJNJAgFC2nImhULPQHDUHHVwKhcQri/2hm lEdKxz2h1nGZVZrZX8sbi3GOB6h/7wwraoUDn4DEX5/tn4uNR6ArzPfwF7oHNkAFXDN0 Jh2WWSDZKerD9sMWblKiCEhnQl8wttskvV+xPeliCZHwawzydUq2i9b75UabRXX7tOS9 L/TQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=e7UAxsf0; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qt17si3636512ejb.251.2021.10.09.05.36.28; Sat, 09 Oct 2021 05:36:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=e7UAxsf0; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232967AbhJIMiW (ORCPT + 99 others); Sat, 9 Oct 2021 08:38:22 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:26062 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232982AbhJIMiW (ORCPT ); Sat, 9 Oct 2021 08:38:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633782985; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc; bh=jdTmtgaMNwpebhIB6PoYaRSJghKCrcGVuFo7wht5iso=; b=e7UAxsf0TX5GpA3OyHb0RC8yXsH/imKdehWb9RtJ/t/YsF6hhSeGWvJIDxvPFk4L+3jfCU kSHZHS3nSZW+B8sv3zQRn4XmhxoImb/nCaqSiiFkSIVT5AxbjNnOkJTggcITU5nN9eQnD9 DnI590gxWOdXNCfY77gq9y5R8szjZp4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-346-CJbEELwANZO9XNZGWuSSLQ-1; Sat, 09 Oct 2021 08:36:23 -0400 X-MC-Unique: CJbEELwANZO9XNZGWuSSLQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B9D5810059DF; Sat, 9 Oct 2021 12:36:22 +0000 (UTC) Received: from dwysocha.rdu.csb (unknown [10.22.8.9]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9495110016FF; Sat, 9 Oct 2021 12:36:04 +0000 (UTC) From: Dave Wysochanski To: Trond Myklebust , Anna Schumaker Cc: Matthew Wilcox , David Howells , Chuck Lever , linux-cachefs@redhat.com, linux-nfs@vger.kernel.org Subject: [PATCH v2 0/1] Convert nfs_readpages() to nfs_readahead() Date: Sat, 9 Oct 2021 08:36:01 -0400 Message-Id: <1633782962-18335-1-git-send-email-dwysocha@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org This patch converts nfs_readpages() to nfs_readahead(). It was applied as follows: 0. Start with trond's testing branch at 0abb8895b065 NFS: Fix an Oops in pnfs_mark_request_commit() 1. Apply David Howells v3 of "fscache: Replace and remove old I/O API" [1] 2. Apply my fscache patches v2 of "Various NFS fscache cleanups" [2] 3. Apply Chucks v3 of "NFS: Replace dprintk callsites in nfs_readpage(s)" plus one fixup (remove the "read_complete:" label in last hunk, which conflicts with #2) [3] 4. Apply this patch So far the existing BakeAThon tests have gone well with no oops or any failure differences in xfstests (generic) between 5.15.0-rc4 and kernel with #2 and #3 above. I will continue testing now with all patches as described above (#1 - #5). As far as I know this has been an outstanding item for the NFS client for a while and the fscache fallback IO API clears the way for this patch. I also just posted a v2 of the nfs-utils patch to display a "VFS readahead" count rather than a readpages count [4]. [1] https://marc.info/?l=linux-nfs&m=163363955619832&w=2 [2] https://marc.info/?l=linux-nfs&m=163364580324243&w=2 [3] https://marc.info/?l=linux-nfs&m=163370503223875&w=2 [4] https://marc.info/?l=linux-nfs&m=163378240328297&w=2 Dave Wysochanski (1): NFS: Convert from readpages() to readahead() fs/nfs/file.c | 2 +- fs/nfs/read.c | 18 +++++++++++++----- include/linux/nfs_fs.h | 3 +-- include/linux/nfs_iostat.h | 6 +++--- 4 files changed, 18 insertions(+), 11 deletions(-) -- 1.8.3.1