Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp3514806pxb; Wed, 13 Oct 2021 07:33:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxfyN9iSqB1Y88LW6DsTuSJ527Zkg7JdW0fs/RI68Cznwpebo55mKI7WaZ8vjAAadiqb30v X-Received: by 2002:a17:902:7b85:b0:13d:cdc4:9531 with SMTP id w5-20020a1709027b8500b0013dcdc49531mr36843314pll.27.1634135588046; Wed, 13 Oct 2021 07:33:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634135588; cv=none; d=google.com; s=arc-20160816; b=nPH2jomqSgNcknSnr4j/F39qqCRFxet1UG2nCgqb8rcsqd3jeMmWWJFHy3AcmnWgES M4ISlPC2yYcJ1BbVX2f/tpB+AbL9W739Mkr9zeBhxuop0niXAZrYtLZayMpzbp+advs5 9lvsewuPMPr9fZaNHKiCAGLDhaT9YZYxuCR9ntqAhJY/ESgkp/AvNGjqgbN2KaXVgOV9 g26kk0Ig6UMSUzStYto01q5zPiRoc2KHJZRjThGAhww0BtGGx3Lfm/S/5mwe175YPAiV oy6NEKeKzSVI9ByZLTO1sB8JBnPYL7q+NHOf8a4PyGYkn6J6C1CniW1m0fiEs9m/Oye2 L8dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:from:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:date :dkim-signature:dkim-filter; bh=7neI4NRfxHBC0DuGJuEpJwJ+Tr5MAoMaTHPESom+Gag=; b=DXzLmnr4f53Ppmj6FesRhNYkGLf98eskv6eEoACl8i+cuI/sOXfDLWSMRwX/ACXQMR BJctg7L6l1ica2Vw9X3+EPRQhdmV1cFoHLz6CzYx9AMpajudqo4rb7L/XZRgfwActSC5 0knyeNHm2LwMdFVORYkSmGQm47u4Rc0JT4Pquw/ygEvxvvw2c7dRyryq6EYq/bdqQ1iM CarOlaP9QMjQVbhBQPkqHKr9Pn2gEnWvuv5k6nQl7K8IKTyTIus+INp7DPEe3t+1/Lub 8s072yIiXwn8HqTFTGSRoeD8Hr48Ik0zz/tOO28Gi6b4hQZLmTHC5qeRLOSie9iHHf1t Pf3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@fieldses.org header.s=default header.b=gsB6Kzgx; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g4si5731210pgu.471.2021.10.13.07.32.49; Wed, 13 Oct 2021 07:33:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@fieldses.org header.s=default header.b=gsB6Kzgx; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230076AbhJMOeA (ORCPT + 99 others); Wed, 13 Oct 2021 10:34:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236821AbhJMOdb (ORCPT ); Wed, 13 Oct 2021 10:33:31 -0400 Received: from fieldses.org (fieldses.org [IPv6:2600:3c00:e000:2f7::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B33BAC061749 for ; Wed, 13 Oct 2021 07:31:27 -0700 (PDT) Received: by fieldses.org (Postfix, from userid 2815) id 1C5A66C87; Wed, 13 Oct 2021 10:31:25 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.11.0 fieldses.org 1C5A66C87 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fieldses.org; s=default; t=1634135485; bh=7neI4NRfxHBC0DuGJuEpJwJ+Tr5MAoMaTHPESom+Gag=; h=Date:To:Cc:Subject:References:In-Reply-To:From:From; b=gsB6Kzgx/0PUprHfNLmoSeTbasfrWRvn1aaSmZz4dpkyTU+awHdnzI7Xlf5cNjXPQ atRhSxZ2Etg4PBw2l/axRwCsx+UbJNCIS8f62rej/h1RRYKOg7hvWmOUXzSrtBV57f Iim65+dyfSJLFcrch0qg5WxkOpUfUJHgpDFYHPnE= Date: Wed, 13 Oct 2021 10:31:25 -0400 To: Chuck Lever Cc: bfields@redhat.com, linux-nfs@vger.kernel.org Subject: Re: [PATCH v1 0/2] Update synopsis of .pc_decode callback Message-ID: <20211013143125.GA6260@fieldses.org> References: <163405415790.4278.17099842754425799312.stgit@bazille.1015granger.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <163405415790.4278.17099842754425799312.stgit@bazille.1015granger.net> User-Agent: Mutt/1.5.21 (2010-09-15) From: bfields@fieldses.org (J. Bruce Fields) Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Tue, Oct 12, 2021 at 11:57:15AM -0400, Chuck Lever wrote: > As we discussed many moons ago, here are clean-up patches that > modernize the .pc_decode callback's synopsis, based on the > recent XDR overhaul work. Looks sensible to me. Applying pending some testing. --b. > > --- > > Chuck Lever (2): > SUNRPC: Replace the "__be32 *p" parameter to .pc_decode > SUNRPC: Change return value type of .pc_decode > > > fs/lockd/svc.c | 3 +- > fs/lockd/xdr.c | 123 +++++++++++++--------------- > fs/lockd/xdr4.c | 124 ++++++++++++++-------------- > fs/nfsd/nfs2acl.c | 36 ++++---- > fs/nfsd/nfs3acl.c | 26 +++--- > fs/nfsd/nfs3xdr.c | 163 +++++++++++++++++-------------------- > fs/nfsd/nfs4xdr.c | 28 +++---- > fs/nfsd/nfsd.h | 3 +- > fs/nfsd/nfssvc.c | 11 ++- > fs/nfsd/nfsxdr.c | 92 ++++++++++----------- > fs/nfsd/xdr.h | 21 ++--- > fs/nfsd/xdr3.h | 31 +++---- > fs/nfsd/xdr4.h | 2 +- > include/linux/lockd/xdr.h | 19 +++-- > include/linux/lockd/xdr4.h | 19 ++--- > include/linux/sunrpc/svc.h | 3 +- > 16 files changed, 334 insertions(+), 370 deletions(-) > > -- > Chuck Lever