Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 5/7] scsi: add a scsi_alloc_request helper
To:     Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
        "Martin K. Petersen" <martin.petersen@oracle.com>
Cc:     "J. Bruce Fields" <bfields@fieldses.org>,
        Chuck Lever <chuck.lever@oracle.com>,
        linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
        target-devel@vger.kernel.org, linux-nfs@vger.kernel.org
References: <20211012120445.861860-1-hch@lst.de>
 <20211012120445.861860-6-hch@lst.de>
From:   Hannes Reinecke <hare@suse.de>
Message-ID: <ac0b2dad-6077-f738-fa0a-0340c435e08b@suse.de>
Date:   Thu, 14 Oct 2021 09:37:45 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211012120445.861860-6-hch@lst.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 10/12/21 2:04 PM, Christoph Hellwig wrote:
> Add a new helper that calls blk_get_request and initializes the
> scsi_request to avoid the indirect call through ->.initialize_rq_fn.
> 
> Note that this makes the pktcdvd driver depend on the SCSI core, but
> given that only SCSI devices support SCSI passthrough requests that
> is not a functional change.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>   drivers/block/Kconfig              |  2 +-
>   drivers/block/pktcdvd.c            |  2 +-
>   drivers/scsi/scsi_bsg.c            |  4 ++--
>   drivers/scsi/scsi_error.c          |  2 +-
>   drivers/scsi/scsi_ioctl.c          |  4 ++--
>   drivers/scsi/scsi_lib.c            | 19 +++++++++++++------
>   drivers/scsi/sg.c                  |  4 ++--
>   drivers/scsi/sr.c                  |  2 +-
>   drivers/scsi/st.c                  |  2 +-
>   drivers/target/target_core_pscsi.c |  3 +--
>   include/scsi/scsi_cmnd.h           |  3 +++
>   11 files changed, 28 insertions(+), 19 deletions(-)
> 

Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer