Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp4237917pxb;
        Thu, 14 Oct 2021 01:02:24 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJzGMe9wEE7L4ZtcHMfzLFrAYtPGKjnprKNxWrelXJaS7F7B3/5q43VOSE0IMWEWDJ2gM+ca
X-Received: by 2002:a05:6a00:2306:b0:44c:6d97:5a5e with SMTP id h6-20020a056a00230600b0044c6d975a5emr3688304pfh.84.1634198544472;
        Thu, 14 Oct 2021 01:02:24 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1634198544; cv=none;
        d=google.com; s=arc-20160816;
        b=G+1qjFShdGPSOUzc1TMTpw/6BIoEp3NviR+odUyRn26VgTGr3dF+seV4TGeulBo6Em
         tqXVDSP41Xo5OqWOB4hata3GD3VZZhXeR9KBD89Japy6sR8onF7hbeQDHHTLwM1xxUCp
         hqk5IhH7hMALV82Q3nWSnNo0epfA6GznLOokgDbYQ16zZHPkUpC3wcFz6gQ749htp/vN
         E00z8I39mcVInEm+naJL7rigf7IxOTt9s0mbbx4wjm6nJH888xshp3s1fQ94+oEIspA7
         PaLIgTfaEkpagXMu1gNscwOjyveatyucJQEEoQb282xixGB/YKzM6frG8YbgC9ZxAAB8
         3Kuw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:user-agent:in-reply-to:content-disposition
         :mime-version:references:message-id:subject:cc:to:from:date;
        bh=A75J63FW3VuvJP6FjHeY1G1Pc8hQJvaQ4C1yc/x75+I=;
        b=hQEWZqWKInYdoNcNI3cym/g62FXDq96p8g2nNrCS4o1+A3m92iNCA7h6v39novW38I
         jRHfSh+sDCghQdFTEErQEzAF1opybd4XM99lA2RSpG5Cl6WDplRx6PVTYPPzufq3YPmP
         4CTN1WkGbTBwuNgfBmfb5bl/+Rb28xkKK8aOZowlKtu3NTXOpLvoO8eJG9AlH9CsQu0o
         Ds04Is6I0aBZyOfQM2MNhSAcu/EbRdhStuCmTyLlpjAiQ/pAHSq8AKxKMPZFqFmgpxFC
         Hz7VxRt6DU9eMekjPLGs553NytuqS/HpKF/ImNWiKlzN3d5b4lpzVBWIDgNrm/Bj9Jx4
         12PA==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org
Return-Path: <linux-nfs-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id ls9si877352pjb.84.2021.10.14.01.01.59;
        Thu, 14 Oct 2021 01:02:24 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229967AbhJNIEB (ORCPT <rfc822;mjnowen@gmail.com> + 99 others);
        Thu, 14 Oct 2021 04:04:01 -0400
Received: from verein.lst.de ([213.95.11.211]:49062 "EHLO verein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S230072AbhJNIDn (ORCPT <rfc822;linux-nfs@vger.kernel.org>);
        Thu, 14 Oct 2021 04:03:43 -0400
Received: by verein.lst.de (Postfix, from userid 2407)
        id 1E1AC68B05; Thu, 14 Oct 2021 10:01:35 +0200 (CEST)
Date:   Thu, 14 Oct 2021 10:01:34 +0200
From:   Christoph Hellwig <hch@lst.de>
To:     Hannes Reinecke <hare@suse.de>
Cc:     Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        "J. Bruce Fields" <bfields@fieldses.org>,
        Chuck Lever <chuck.lever@oracle.com>,
        linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
        target-devel@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 2/7] sd: implement ->get_unique_id
Message-ID: <20211014080134.GA28835@lst.de>
References: <20211012120445.861860-1-hch@lst.de> <20211012120445.861860-3-hch@lst.de> <0a7d87ef-fff2-6a63-8edd-604ad8868dbd@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0a7d87ef-fff2-6a63-8edd-604ad8868dbd@suse.de>
User-Agent: Mutt/1.5.17 (2007-11-01)
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

On Thu, Oct 14, 2021 at 09:30:51AM +0200, Hannes Reinecke wrote:
> What's wrong with scsi_vpd_lun_id() ?

It doesn't allow the caller to pick a specific ID type.