Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp4239302pxb; Thu, 14 Oct 2021 01:04:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxcYzLGPdUs+m48y7nj5Cpk16VFP+8eDb0qDTrRgVDaVWJJjWBDx6BoTrnybX4sb9/by2uA X-Received: by 2002:a05:6a00:2449:b0:44c:2221:8c38 with SMTP id d9-20020a056a00244900b0044c22218c38mr3706406pfj.74.1634198662745; Thu, 14 Oct 2021 01:04:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634198662; cv=none; d=google.com; s=arc-20160816; b=Avr4X2Kc5KUg2IBKQ+n5qfxq+MGNuXj3jr1Q9Rzx0ydSipMNoOA74kvm3yS1g8up0N eElFI3u5pQYJ3MR04+Hil8WBOAkOL048CkZMa50s4CcAPpDDqz8PZRSpVLBTO6KpGuip 8AjRRpP7as703XSTQ7IXA65sYp2mOXbALL6IAGujr/R0spIBSxA3PXV6ufJLVSJtIhiq Yd0cNaxpReanRFp8SMD7S15D5ofdd3/WU0+zZvv6Lnyg9W9gyUAOuF/s9tZ27mx6j8v1 s69lyuxwnnV0dR3lb0V0HHgYt7jautZcWnK7o/nIqGx63cqDfJGCS8TaevtkIAVe4Yrj 7uxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=dmveWdv0x9hlJ9T/wsJgB4u1UX9aISEwhHkbr4nj6+M=; b=zEw0NkiFKyN5gtFVKtR6l/5KarnP9CZ/XDoCx0XJk5QMfCEUQ3z4XiL8on/ty7MyXk JekzbxFyWBP9qdaSz5MchyJX8C9ujkjJxGVSUaUztMP+NQfaXd+QUswoMmgxz6cXK9Um fLF2vBTnJ2ZkBWsrd2og4h39/KSUYWe7+sCn6r4clt/RNV1VUqaD7WcgqbANdGakoFB0 2oalGN14K4gIFLv9lWhFcbDUgux5MP0Iz3oAiFXk60kBmvlIuzPMMORDBEAx3GxEK/zx CBpnpl/T4P9ibep/4PHbk2ovppibAsnEngDMbtCAh3UUgbOcJyTOQKH7Vk5fLezgOmGY /SNA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b9si2508757pjh.113.2021.10.14.01.04.09; Thu, 14 Oct 2021 01:04:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230094AbhJNIFk (ORCPT + 99 others); Thu, 14 Oct 2021 04:05:40 -0400 Received: from verein.lst.de ([213.95.11.211]:49081 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230180AbhJNIFj (ORCPT ); Thu, 14 Oct 2021 04:05:39 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id BEB7968B05; Thu, 14 Oct 2021 10:03:32 +0200 (CEST) Date: Thu, 14 Oct 2021 10:03:32 +0200 From: Christoph Hellwig To: Hannes Reinecke Cc: Christoph Hellwig , Jens Axboe , "Martin K. Petersen" , "J. Bruce Fields" , Chuck Lever , linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH 2/7] sd: implement ->get_unique_id Message-ID: <20211014080332.GA29337@lst.de> References: <20211012120445.861860-1-hch@lst.de> <20211012120445.861860-3-hch@lst.de> <0a7d87ef-fff2-6a63-8edd-604ad8868dbd@suse.de> <20211014080134.GA28835@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211014080134.GA28835@lst.de> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Thu, Oct 14, 2021 at 10:01:34AM +0200, Christoph Hellwig wrote: > On Thu, Oct 14, 2021 at 09:30:51AM +0200, Hannes Reinecke wrote: > > What's wrong with scsi_vpd_lun_id() ? > > It doesn't allow the caller to pick a specific ID type. ... and of course that it returns an ASCSII string instead of the binary ID.