Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2847084pxb; Mon, 18 Oct 2021 03:13:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx6BITdfJqSHn8Kk5YQv8GTw9nkAP+pboobBVVGTOcI8wE119/w2qy2WqLc34kIAC5OE8kl X-Received: by 2002:a17:90b:370f:: with SMTP id mg15mr32322239pjb.209.1634552038976; Mon, 18 Oct 2021 03:13:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634552038; cv=none; d=google.com; s=arc-20160816; b=WVokfWbFl7v7oJHe4XHAdPeSwwHaMvSBM2TunV2GYJlHdOTkXrhWHcmRaxelzhwRGq kwy6/kSu1MC5xC27Qwp8G9q3oIatfsnWDab9l4eKxvdBTQCsnK4LfgQIALH7U3+hIWyi iZNDNe6HZe1aoEBorzda5JjztHA63OlQsdCZuLAqRNoiaeELNkEaMEFws/ePChkexWSd l/ZtX54QXcdKeMlnpvrxdcBy10lqrxUAvr4Y9b1SSd36mwnPki+mKXjK/nnxWOf+ykPX KeEW77s7mC4WUWz/2XOGV/5oQXjDybcXnr4NeRqgZGqatxZR32PJdy6NtuJuZIAr6nsn icRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=JMPu+LENDBo5WUsA2GqtbBEG8Jw1OQsq2zrbWWP5Nwo=; b=eNkk79Uos/9xNpWdHgiZ1y5xUhet+VVCq1+0p1AoavIy9lwNLrwB8roh4Le9zP5Ix/ jTSw7JFrhaeTq7v8KqGsGnCvyaQgErZDrStmGfiv/P/E6oFTWInDJ8DqK8CYprfs6wPI EdneiQFMlks6PNaTIvftlH2FT1MILza2Dc657RDbugUiNdlPYdM2iSM15RCIUhmC26Qc v/jqzi0BwjQORra6wBF/2Jdj1HKgLCREQP40JFOwGxM1kUnFMF0Gn1AtTCsp5mZn7GsY imqDcwu+vNnDMVYNikXH9n/nfIrFDyT7E9HBvZIusKXuExtt6V23b/yNo+1En4+TnT0I yO/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=LQSSZHMv; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r11si1068908plr.110.2021.10.18.03.13.46; Mon, 18 Oct 2021 03:13:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=LQSSZHMv; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232183AbhJRKPx (ORCPT + 99 others); Mon, 18 Oct 2021 06:15:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231501AbhJRKOy (ORCPT ); Mon, 18 Oct 2021 06:14:54 -0400 Received: from bombadil.infradead.org (unknown [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA320C061768; Mon, 18 Oct 2021 03:12:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=JMPu+LENDBo5WUsA2GqtbBEG8Jw1OQsq2zrbWWP5Nwo=; b=LQSSZHMv2uVXfonRxRFX6ja6Oh eGRR3MNc1mGAQBs0DNyB1vRYImhOqowRmW7fyj72Thmu4pztEMuT8Sh29JBnr+5bFD5P4IVg/pf0I P/8IZtD68Tkv0tkuMKJyC/vOClkagcPllgq5l50/K8TpSSATx/V1h7/rHZsD/dE9ctisbuJUZr4PX /tn3a6rHsJivMC/Uk5TS1tifDMdYjU88x7OQ3LcwR5/i122NQR+WSmrzpiUcIcd/t8I+lkXLk6PxB qnF6M1SKLWCal6TQdjpgSU8sythC3yyy5ViLBJ+ETNWQbNUzHrxG//gf79BsT7p8S4G9ZZlzrekoX emqLZz4w==; Received: from [2001:4bb8:199:73c5:c70:4a89:bc61:2] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mcPd9-00EuiW-Vx; Mon, 18 Oct 2021 10:12:32 +0000 From: Christoph Hellwig To: Jens Axboe Cc: Coly Li , Mike Snitzer , Song Liu , David Sterba , Josef Bacik , "Theodore Ts'o" , OGAWA Hirofumi , Dave Kleikamp , Ryusuke Konishi , Anton Altaparmakov , Konstantin Komarov , Kees Cook , Phillip Lougher , Jan Kara , linux-block@vger.kernel.org, dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ntfs3@lists.linux.dev, reiserfs-devel@vger.kernel.org, Jan Kara , Chaitanya Kulkarni Subject: [PATCH 22/30] reiserfs: use bdev_nr_bytes instead of open coding it Date: Mon, 18 Oct 2021 12:11:22 +0200 Message-Id: <20211018101130.1838532-23-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211018101130.1838532-1-hch@lst.de> References: <20211018101130.1838532-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Use the proper helper to read the block device size and remove two cargo culted checks that can't be false. Signed-off-by: Christoph Hellwig Reviewed-by: Kees Cook Reviewed-by: Jan Kara Reviewed-by: Chaitanya Kulkarni --- fs/reiserfs/super.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/reiserfs/super.c b/fs/reiserfs/super.c index 58481f8d63d5b..8647a00434ea4 100644 --- a/fs/reiserfs/super.c +++ b/fs/reiserfs/super.c @@ -1986,9 +1986,7 @@ static int reiserfs_fill_super(struct super_block *s, void *data, int silent) * smaller than the filesystem. If the check fails then abort and * scream, because bad stuff will happen otherwise. */ - if (s->s_bdev && s->s_bdev->bd_inode - && i_size_read(s->s_bdev->bd_inode) < - sb_block_count(rs) * sb_blocksize(rs)) { + if (bdev_nr_bytes(s->s_bdev) < sb_block_count(rs) * sb_blocksize(rs)) { SWARN(silent, s, "", "Filesystem cannot be " "mounted because it is bigger than the device"); SWARN(silent, s, "", "You may need to run fsck " -- 2.30.2