Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     "cgel.zte@gmail.com" <cgel.zte@gmail.com>,
        Bruce Fields <bfields@fieldses.org>
CC:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Changcheng Deng <deng.changcheng@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] NFSD:fix boolreturn.cocci warning
Thread-Topic: [PATCH] NFSD:fix boolreturn.cocci warning
Thread-Index: AQHXxJ/Wv9o3Oub3V0qj0+G2Tv5Mg6vaY1iA
Date:   Tue, 19 Oct 2021 14:33:36 +0000
Message-ID: <B9D7D22B-EDFA-4144-AFCF-A66E12CB073B@oracle.com>
References: <20211019041422.975072-1-deng.changcheng@zte.com.cn>
In-Reply-To: <20211019041422.975072-1-deng.changcheng@zte.com.cn>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jN/+AU9/kzHgZV7oWie030ngxmQXtNwZVBjkndzmm6tC1Jb7jWNAGXJUWdjm?=
 =?us-ascii?Q?vjaRDn0Ltg47jCMBYq2q4HoOeO6IBNpyumnN2pg5nufS/f+FM3clhobKJQkf?=
 =?us-ascii?Q?aPzAbpJ4H6rvpXXj9taRgylD8jn4LulP69CubNBx5yureTjP50VtPFnJExWw?=
 =?us-ascii?Q?soRLNkPPsJzUgSkI8HKRhRJM0Q/k9gSg/pKnyOSK19eKPvsdi8fcGh4QyRrR?=
 =?us-ascii?Q?weuKL4mH6nmqll8395dyrc1NKXbZn7yKZ3rdLdQi0vuGwFXZk0enDwxVcjVg?=
 =?us-ascii?Q?eLMMadxyjdeNhR8aRZTQowgR+84SVAtccN8w0ePGGyGGeKpXscR6Z4hwsMnB?=
 =?us-ascii?Q?pHynMNdss1yTgL9sS13DB8TVLpW7gHl1qRTEZGh6yWwgrfSIPOeU5Y/UkBjr?=
 =?us-ascii?Q?J/P8N3+Qd09auq9YzXPs0NIwV7s3HVyakq0DhFcJnG52xlKDgPzgj95zQ1MS?=
 =?us-ascii?Q?yIw1vN9i+itYiX/i3QoXK2FlcLJ3/eQXf9DZXctuuJmJXraOcH1ChuYTOWND?=
 =?us-ascii?Q?+fM8YX2gTL7mgR1dhRkSMbKrgozmrEcR6wmAjJNBJJSRqd58QTWvmEbESpvb?=
 =?us-ascii?Q?Unqb27ZriHU87yd28KnJMcwrJNP1rS6yFuVKsFaTtwRu3oJtl/edLyBOh/Sr?=
 =?us-ascii?Q?iKFh9K4Wo/GPHhMAJvqJQRqQl0d7a/cUNRcSjFeSaxqv/2ZsJueYMjVLJpDA?=
 =?us-ascii?Q?0o6embV+6cKi+LIoOspGxW8cgwqx/lQJV9cr2poj8lQu1aZtLE6SF6vZxB3u?=
 =?us-ascii?Q?+Det5eubOIuA0XqRneSmiqCLO0/UFZKS07Cr0s73sJwf4Kpt0h4wmQP0VU7V?=
 =?us-ascii?Q?UGQwUNMck78zHfK8J73jMkCaBfsr90bNN02VfQolXX+x1bArYjZt7W9eDONs?=
 =?us-ascii?Q?x1aGEJvlb+caB6UYqEbQYmZ+TDI5FCA6dDPnHuOiy9UVOceihwXDrNuduUmB?=
 =?us-ascii?Q?KhsXp9T6gH2de2WySnM2eNxzR7tqJ0gRIThRmzcNeeWZYh+ZYouf9A3DtB+g?=
 =?us-ascii?Q?9mjveO/IfyJqgEwgnBQACn5mhOjvM75Bd5vb1kBOVh/+3JzyNbabI2UP8Y/c?=
 =?us-ascii?Q?qsrzHp1D8S8gbuBu3alqNhUmH5fSaHMS8Xu+DuN38NLLtMLibYoaZBKlmw/y?=
 =?us-ascii?Q?xEmIun+MYtdFlZ2gto2oe9HNByXTGbJlDOXT3gwuzzIHNoXjsWwnyjGJbqJU?=
 =?us-ascii?Q?jQ6GR2g6QTqRDbh/N+nlyOO/d3G0b/DMvW8dYrFX/XO3SauWkfED8HcJugK7?=
 =?us-ascii?Q?cp3E56S56vprqU+zqZuIpM6F3wm1qU+XPdnUPq3uwfxrMGDv/fqzaGlQS18w?=
 =?us-ascii?Q?VjnhGCAvfbS11h4INj7pvJAD?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <AED33ADF34F73E48BE7149686E9060E8@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4688.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eb2e128e-e3ce-4a69-22a5-08d9930d6f5d
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2021 14:33:36.0992
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9WAm2W6o1WYRsepfV9IDKZZcDE6rjs9N/NLRNYYgQErrapn4um317DlJHdy0gwLXIGGnIki5Y6oscgJMRFc8MA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4386
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10142 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 malwarescore=0
 phishscore=0 mlxlogscore=999 bulkscore=0 suspectscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110190089
X-Proofpoint-GUID: wQOmDvM2isZaWARrwysACv7s_-lr2AaH
X-Proofpoint-ORIG-GUID: wQOmDvM2isZaWARrwysACv7s_-lr2AaH
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Oct 19, 2021, at 12:14 AM, cgel.zte@gmail.com wrote:
>=20
> From: Changcheng Deng <deng.changcheng@zte.com.cn>
>=20
> ./fs/nfsd/nfssvc.c: 1072: 8-9: :WARNING return of 0/1 in function
> 'nfssvc_decode_voidarg' with return type bool
>=20
> Return statements in functions returning bool should use true/false
> instead of 1/0.
>=20
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>

LGTM.


> ---
> fs/nfsd/nfssvc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c
> index 362e819ff06a..80431921e5d7 100644
> --- a/fs/nfsd/nfssvc.c
> +++ b/fs/nfsd/nfssvc.c
> @@ -1069,7 +1069,7 @@ int nfsd_dispatch(struct svc_rqst *rqstp, __be32 *s=
tatp)
>  */
> bool nfssvc_decode_voidarg(struct svc_rqst *rqstp, struct xdr_stream *xdr=
)
> {
> -	return 1;
> +	return true;
> }
>=20
> /**
> --=20
> 2.25.1
>=20

--
Chuck Lever