Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1582989pxb; Wed, 20 Oct 2021 07:55:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJydPbG/LHnXi/NkZbwM4jJmDda5GUNlunZAwWJH3XxTfIu17EdmCIM3uvSORrOqlEp/7Jet X-Received: by 2002:a17:90a:5b0c:: with SMTP id o12mr7925108pji.11.1634741706915; Wed, 20 Oct 2021 07:55:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634741706; cv=none; d=google.com; s=arc-20160816; b=fPNAR81lwpiLLUfjxrj0pao+apwraVM1vf60bBb7R37LuzPOzFOEg108wj27NIfcVD HrSU11L99tz3lmqZTOwZoaa6MBw6Ah64IxhKVvFdh/AWPzw4vksHs4p6J/jvgDZWcpUI QnageUWMcCBwomOGGVbreaULpU/LRyNO4I1FbE/nhi/XlwgXN4FTM1MvIyu+aW6gmVrf AHeM75pHTCep1+GUYiUK79mbdfE6I3Nq1AR8tnpiV8bNloIemjesaZEV2X7KRlLtlBCZ 1AVA05K6x+JopZV04kURnq5CA3EOffbPueYQjioemqmp3ZkL/nIb0WT8Gk7LNy2CEgnD SJ5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=TZZSEfWCStHUfXhWoXkg5KMgJocnV57u5o2CEcJ7HCc=; b=oJFx7Gj0JN0CfKpQVJJl3DV0BDFwWXjWxoIvRsQewk2jPcyxbjrSbX+9I3j+Nn39wo mfMahAgnurRCJgPl8WCMxqgsoEQzN9/b/3EbRSFpOsRW1DQQ5XlywwCGXvaVJOqXO/nP ntB69PsN2g33Cfty1cYaEUfcn1sMM4BDAbqRBdxNYe3lmTt7bDup6MTJ25M9uTBYYAOB kuKpLdfC6GqTs6ZKwECd30m1v31nXfwGQuwJNr2BU6l8mCDeEAvaF0EDp6TIcda4KWI1 Qi89B+s/Be573X94CxSYb53wBnPJkVysPyXadnATNKEJCEBk9XaRAjRjdL5mllAMdleX FJyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=m6t8lcoq; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u8si4012911plf.235.2021.10.20.07.54.41; Wed, 20 Oct 2021 07:55:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=m6t8lcoq; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230219AbhJTO4d (ORCPT + 99 others); Wed, 20 Oct 2021 10:56:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230106AbhJTO4c (ORCPT ); Wed, 20 Oct 2021 10:56:32 -0400 Received: from mail-ot1-x333.google.com (mail-ot1-x333.google.com [IPv6:2607:f8b0:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64907C061755 for ; Wed, 20 Oct 2021 07:54:18 -0700 (PDT) Received: by mail-ot1-x333.google.com with SMTP id s18-20020a0568301e1200b0054e77a16651so8540325otr.7 for ; Wed, 20 Oct 2021 07:54:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=TZZSEfWCStHUfXhWoXkg5KMgJocnV57u5o2CEcJ7HCc=; b=m6t8lcoqFlEuO2YtgUGyJOgTFG9r3gegg328r7yqi7ahbS8ubR2dD0/Pj2EWCTAUuA M02ojT0kPrzHZYYG+nzIM/amlc0aviTrC5h073WmzUsDG5kSpMZnjhuK+i8EoLI8XtFV tAOJI6Dq6RqsaFkY7XaLCF+jWOo8HC09LBuWXmFGMukDr003XnwiD9sz7/I/c5Gdrkja EgQndCGLKNGRW6KF4GgsUvpBI9e/r1wrQDvkfxN5dmsQcuosbJ5bD+47WPJHDtMVt1ox UNh+E6Iq9tCpN0OMN/AP4Ti0h/SP/2gadP9EfeelfLwNwKFK/cs3CzBNoPypeMhUfQ1Q 8tNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TZZSEfWCStHUfXhWoXkg5KMgJocnV57u5o2CEcJ7HCc=; b=POW3TojUSMFeCWh5Eizx1Fgk0aFKRgNbgB7owvcCUldqnAExFct1XfQLwKu7QH2ODI zZUZ64x/sTe8se0ppp5YFLpNkiyhy85fCxCIJT83MCzSSCEjhKjJ1M2Ug6a+tyWdx4aw CajUuAP53fuHXfoekWkgs3Hhyyij7nyH3xkfVEQVlTzbiJYbJmo6pMMoL1yi79UhB6uR vlJFxqg3nerqHLpZwUhBoZ3LXTxfvGvQbrJyi7KlvIsE5flNmh9ErNbxm61Kkm7iRR0G L4jxTCE2ZXdF/rY8L8whIbl3aUs1OEilZdzRv8EZFXzKD+dswQkqeIvqNseSWGu+16fb GcFA== X-Gm-Message-State: AOAM532Y8KfM7gcY3ciSsdmczXkzGY1R5P8P9H3V49hcYrGhJIpJiqm5 bK77EjDp8jLaUho3ZeEJOfSwt/OG1zOHpw== X-Received: by 2002:a9d:4c99:: with SMTP id m25mr294329otf.204.1634741657447; Wed, 20 Oct 2021 07:54:17 -0700 (PDT) Received: from [192.168.1.30] ([207.135.234.126]) by smtp.gmail.com with ESMTPSA id bc41sm476898oob.2.2021.10.20.07.54.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Oct 2021 07:54:17 -0700 (PDT) Subject: Re: remove QUEUE_FLAG_SCSI_PASSTHROUGH v2 To: Christoph Hellwig , "Martin K. Petersen" Cc: "J. Bruce Fields" , Chuck Lever , linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-nfs@vger.kernel.org References: <20211019075418.2332481-1-hch@lst.de> <20211020053341.GA25529@lst.de> From: Jens Axboe Message-ID: <0a70e163-d6cb-9733-a91f-d0bee2c23c69@kernel.dk> Date: Wed, 20 Oct 2021 08:54:16 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20211020053341.GA25529@lst.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On 10/19/21 11:33 PM, Christoph Hellwig wrote: > On Wed, Oct 20, 2021 at 12:05:24AM -0400, Martin K. Petersen wrote: >> >> Christoph, >> >>> The changes to support pktcdvd are a bit ugly, but I can't think of >>> anything better (except for removing the driver entirely). If we'd >>> want to support packet writing today it would probably live entirely >>> inside the sr driver. >> >> Yeah, I agree. >> >> Anyway. No major objections from me. Not sure whether it makes most >> sense for this to go through block or scsi? > > I'm not sure either, but either tree is fine with me. Looks fine to me, outside of the spelling error in patch 1. I can set up a topic branch for this one. Christoph, can you do a resend with the enum naming fixed? -- Jens Axboe