Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1028097pxb; Thu, 21 Oct 2021 14:21:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwrQVy7fpVh3Ff7SB81WWKjGm7PEv7R8Jsx1iXeEXHPSJvNgaxQ15WBui6Z/iL/5D53Mhtt X-Received: by 2002:a17:906:2653:: with SMTP id i19mr2810521ejc.193.1634851316076; Thu, 21 Oct 2021 14:21:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634851316; cv=none; d=google.com; s=arc-20160816; b=fa/nCS2iZFVeHkvRvEPCiesO96fw5GfxL/LXF90MluF9ONljh6LbAo2apYswz38C41 lz26vQpOkxAu17uFcsgxI3m7pjsDbIazm83SDpptiHeKQJnkMEqI6pUAMEhhlItnvLEi G1SF8dwtnPLa8/Wh2E5hbUAhVLxAA6zN1aedjjgKZT6f42vMHcnP24VVXM4U1dwR+siy d93ITKd82iIkloUhkHxAtqIR7Spl/pWkEroxYlwUbdJsTXxrdVuFiZNDDUuBJhp8mrt7 Ky3zjBjtFBRoqHWanybpvQK+BrTc0k5HXA8TkTTZERZdRgAzUnYjQangsF+IheljYl5c VV2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:to:from:dkim-signature; bh=Br823hDD8fqO+bLsFnzWUbkHeLVKAAXzUyOAXc9F+6I=; b=BuX75Kxv9g7GQfdjYlv/ljcMRKUPeQ54JSU/zq9ZIlJqDYnBYBHYoVjGNBBW8tQAAa 0tNw2OL+wCbY2Ywwxo0BjLgLE1nUO5ocBGiyZw50QfFH7qv6UUEhpYDs1BxtydrI6TOK d9PfwUOa5aJ1H51bxOXCpmzqD8aPFWZqzhbdYMrXZSPPpyz8Jy74hYqU3xOyoTCkAcD/ VcvvsHi/1h+A2BsC2qeX/EIHedx3dOByrjLK6BVup53FGgW099tcC+XvKJM3wXD4qWNF 5uU5QhQ5M1vfKDQed0aMPdLJW+9zEb1l7OgFml7T2D42taESqwHPWxZT9raYRe3lMSws ryHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ti1cvVXM; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x2si8233452edq.409.2021.10.21.14.21.18; Thu, 21 Oct 2021 14:21:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ti1cvVXM; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231961AbhJUVWi (ORCPT + 99 others); Thu, 21 Oct 2021 17:22:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:55116 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232173AbhJUVWh (ORCPT ); Thu, 21 Oct 2021 17:22:37 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1D24860F8F for ; Thu, 21 Oct 2021 21:20:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634851221; bh=B1wOpcPrUzB1INGSeHVom+RA7i6RWA/odgHtokOkci0=; h=From:To:Subject:Date:From; b=Ti1cvVXMAyMovIB1BzHsFhKI+kPwjk2hnAsgviARyXRZZazH3P6MYp4PoCf6SLBae Qs8Bck6R0SwITycuPaf7Of2nY2dyYhG8sw0ch6pNXIg5ymCvf4wNIq8Bi+VNcxh1FV UZ19e8zMYwabqE+lACH+iY5p3k9F6MtqYTsS2kOIKbrsBHdeObdvc/1ONh69zcwGmp AtED2WyhywXMlR5mPMryJvbzmJR5gRXhlslVbIvg5qKY5PcJhA5mgOv8+qWHn5Bgxa 4hYgO7jfJ3n/0Aq/x2kgDN44O/izjKuU7GBU5WICXdVMZnJRbdUp16Rtgr6hjCLXmN u75RYqGeMyshQ== From: trondmy@kernel.org To: linux-nfs@vger.kernel.org Subject: [PATCH] NFS: Remove redundant call to __set_page_dirty_nobuffers Date: Thu, 21 Oct 2021 17:13:34 -0400 Message-Id: <20211021211334.681480-1-trondmy@kernel.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org From: Trond Myklebust Remove a redundant call in nfs_updatepage(). nfs_writepage_setup() will have already called nfs_mark_request_dirty() on success. Signed-off-by: Trond Myklebust --- fs/nfs/write.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/nfs/write.c b/fs/nfs/write.c index 82c5b89395f6..9b7619ce17a7 100644 --- a/fs/nfs/write.c +++ b/fs/nfs/write.c @@ -1384,8 +1384,6 @@ int nfs_updatepage(struct file *file, struct page *page, status = nfs_writepage_setup(ctx, page, offset, count); if (status < 0) nfs_set_pageerror(mapping); - else - __set_page_dirty_nobuffers(page); out: dprintk("NFS: nfs_updatepage returns %d (isize %lld)\n", status, (long long)i_size_read(inode)); -- 2.31.1