Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Anna Schumaker <anna.schumaker@netapp.com>
CC:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        Benjamin Coddington <bcodding@redhat.com>
Subject: Re: [PATCH] xprtrdma: Fix a maybe-uninitialized compiler warning
Thread-Topic: [PATCH] xprtrdma: Fix a maybe-uninitialized compiler warning
Thread-Index: AQHXzlh5ESpT5Pt9IEKLG0l4cvaW6avtNIkA
Date:   Sun, 31 Oct 2021 15:04:35 +0000
Message-ID: <3EC776BC-8E37-477B-98BB-C9DE163EFA52@oracle.com>
References: <2b32d41cf6a502918a685447cd749c4b1cb0d16d.1635685588.git.bcodding@redhat.com>
In-Reply-To: <2b32d41cf6a502918a685447cd749c4b1cb0d16d.1635685588.git.bcodding@redhat.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bxuRJye4FmVtBfTa5FhzgqWniz+S+jMYg9PXB6g5DraMWc7h7bX/uywVrthT?=
 =?us-ascii?Q?vjeS1mvcxtejnrLKZNacaj2gnMIf5TTRPonItg5bEQ+R8bTmXODGXgd2iCjB?=
 =?us-ascii?Q?AqzOXeIO0G8NLrbU8/uSZaEhLb+wyc7T0IquEt0BvblpHsRuhIYKrKDJRRM7?=
 =?us-ascii?Q?AvTF9gw0kNFW1hS5yRb5Eu1aldZQ1ofAeHoMXafstwAcd+5KYZYWGBWOaaoA?=
 =?us-ascii?Q?lMAxHqaeJQ3lzjfT+sYkYizvvn7hqA9gzQCFtOutPZGH+TNnXfqGFd95NSFM?=
 =?us-ascii?Q?Si8x4UuiS7jVVcz8eX4esWywqTqmUW5p1dEVvDq9ZUQYLo5o1cYCTp7Z0uo8?=
 =?us-ascii?Q?ZPVGCNoc4uMd5x9kXiNyPJuwmHzvGoy+MXmUU0EUN2rStzvr749FUVWar21k?=
 =?us-ascii?Q?ewDAEyI0I1Ox0m9JTHwLm1REscdpKxoZptRdjry5TvDUjvFGM8vgXiQFtQtB?=
 =?us-ascii?Q?UD98O1IImtN7W2hKbaoNqP+k95AeNVMACA0A3Vx2Pzp2TJkwzQZORoIKJxhc?=
 =?us-ascii?Q?D0n+gI7FAXa6hTzUgmP6JTkSg3aCFW3C1Ztxx8KxY3EscYDZcBtb+WIztl7H?=
 =?us-ascii?Q?50JQImLTX6O0kQ0f1SqGcIh+cXsK9RsXCAa2WqXbAiEyFGms5poOqa2mPzv2?=
 =?us-ascii?Q?MlZb2KAQEjULVixHWUS3PfGptMcbSQld2CnopA3KmTmQNttTO8PO05Vs+L6M?=
 =?us-ascii?Q?KN2jepnPumhcsGIp0TKDOx4ImrnsAiz5yOC6Bn+4B40FJwWxmUgJGuAC1C1G?=
 =?us-ascii?Q?z5TEg8GhQB+ayLiGCwcQKbIwLb3wOKnRR6DCtFvV6pG4ArH4sSaVJPpmCMbx?=
 =?us-ascii?Q?PQ52ho8M4JmzuLpWmKmap/q6u9LeDGOBMvikpUvmnDIRPBDPGuwXf5wM4NWN?=
 =?us-ascii?Q?auaqA4O+iZPS7fnYIOLUAifh6t9ytOHjAywZw77+0OcXTtlIppivhrMYHbL6?=
 =?us-ascii?Q?/GuEh/CHTEsb3C3hn6as0xdXc28IqXJtXzebFXKUdWMcWVwn5lhr53spVnod?=
 =?us-ascii?Q?THleiEPm3lbFGyZoE1K7lWDFZpZ0jJdl53BX1+egbXBFEEAuxcsASMLlKIk+?=
 =?us-ascii?Q?Ct4Z4usnP9BCO8zsSy07zhmX5IJNNl0IfxwBfcgozlBNKuPRjnB7EDDRjNfQ?=
 =?us-ascii?Q?l3ULHGLW+ZvLi2ag5vAdtgGPVzhhL92W6pfoDW/fcxV8Jm+DvlGidJL8/i0D?=
 =?us-ascii?Q?qJCIwt0h+yBmJYoxeBH+Z1UaAZ0JK0lH/IwEIfPUG7bNzL7PWqYTTaKA60E3?=
 =?us-ascii?Q?BVIaWhnBz4tqQ5PJ5mZByY9oCN5ko/+EMT0in9hWlNRVG+tDfbwQgIHtxUY3?=
 =?us-ascii?Q?Fq14ck7C/LzrI6kx4bWn31lZCKU5AuFJybDcQSUtrHVAM5YVGTC8tzPkFsXt?=
 =?us-ascii?Q?clKn9KUkIPw1oJYwRC91CFyJbKJ/AjsCydVtSlynyWUihfPazJhOk/7gkuIm?=
 =?us-ascii?Q?CEjSJeLBbpHdmEvl874rgd56cLxfW82SpsZZ/QXoYc5SOMDaIAy1X/OrpJNQ?=
 =?us-ascii?Q?BHdMUQYoC3o2frQOUwFjn72S40vfC5n07945ecx6aO0f9iA9sryrPEKNPC2u?=
 =?us-ascii?Q?UOvZH+7rp+kSCjGmnnKeK7o1NeDuLwBajEJITpG986e7PWWaeM7Te5WsL0mS?=
 =?us-ascii?Q?RmT+5X513WN+ZnEeQMY/E6E=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <FDC19C377A9BF94C89BDCDF1E7E286B6@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4688.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f2ab1155-a5e8-4895-a75d-08d99c7fc066
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Oct 2021 15:04:35.1263
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: klJuTlpSjgz+Rh+3RRB1T/yR+xGDN0oJ6DJ3xmrPdz3PVVfG+SIf3FXiixYNZ1i5hOGb4cNbyS6BNH/h3Ukbzw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2488
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10154 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0 malwarescore=0
 mlxscore=0 suspectscore=0 mlxlogscore=999 adultscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2110310095
X-Proofpoint-GUID: G6ViPhlHMhX__EX8c6K5mRa9oFKdFiTG
X-Proofpoint-ORIG-GUID: G6ViPhlHMhX__EX8c6K5mRa9oFKdFiTG
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Oct 31, 2021, at 9:08 AM, Benjamin Coddington <bcodding@redhat.com> wr=
ote:
>=20
> This minor fix-up keeps GCC from complaining that "last' may be used
> uninitialized", which breaks some build workflows that have been running
> with all warnings treated as errors.
>=20
> Signed-off-by: Benjamin Coddington <bcodding@redhat.com>

Reviewed-by: Chuck Lever <chuck.lever@oracle.com>


> ---
> net/sunrpc/xprtrdma/frwr_ops.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/net/sunrpc/xprtrdma/frwr_ops.c b/net/sunrpc/xprtrdma/frwr_op=
s.c
> index f700b34a5bfd..de813fa07daa 100644
> --- a/net/sunrpc/xprtrdma/frwr_ops.c
> +++ b/net/sunrpc/xprtrdma/frwr_ops.c
> @@ -503,7 +503,7 @@ static void frwr_wc_localinv_wake(struct ib_cq *cq, s=
truct ib_wc *wc)
>  */
> void frwr_unmap_sync(struct rpcrdma_xprt *r_xprt, struct rpcrdma_req *req=
)
> {
> -	struct ib_send_wr *first, **prev, *last;
> +	struct ib_send_wr *first, **prev, *last =3D NULL;
> 	struct rpcrdma_ep *ep =3D r_xprt->rx_ep;
> 	const struct ib_send_wr *bad_wr;
> 	struct rpcrdma_mr *mr;
> @@ -608,7 +608,7 @@ static void frwr_wc_localinv_done(struct ib_cq *cq, s=
truct ib_wc *wc)
>  */
> void frwr_unmap_async(struct rpcrdma_xprt *r_xprt, struct rpcrdma_req *re=
q)
> {
> -	struct ib_send_wr *first, *last, **prev;
> +	struct ib_send_wr *first, *last =3D NULL, **prev;
> 	struct rpcrdma_ep *ep =3D r_xprt->rx_ep;
> 	struct rpcrdma_mr *mr;
> 	int rc;
> --=20
> 2.31.1
>=20

--
Chuck Lever