Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Anna Schumaker <schumaker.anna@gmail.com>
CC:     Steve Dickson <steved@redhat.com>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        Anna Schumaker <Anna.Schumaker@Netapp.com>
Subject: Re: [PATCH v5 0/9]  Add a tool for using the new sysfs files
Thread-Topic: [PATCH v5 0/9]  Add a tool for using the new sysfs files
Thread-Index: AQHXzCqUh5X9K2vCzkGvU1ZDUvreSqvuxGsA
Date:   Mon, 1 Nov 2021 14:40:12 +0000
Message-ID: <567882BB-751A-4E17-A84E-19A81E1DD6FE@oracle.com>
References: <20211028183519.160772-1-Anna.Schumaker@Netapp.com>
In-Reply-To: <20211028183519.160772-1-Anna.Schumaker@Netapp.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xqlbAJHDi9Up6zQcU3bqm4jEktk8ESal6GbUrzaWBoL1Rm3V6Z4DCDo9P6tm?=
 =?us-ascii?Q?oOqEPOnVZKMi++6g7Q9Pm2SXz0HugASmCzxgxNZytHXeMP38TN4gGKrBqfGm?=
 =?us-ascii?Q?2Q/jZ9kuRqL4hqh4K0J9ZX92eJaGhlsF5RjgmUsvB/8JqFHztBABfyW+ccg8?=
 =?us-ascii?Q?lNaZP1AUL0/kmP4X/JpyUw7ms4mIY81aY9ZQ0MatuGc/SFSlYlU0MAjF1CIQ?=
 =?us-ascii?Q?PzKj6sJg0n0T1JAt+dNSEqvSI++FNK5OCDF2QzjCqZEbEmSZXqP7PeV7uFPB?=
 =?us-ascii?Q?PNgIv5WDbSAWalucf8N2M9Eqs/GqWAHxf4yIiKq6RnSMX0KTPZScq98jROJE?=
 =?us-ascii?Q?IkV7a1iYsubcjOrfmuD7JHIdOWwMnkKSnElyKK2cElxnrePVoF6FCjoRNmr1?=
 =?us-ascii?Q?YMlC8rsr+K+tW5w00iuwUKUQnwZ4YA7xvFDaY3G2hFZTnYLW8RPHgMm02qND?=
 =?us-ascii?Q?tovWPYDZ0dvBMAhjSFeaLmx2X6qOFv7eokgaq4n9zik3F3SesPdQ5DbhCWZr?=
 =?us-ascii?Q?uvSuT0/d/zYDRjkb9KOQzmPC7yROTpVnnvPjjERTZtsY7J15nqnOH0OqodPS?=
 =?us-ascii?Q?6CSu6HRs0G6UdyUuxsuPY3yiYgf2Uz2cczMgIdj9w66hEOzd0YUGvA9Up0dj?=
 =?us-ascii?Q?rnIYP5Qz8I80NAputyLgM4AsyeScrtYJwFYqAT/6lu5iL60qcBkzjuygi7p/?=
 =?us-ascii?Q?XVXcX9vmUlCP+nHzbaIZhPP7exGz9szHIUtOr5f4B5L5yUJzs2wUQeWmT9Ki?=
 =?us-ascii?Q?UVoN9etKsS5VUkFpb6eeWgjF5Cs56LS0BIRcxjeK63dHRZO6fX9EVAEM9sVS?=
 =?us-ascii?Q?H27ilGGxdQOPAskl6Jll9A4+WIAuz3YEjV5afonf8UyLTe6Rz4YOAS7yQxbU?=
 =?us-ascii?Q?KdWEWFzHA+RrMaaOsDfQE/ArdY3vALwcotVx4a3YJjbRBZDX92/ncbw1FIqB?=
 =?us-ascii?Q?CY9qJoAxmc6UOLpmQORo1PfJ/nTi1jPI6q9No/v/JsWPtshe7xLRuJsSXPEo?=
 =?us-ascii?Q?YNIwMi+F59OWw6AkexDZQ97kA2NkMoUagFXjSqt6nTImOVLRplH0Nb1SAbOR?=
 =?us-ascii?Q?ilUZx8AxOEspHKa0mU820adaertxY5pRjToVjlUhafS+t7rfO84LZIOuQLe4?=
 =?us-ascii?Q?KTp3e3tRNaEwDYv5RafJpqYTELJ0r9XRizw0KCf+c13HKR4PxWkeTCwmUsGC?=
 =?us-ascii?Q?b2BWw6oiKc/Gd7vaanHFVyxdEH3VDIdyFWnlDJd0e3R9sWtNfFOjgHHyzUkx?=
 =?us-ascii?Q?Be0GAXfZ2E6VtMfhUdgs+NbTkpP3M4958NaQy32+s7JK/8E561G5TkvB2JOb?=
 =?us-ascii?Q?z2RnYEYVkTbGnjgN6YCUoQkjWFSjIHC+SBgD19I28dRp/4VfzQJb71ET3NjU?=
 =?us-ascii?Q?wuVrq8WyrtinmK+BxDkZY14pB9/KOyo0qY4qk04E1Lkn7DaWPeM2TpzI3uoY?=
 =?us-ascii?Q?lBEwtGgQqfueQzEXA9Y2Ea3W3XkPmemLLRET9COtIO6ioznC/SeXux5eVtAl?=
 =?us-ascii?Q?z2uMLdYh0qMmHgXabT1SbBo+X2lJikF2/mX4XjsC3PwwXe78pIhjK6EQOpa3?=
 =?us-ascii?Q?wCx7nQu5K62mt2Pf79jCMq0eutD/WJN6zNlBVZnChCm1orxG4b5f9CtAMV4V?=
 =?us-ascii?Q?aHAVYiaRPvir6RX9Ckrk6wg=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <D3C6EF50AA27254DA0013B0068F86715@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4688.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7e452cf8-5f13-46c4-2b21-08d99d458339
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Nov 2021 14:40:12.8884
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: pcFa8LZw0HSZ1+Yu/SsCI6KWFfq0qE2fYCYVCDaaTnmF8USkpDCjEZJDMLbj/vkXw5o1OxW6ZLxx9MU/+Sfc5g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB3859
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10154 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0 malwarescore=0
 mlxscore=0 suspectscore=0 mlxlogscore=999 adultscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111010084
X-Proofpoint-GUID: c8-Ox2Yny-lQ6xkmVixrWDGf9Zfvey2P
X-Proofpoint-ORIG-GUID: c8-Ox2Yny-lQ6xkmVixrWDGf9Zfvey2P
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Oct 28, 2021, at 2:35 PM, schumaker.anna@gmail.com wrote:
>=20
> From: Anna Schumaker <Anna.Schumaker@Netapp.com>
>=20
> These patches implement a tool that can be used to read and write the
> sysfs files, with subcommands!
>=20
> The following subcommands are implemented:
> 	rpcctl client
> 	rpcctl switch
> 	rpcctl switch set
> 	rpcctl xprt
> 	rpcctl xprt set
>=20
> So you can print out information about every switch with:
> 	anna@client ~ % rpcctl switch
> 	switch 0: xprts 1, active 1, queue 0
> 		xprt 0: local, /var/run/gssproxy.sock [main]
> 	switch 1: xprts 1, active 1, queue 0
> 		xprt 1: local, /var/run/rpcbind.sock [main]
> 	switch 2: xprts 1, active 1, queue 0
> 		xprt 2: tcp, 192.168.111.1 [main]
> 	switch 3: xprts 4, active 4, queue 0
> 		xprt 3: tcp, 192.168.111.188 [main]
> 		xprt 4: tcp, 192.168.111.188
> 		xprt 5: tcp, 192.168.111.188
> 		xprt 6: tcp, 192.168.111.188
>=20
> And information about each xprt:
> 	anna@client ~ % rpcctl xprt
> 	xprt 0: local, /var/run/gssproxy.sock, port 0, state <CONNECTED,BOUND>, =
main
> 		Source: (einval), port 0, Requests: 2
> 		Congestion: cur 0, win 256, Slots: min 2, max 65536
> 		Queues: binding 0, sending 0, pending 0, backlog 0, tasks 0
> 	xprt 1: local, /var/run/rpcbind.sock, port 0, state <CONNECTED,BOUND>, m=
ain
> 		Source: (einval), port 0, Requests: 2
> 		Congestion: cur 0, win 256, Slots: min 2, max 65536
> 		Queues: binding 0, sending 0, pending 0, backlog 0, tasks 0
> 	xprt 2: tcp, 192.168.111.1, port 2049, state <CONNECTED,BOUND>, main
> 		Source: 192.168.111.222, port 959, Requests: 2
> 		Congestion: cur 0, win 256, Slots: min 2, max 65536
> 		Queues: binding 0, sending 0, pending 0, backlog 0, tasks 0
> 	xprt 3: tcp, 192.168.111.188, port 2049, state <CONNECTED,BOUND>, main
> 		Source: 192.168.111.222, port 921, Requests: 2
> 		Congestion: cur 0, win 256, Slots: min 2, max 65536
> 		Queues: binding 0, sending 0, pending 0, backlog 0, tasks 0
> 	xprt 4: tcp, 192.168.111.188, port 2049, state <CONNECTED,BOUND>
> 		Source: 192.168.111.222, port 726, Requests: 2
> 		Congestion: cur 0, win 256, Slots: min 2, max 65536
> 		Queues: binding 0, sending 0, pending 0, backlog 0, tasks 0
> 	xprt 5: tcp, 192.168.111.188, port 2049, state <CONNECTED,BOUND>
> 		Source: 192.168.111.222, port 671, Requests: 2
> 		Congestion: cur 0, win 256, Slots: min 2, max 65536
> 		Queues: binding 0, sending 0, pending 0, backlog 0, tasks 0
> 	xprt 6: tcp, 192.168.111.188, port 2049, state <CONNECTED,BOUND>
> 		Source: 192.168.111.222, port 934, Requests: 2
> 		Congestion: cur 0, win 256, Slots: min 2, max 65536
> 		Queues: binding 0, sending 0, pending 0, backlog 0, tasks 0
>=20
> You can use the `set` subcommand to change the dstaddr of individual xprt=
s:
> 	anna@client ~ % sudo rpcctl xprt --id 4=20
> 	xprt 4: tcp, 192.168.111.188, port 2049, state <CONNECTED,BOUND>
> 		Source: 192.168.111.222, port 726, Requests: 2
> 		Congestion: cur 0, win 256, Slots: min 2, max 65536
> 		Queues: binding 0, sending 0, pending 0, backlog 0, tasks 0
> 	anna@client ~ % sudo rpcctl xprt set --id 4 --dstaddr server2.nowheycrea=
mery.com
> 	xprt 4: tcp, 192.168.111.186, port 2049, state <CONNECTED,BOUND>
> 		Source: 192.168.111.222, port 726, Requests: 2
> 		Congestion: cur 0, win 256, Slots: min 2, max 65536
> 		Queues: binding 0, sending 0, pending 0, backlog 0, tasks 0
>=20
> Or for changing the dstaddr of all xprts attached to a switch:
> 	anna@client % rpcctl switch --id 3
> 	switch 3: xprts 4, active 4, queue 0
> 		xprt 3: tcp, 192.168.111.188 [main]
> 		xprt 4: tcp, 192.168.111.188
> 		xprt 5: tcp, 192.168.111.188
> 		xprt 6: tcp, 192.168.111.188
> 	anna@client % sudo rpcctl switch set --id 4 --dstaddr server2.nowheycrea=
mery.vm
> 	switch 3: xprts 4, active 4, queue 0
> 		xprt 2: tcp, 192.168.111.186 [main]
> 		xprt 3: tcp, 192.168.111.186
> 		xprt 5: tcp, 192.168.111.186
> 		xprt 6: tcp, 192.168.111.186
>=20
> Changes in v5:
> - Rename from 'rpcctl' to 'rpcctl'
> - Rename subcommands 'xprt-switch" to 'switch' and 'rpc-client' to 'clien=
t'
> - Clean up how the displayed strings are generated
> - Handle kernels that don't yet have the srcaddr patch
>=20
> Thoughts?

LGTM!


> Anna
>=20
>=20
> Anna Schumaker (9):
>  rpcctl: Add a rpcctl.py tool
>  rpcctl: Add a command for printing xprt switch information
>  rpcctl: Add a command for printing individual xprts
>  rpcctl: Add a command for printing rpc client information
>  rpcctl: Add a command for changing xprt dstaddr
>  rpcctl: Add a command for changing xprt switch dstaddrs
>  rpcctl: Add a command for changing xprt state
>  rpcctl: Add a man page
>  rpcctl: Add installation to the Makefile
>=20
> .gitignore               |   2 +
> configure.ac             |   1 +
> tools/Makefile.am        |   2 +-
> tools/rpcctl/Makefile.am |  20 ++++++++
> tools/rpcctl/client.py   |  27 +++++++++++
> tools/rpcctl/rpcctl      |   5 ++
> tools/rpcctl/rpcctl.man  |  88 ++++++++++++++++++++++++++++++++++
> tools/rpcctl/rpcctl.py   |  23 +++++++++
> tools/rpcctl/switch.py   |  51 ++++++++++++++++++++
> tools/rpcctl/sysfs.py    |  42 ++++++++++++++++
> tools/rpcctl/xprt.py     | 101 +++++++++++++++++++++++++++++++++++++++
> 11 files changed, 361 insertions(+), 1 deletion(-)
> create mode 100644 tools/rpcctl/Makefile.am
> create mode 100644 tools/rpcctl/client.py
> create mode 100644 tools/rpcctl/rpcctl
> create mode 100644 tools/rpcctl/rpcctl.man
> create mode 100755 tools/rpcctl/rpcctl.py
> create mode 100644 tools/rpcctl/switch.py
> create mode 100644 tools/rpcctl/sysfs.py
> create mode 100644 tools/rpcctl/xprt.py
>=20
> --=20
> 2.33.1
>=20

--
Chuck Lever