Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 5 Nov 2021 09:54:21 -0700
From:   Nathan Chancellor <nathan@kernel.org>
To:     trondmy@kernel.org
Cc:     linux-nfs@vger.kernel.org
Subject: Re: [PATCH] NFS: Don't trace an uninitialised value
Message-ID: <YYVhvS5q3GyuaBAL@archlinux-ax161>
References: <20211105163852.214665-1-trondmy@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211105163852.214665-1-trondmy@kernel.org>
Precedence: bulk

On Fri, Nov 05, 2021 at 12:38:52PM -0400, trondmy@kernel.org wrote:
> From: Trond Myklebust <trond.myklebust@hammerspace.com>
> 
> If fhandle is NULL or fattr is NULL, then 'error' is uninitialised.
> 
> Reported-by: Nathan Chancellor <nathan@kernel.org>
> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>

Reviewed-by: Nathan Chancellor <nathan@kernel.org>

> ---
>  fs/nfs/dir.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
> index 8de99f426183..731d31015b6a 100644
> --- a/fs/nfs/dir.c
> +++ b/fs/nfs/dir.c
> @@ -1798,7 +1798,7 @@ struct dentry *nfs_lookup(struct inode *dir, struct dentry * dentry, unsigned in
>  	}
>  	nfs_set_verifier(dentry, dir_verifier);
>  out:
> -	trace_nfs_lookup_exit(dir, dentry, flags, error);
> +	trace_nfs_lookup_exit(dir, dentry, flags, PTR_ERR_OR_ZERO(res));
>  	nfs_free_fattr(fattr);
>  	nfs_free_fhandle(fhandle);
>  	return res;
> -- 
> 2.33.1
>