MIME-Version: 1.0
References: <163278643081.17728.10586733395858659759.stgit@noble.brown>
 <163709576284.13692.2252149084412844753@noble.neil.brown.name> <1b6b267598c8fcf5f50b6a118d88cf7ea938d076.camel@hammerspace.com>
In-Reply-To: <1b6b267598c8fcf5f50b6a118d88cf7ea938d076.camel@hammerspace.com>
From:   Anna Schumaker <anna.schumaker@netapp.com>
Date:   Tue, 16 Nov 2021 16:35:31 -0500
Message-ID: <CAFX2Jfk78tjhoZ1G-APdvqQW4es-odNL-iuDBR5fDO6+1hgaQQ@mail.gmail.com>
Subject: Re: [PATCH 0/3] Don't store cred in nfs_access_entry
To:     Trond Myklebust <trondmy@hammerspace.com>
Cc:     "neilb@suse.de" <neilb@suse.de>,
        "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Nov 16, 2021 at 3:58 PM Trond Myklebust <trondmy@hammerspace.com> wrote:
>
> On Wed, 2021-11-17 at 07:49 +1100, NeilBrown wrote:
> >
> > Hi Trond/Anna,
> >  have you had a chance to look at these patches?
> >
>
> Oh crap... I did see those patches, and intended to pick them up for
> this last merge window, but somehow forgot to move them into my
> 'testing' branch.
>
> Anna, can you please queue them up for the next merge window?

Sure! I have them applied to my private testing branch now. I'll push
them out to a public linux-next sometime in the next few weeks.

Anna
>
> Apologies
>   Trond
>
> > Thanks,
> > NeilBrown
> >
> > On Tue, 28 Sep 2021, NeilBrown wrote:
> > > It turns out that storing a counted ref to 'struct cred' in
> > > nfs_access_entry wasn't a good choice.
> > > 'struct cred' contains counted references to 'struct key', and
> > > users
> > > have a quota on how many keys they can have.  Keeping a cred in a
> > > cache
> > > imposes on that quota.
> > >
> > > The nfs access cache can keep a large number of entries, and keep
> > > them
> > > indefinitely.  This can cause a user to go over-quota.
> > >
> > > This series removes the 'struct cred *' from nfs_access_entry and
> > > instead stores the uid, gid, and a pointer to the group info.
> > > This makes the nfs_access_entry 64 bits larger.
> > >
> > > Thanks,
> > > NeilBrown
> > >
> > > ---
> > >
> > > NeilBrown (3):
> > >       NFS: change nfs_access_get_cached to only report the mask
> > >       NFS: pass cred explicitly for access tests
> > >       NFS: don't store 'struct cred *' in struct nfs_access_entry
> > >
> > >
> > >  fs/nfs/dir.c            | 63 ++++++++++++++++++++++++++++++++++---
> > > ----
> > >  fs/nfs/nfs3proc.c       |  5 ++--
> > >  fs/nfs/nfs4proc.c       | 13 +++++----
> > >  include/linux/nfs_fs.h  |  6 ++--
> > >  include/linux/nfs_xdr.h |  2 +-
> > >  5 files changed, 67 insertions(+), 22 deletions(-)
> > >
> > > --
> > > Signature
> > >
> > >
>
> --
> Trond Myklebust
> Linux NFS client maintainer, Hammerspace
> trond.myklebust@hammerspace.com
>
>