Message-ID: <33c8ea5a-4187-a9fa-d507-a2dcec06416c@oracle.com>
Date:   Tue, 16 Nov 2021 15:06:32 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.0
Subject: Re: [PATCH RFC v5 0/2] nfsd: Initial implementation of NFSv4
 Courteous Server
Content-Language: en-US
From:   dai.ngo@oracle.com
To:     "J. Bruce Fields" <bfields@fieldses.org>
Cc:     chuck.lever@oracle.com, linux-nfs@vger.kernel.org,
        linux-fsdevel@vger.kernel.org
References: <20210929005641.60861-1-dai.ngo@oracle.com>
 <20211001205327.GN959@fieldses.org>
 <a6c9ba13-43d7-4ea9-e05d-f454c2c9f4c2@oracle.com>
In-Reply-To: <a6c9ba13-43d7-4ea9-e05d-f454c2c9f4c2@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c0FKUm1kNExmZzM0d2luMlljd3g2eUl6NENQc3ZXckkxYW4zV2cvSk0zdjBw?=
 =?utf-8?B?TU0vSFVaWVNvbkxDT044UUF5MytEYUlsdmtrajFFS3l4bGp5MEtHRFQ0ZW9z?=
 =?utf-8?B?cEpGdExSalR0Tkdpdm9Oa0I1NFdFZkFaL2dUOWc0WkorcS9rWTlCVDZGdkh0?=
 =?utf-8?B?elZGRFlxS3VSZ1QrOTA4bXZObG9mUi9jc0NrbUQ2UEIvU3pJZ2RCWjZXU0Er?=
 =?utf-8?B?cnFyU2VxWGd0WG9mWnVGRHdaNlQyaEpUZ21nMXVLTzliOUdrK3JMcXFQdjl4?=
 =?utf-8?B?SHNCajVHdW9mVnRKZEF3U1dnS1p6aHZWaWZEQjlsUlZ2L1pDV2o0MDJGWCts?=
 =?utf-8?B?ZkJuRU1zWlRPcGIzN2JEYUU5ZmtHOFM2endGOG8zU1VGOW5oZGRwbGQxOUZE?=
 =?utf-8?B?dGxGNVVmWWRDTGpnSGREdHB3d3lMeGsvUGkwVGdvTHJUbkNDQW1YalFqWENx?=
 =?utf-8?B?L3JDWFVZOWlmRXNrcDk0aFNrR3R1cVNxdTkxbzBubzlsOUlZdFljaEF4WjlV?=
 =?utf-8?B?cGRnVXE1T3FGMkRXQ3hZK0lXNXRYOGsrYzFOb3ZSN0xCb1lkc1dPYlp5SUtF?=
 =?utf-8?B?TlRFb0txTnFLM1ZNUEo1ODZBU1R0bGk1b2tFOWc3MGc2RGRBZ2hldDhMb2RQ?=
 =?utf-8?B?Q0dha1UzTXV4UW80UXhLWGVWSUtuaXF0c05GdW94WCtUMnVUTGpqbVBmVm9l?=
 =?utf-8?B?KzlBS2I1N3c0aEtPR0JWSkpTWXlORnd1eUE2TGRreWNBclkyY3V6ZTBKd25R?=
 =?utf-8?B?Y0xKY3YwdTRuYitoekMzRHVrdWFqc0Yzb3NEVzBLREc1WlBZUHNvWjR6cWpp?=
 =?utf-8?B?T0p2ekpsbnJYdU8yTDRhQlcxWDVXSEpqWGx4N2hvUnlMVFpzc0FjNXp2UFhH?=
 =?utf-8?B?R2lGQXNJbnhQeFoyakNUSFVZYVRmZDVLWkdiYTJHRWtwbUQ5YjBvN0FrdTAv?=
 =?utf-8?B?ZWM3UXZHZVZ5Q1RmY3dBK2pXV3F0blFxYUwrRUh0Z1h6RWhMZStsY0NSVnhJ?=
 =?utf-8?B?OXFicjM1bEhkN01FbEFHeEZyaE13YXFUTFdvK25WVWt4bkdSL2ZOcUt6VGRj?=
 =?utf-8?B?aXVUVUtHUU9NUlpGQnNGWVVBb1ZkSEJQd1p2NzNROStyRmpjeC8xeWthcndJ?=
 =?utf-8?B?Z2NUNGpGSDVtWkFKZ0hvNXJOVU13dnRjSW41NUxJZHlrbzFqbXFudTgySm81?=
 =?utf-8?B?eGw2cjZmOUNNaDYzVlBud3pzRG5BT0NDQUtvR0tMWk5LTWJiOWt6TTdSaUVG?=
 =?utf-8?B?ZHRUSUVyd3dXdjM4eTVuTVllOG83SklGbEhWTy9zaEVkcE1yVjlPOEJaR3F6?=
 =?utf-8?B?cFZLTHR4VFJuOHA4TnNsdWRLKzExeEFLcm5hMHJORWhWaGNEVWtJM2NwNHpL?=
 =?utf-8?B?bTA4OTRuKy9kNm5WMHFWb3o5ejFFK3JFUEoycHd5emx4am9JT1g1UmF2OFFR?=
 =?utf-8?B?WGtReUszZEFJM2RVUm1JUjVUdDhaV2lZazQxbTN4KytnUEl0bDByd09paUta?=
 =?utf-8?B?ajJCTEN4RkN1SDdPUXloYXJ5STl1Y2VWQ3BLUkM1dlRzaHVMYjZnRGtsSFVa?=
 =?utf-8?B?ZkphZkI5ZFdRdUpRdmFQR3gzMlQ2dUc2SUZ1cHE0ZmdVekVvcEVkUVB5MFJW?=
 =?utf-8?B?bmRHZkpkZ0lTbkNpRkdkQmplWWdWVG5sQ1J5RHFBVFBKbkkvdE96R3U5MTdL?=
 =?utf-8?B?ZDJDV0czdTZleStGU2VMZkoxV2dLWnM1YWtLSzFJK2dXV29KNnltZEROaHV5?=
 =?utf-8?B?bUw3QUtRK1U4UlZsbFBZNkh3c1ZoMEZQWXNPalc4dE1KVlNaK0NhSlBmakhv?=
 =?utf-8?B?aDVJUjN1VFJGb1Yyb2ZDRG9xRVlHeUZFV3JpdGhQSVR3SzlKVmdTdS9zYVFi?=
 =?utf-8?B?NWMrc05FeHBsYTR1T0tpa3ZQMzMxeHNjNFpqWVFNMEw0VVN1RmpYVGluSk9U?=
 =?utf-8?B?ZFJWbHhFOTVpN2VIa3U0QW1WZjlaZithZHRqcmxSQnZWa090bTJLdHVVUllh?=
 =?utf-8?B?V0lad21CSXYvd21JRXVyVHcySEZ1Z2F3cjVYcmdvanAvcFdJenQ5L3lvdy9S?=
 =?utf-8?B?cDF5TFFpejRtVkpLdjVsSkpUTGtENWxxVE5iZXdCWWlDeTA0bHN4d0hsZHhM?=
 =?utf-8?B?MnVFM0NZYVdIOGdlaWNycmVBNi94MGpqL0U5aXVtek8zdldsRWVIZ2FBbUxa?=
 =?utf-8?Q?fROMx0997Z9fWXDu4Bo8ghU=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4239c8cf-f149-4c88-231d-08d9a955bcd1
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4257.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2021 23:06:35.5987
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: doDn4WyQSt3v/+D+KNcMO87h6CIY02Y8C3qCJDzVocq/AfU1nKQ6BJftB3yCdT8uQMcQTWViqPJuMU9+BzT2Lg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3222
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10170 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 mlxscore=0
 spamscore=0 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111160101
X-Proofpoint-ORIG-GUID: 8yYIHU1WyQpW34IG74mwSfMH_YQi3BqJ
X-Proofpoint-GUID: 8yYIHU1WyQpW34IG74mwSfMH_YQi3BqJ
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

Hi Bruce,

Just a reminder that this patch is still waiting for your review.

Thanks,
-Dai

On 10/1/21 2:41 PM, dai.ngo@oracle.com wrote:
>
> On 10/1/21 1:53 PM, J. Bruce Fields wrote:
>> On Tue, Sep 28, 2021 at 08:56:39PM -0400, Dai Ngo wrote:
>>> Hi Bruce,
>>>
>>> This series of patches implement the NFSv4 Courteous Server.
>> Apologies, I keep meaning to get back to this and haven't yet.
>>
>> I do notice I'm seeing a timeout on pynfs 4.0 test OPEN18.
>
> It's weird, this test passes on my system:
>
>
> [root@nfsvmf25 nfs4.0]# ./testserver.py $server --rundeps -v OPEN18
> INIT     st_setclientid.testValid : RUNNING
> INIT     st_setclientid.testValid : PASS
> MKFILE   st_open.testOpen : RUNNING
> MKFILE   st_open.testOpen : PASS
> OPEN18   st_open.testShareConflict1 : RUNNING
> OPEN18   st_open.testShareConflict1 : PASS
> **************************************************
> INIT     st_setclientid.testValid : PASS
> OPEN18   st_open.testShareConflict1 : PASS
> MKFILE   st_open.testOpen : PASS
> **************************************************
> Command line asked for 3 of 673 tests
> Of those: 0 Skipped, 0 Failed, 0 Warned, 3 Passed
> [root@nfsvmf25 nfs4.0]#
>
> Do you have a network trace?
>
> -Dai
>
>>
>> --b.
>>
>>> A server which does not immediately expunge the state on lease 
>>> expiration
>>> is known as a Courteous Server.  A Courteous Server continues to 
>>> recognize
>>> previously generated state tokens as valid until conflict arises 
>>> between
>>> the expired state and the requests from another client, or the server
>>> reboots.
>>>
>>> The v2 patch includes the following:
>>>
>>> . add new callback, lm_expire_lock, to lock_manager_operations to
>>>    allow the lock manager to take appropriate action with conflict 
>>> lock.
>>>
>>> . handle conflicts of NFSv4 locks with NFSv3/NLM and local locks.
>>>
>>> . expire courtesy client after 24hr if client has not reconnected.
>>>
>>> . do not allow expired client to become courtesy client if there are
>>>    waiters for client's locks.
>>>
>>> . modify client_info_show to show courtesy client and seconds from
>>>    last renew.
>>>
>>> . fix a problem with NFSv4.1 server where the it keeps returning
>>>    SEQ4_STATUS_CB_PATH_DOWN in the successful SEQUENCE reply, after
>>>    the courtesy client re-connects, causing the client to keep sending
>>>    BCTS requests to server.
>>>
>>> The v3 patch includes the following:
>>>
>>> . modified posix_test_lock to check and resolve conflict locks
>>>    to handle NLM TEST and NFSv4 LOCKT requests.
>>>
>>> . separate out fix for back channel stuck in SEQ4_STATUS_CB_PATH_DOWN.
>>>
>>> The v4 patch includes:
>>>
>>> . rework nfsd_check_courtesy to avoid dead lock of fl_lock and 
>>> client_lock
>>>    by asking the laudromat thread to destroy the courtesy client.
>>>
>>> . handle NFSv4 share reservation conflicts with courtesy client. This
>>>    includes conflicts between access mode and deny mode and vice versa.
>>>
>>> . drop the patch for back channel stuck in SEQ4_STATUS_CB_PATH_DOWN.
>>>
>>> The v5 patch includes:
>>>
>>> . fix recursive locking of file_rwsem from posix_lock_file.
>>>
>>> . retest with LOCKDEP enabled.
>>>
>>> NOTE: I will submit pynfs tests for courteous server including tests
>>> for share reservation conflicts in a separate patch.
>>>