Message-ID: <908ded64-6412-66d3-6ad5-429700610660@oracle.com>
Date:   Wed, 17 Nov 2021 13:46:02 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.0
Subject: Re: [PATCH RFC v5 0/2] nfsd: Initial implementation of NFSv4
 Courteous Server
Content-Language: en-US
From:   dai.ngo@oracle.com
To:     "J. Bruce Fields" <bfields@fieldses.org>
Cc:     chuck.lever@oracle.com, linux-nfs@vger.kernel.org,
        linux-fsdevel@vger.kernel.org
References: <20210929005641.60861-1-dai.ngo@oracle.com>
 <20211001205327.GN959@fieldses.org>
 <a6c9ba13-43d7-4ea9-e05d-f454c2c9f4c2@oracle.com>
 <33c8ea5a-4187-a9fa-d507-a2dcec06416c@oracle.com>
 <20211117141433.GB24762@fieldses.org>
 <400143c8-c12a-6224-1b36-3e19f20a7ee4@oracle.com>
In-Reply-To: <400143c8-c12a-6224-1b36-3e19f20a7ee4@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eW5sanNlK1ErN3ZqMlBqNVkvb0tRY3lSTkcrVWFaTU1FVDNFbldMeFBzVEJF?=
 =?utf-8?B?akN4OVdlRnlWTHNmbWpWMWwvYkRNbmlQbTQxWnFWUy9pc3l0Q3FkV1ZrOVg4?=
 =?utf-8?B?SUZPU0NEa1pzNGNjeHF6eWc3dzljMzZrbGQ2dldHdndHQThHTmpPU0t6R3Ny?=
 =?utf-8?B?NDhpcUpjMjhydTBIOEtiN21WeW8zM2h1TzJkMHZHRi9wWkY2eHg0ZTY0YlZN?=
 =?utf-8?B?b05wRWY1QVF6bTBiR3lmeG1mR2N2aUJiRjlnRWtkNkMvY2hkMXk3dGZlUSs3?=
 =?utf-8?B?b0YrMWNBV0JKZmRJZXNXdW9ScTg5MzhUNktiWEp0cnJhcUxEWUthNHY1M2I4?=
 =?utf-8?B?RDZ2Smw0TlVqNW1iaGxjcS8vNTVSUmc0ckY3M0VpaGpEK1owUjVCVy8yQlNJ?=
 =?utf-8?B?ZUdPb1l2dy9XUlZWSTdlOWRaakVxNTFWcjE5czN0L1hEWWgwQW1id0NQSTVm?=
 =?utf-8?B?U3ZqVWRxc3hwMlZJUDdjRElvRXloNFhLV0d0N3Z3ek1uSzNSR1p0UERpQWRO?=
 =?utf-8?B?Wi9qYythZGFBV2lzbjkva3hsMTE5OElONGpSVnFFUFpBZTZwT0ZHSDBIbTdn?=
 =?utf-8?B?K2NWbDZISmdGOHdSUkUzemdWbWNIdkN3R29GcnhCRGV5N0VNWWZ0TkNLZUc2?=
 =?utf-8?B?ZUxJOHFZSGdJYkpJa2JYNmNSN21pWEJiNGdRekE0eVR1ZFB6WUl2VXA5N3hP?=
 =?utf-8?B?QlFyQk9YZTY5Sy9MRmx0ekpqS2Nnd01tQ2NxNzBPVlhiOFd5MjVuS3BEZzFH?=
 =?utf-8?B?WjZRakVFR1BGTG9UOWtMVVJFeTRvQUlLOVZMVm5RdFQwRjZKUzdEVWZNQ2Va?=
 =?utf-8?B?VW0yVE5xdDhiU0FsUXBmbkpwZ2lIZzFsOEhFNFI4UWVUV1dabFNPcXhGcFBs?=
 =?utf-8?B?QloyOHFyNldaaDVpWmttRGNGS2JlKzQ5aWpmbTIwUzdLMDdoZXFzcnJJUTRN?=
 =?utf-8?B?NTJXVGRYdDFXa0JzckhYNnJ0ZnhNZHYzR0tOUE5tVHMzMGk5eDlDcHhVUzZI?=
 =?utf-8?B?c1lKTktSVmxtUW1IL09wb2RyUGxUb1RDSmFNQTVqd1pMOG9yYTd4dlEyY1Jt?=
 =?utf-8?B?eGNSUnBxcGxjL1J5endMeUd3empRUXFIM3dqV2dZRUVOcnVzanE2ZE9ScUt5?=
 =?utf-8?B?dzRCdTltZ2dMcXVXUnlJNlNGVGUxWVg2Y1I5QnFmUVpKYTFaRW9vUlM4Y2dG?=
 =?utf-8?B?ZlZJK0ZJVVJCN1IzOHRmL3UyZWJVQUgzb3lGMVhtYzl0V1V2Vk1kSnJXaGZa?=
 =?utf-8?B?V1pkTDdQYnBSa2NQWEE0aS9pZXFXeWhoeFlOc3RCYWdIckJrbFBmSFJBejNr?=
 =?utf-8?B?U2lpdDdmRVBXWlRMQ1lnMzN6MXlONFpPRjZyUTRmNnk0Mkw3QmdDYU9Vakov?=
 =?utf-8?B?LzYxWWptR2dkS1p1YW55VFhEMkgrMnYzd1dzMUxoaDBxTHA0WjhKQ2tqNktq?=
 =?utf-8?B?VlcwNzVCYjFjcmRZTnUzNzNTWFVaR3dPZ0RVcDcwY1hRRGNkZ080bGpzdm9Y?=
 =?utf-8?B?aHlBT25UaEl3OG1WRCs2ampMMXdNSlFvdUdLMkRrWFRGS2JyTkxjMUhnTkox?=
 =?utf-8?B?MWJoTkpsSzg5SFkweGFQMzh3Y2JRWDBHR3dOZmFOVXFKakxNTG52aXVQK3kw?=
 =?utf-8?B?RTRhbEo4OW5UdnczQkVNWmNSUnFLV1g4VU56UmtEZFNlaWxkZzF5QnRrZVNz?=
 =?utf-8?B?TXRMT3BqUWNwV2phTzFjbmtUdmIwcFZESWJLSzQ3UC9FUmc2QzdoMUgvbEta?=
 =?utf-8?B?UTRRakl1SG42Y3k0TmNzMHU0U3dKZkRvVmlTVjdVd1hDcU9KT0hHVU1kUHl2?=
 =?utf-8?B?U3d1dUN6WlRxZTN6STZmUldYNExFYnRrcnIzWGEzY3doMHgwWjB6VDJlR1BW?=
 =?utf-8?B?MW4vREUwL0Nsdnh1SFF5QXd6TnBwUWFLdXNWZUJEdktWSS9YSHYySTFDV0dF?=
 =?utf-8?B?MklkbjgvS2FUMC9vZHgvdGltaUxraDYrUUxqV1JSNXdtMmI0aTlZMFJ6Qk9F?=
 =?utf-8?B?ay84ZHd2alpDWUhDeFRKcmFOVkw0QWgyekUzMTB2aWNienlFUkdxRC9WTVRV?=
 =?utf-8?B?ZHRKWVZ1Wm9hT09sWWFLYTRmVXRaNTNjejVuQVVWTGx1NGNtRWJ3VXdGc1lJ?=
 =?utf-8?B?M09GR2szcFJyTWt4ODA0TlBYeXVSMWJlR2daM0gvU2FLVUxOeFJNcjM5WEU3?=
 =?utf-8?Q?DMkqEogqMnLZSndlbRglsls=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2bc5de6f-e560-45f3-27db-08d9aa13a843
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4257.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2021 21:46:05.5004
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FTdlFhjb56hwYZ3lkbIS13j1XMo3dXtmNki+rppTgWcveAIXqSuB9mba9DEpue66pJHaNWtGtUH/Xvif6+Uxjg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3335
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10171 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 mlxscore=0
 spamscore=0 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111170098
X-Proofpoint-GUID: 0WERvYGxigI7wwQV72fx_SihwDyIefq2
X-Proofpoint-ORIG-GUID: 0WERvYGxigI7wwQV72fx_SihwDyIefq2
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


On 11/17/21 9:59 AM, dai.ngo@oracle.com wrote:
>
> On 11/17/21 6:14 AM, J. Bruce Fields wrote:
>> On Tue, Nov 16, 2021 at 03:06:32PM -0800, dai.ngo@oracle.com wrote:
>>> Just a reminder that this patch is still waiting for your review.
>> Yeah, I was procrastinating and hoping yo'ud figure out the pynfs
>> failure for me....
>
> Last time I ran 4.0 OPEN18 test by itself and it passed. I will run
> all OPEN tests together with 5.15-rc7 to see if the problem you've
> seen still there.

I ran all tests in nfsv4.1 and nfsv4.0 with courteous and non-courteous
5.15-rc7 server.

Nfs4.1 results are the same for both courteous and non-courteous server:
> Of those: 0 Skipped, 0 Failed, 0 Warned, 169 Passed

Results of nfs4.0 with non-courteous server:
>Of those: 8 Skipped, 1 Failed, 0 Warned, 577 Passed
test failed: LOCK24

Results of nfs4.0 with courteous server:
>Of those: 8 Skipped, 3 Failed, 0 Warned, 575 Passed
tests failed: LOCK24, OPEN18, OPEN30

OPEN18 and OPEN30 test pass if each is run by itself.
I will look into this problem.

-Dai

>
> -Dai
>
>>   I'll see if I can get some time today.--b.
>>
>>> Thanks,
>>> -Dai
>>>
>>> On 10/1/21 2:41 PM, dai.ngo@oracle.com wrote:
>>>> On 10/1/21 1:53 PM, J. Bruce Fields wrote:
>>>>> On Tue, Sep 28, 2021 at 08:56:39PM -0400, Dai Ngo wrote:
>>>>>> Hi Bruce,
>>>>>>
>>>>>> This series of patches implement the NFSv4 Courteous Server.
>>>>> Apologies, I keep meaning to get back to this and haven't yet.
>>>>>
>>>>> I do notice I'm seeing a timeout on pynfs 4.0 test OPEN18.
>>>> It's weird, this test passes on my system:
>>>>
>>>>
>>>> [root@nfsvmf25 nfs4.0]# ./testserver.py $server --rundeps -v OPEN18
>>>> INIT     st_setclientid.testValid : RUNNING
>>>> INIT     st_setclientid.testValid : PASS
>>>> MKFILE   st_open.testOpen : RUNNING
>>>> MKFILE   st_open.testOpen : PASS
>>>> OPEN18   st_open.testShareConflict1 : RUNNING
>>>> OPEN18   st_open.testShareConflict1 : PASS
>>>> **************************************************
>>>> INIT     st_setclientid.testValid : PASS
>>>> OPEN18   st_open.testShareConflict1 : PASS
>>>> MKFILE   st_open.testOpen : PASS
>>>> **************************************************
>>>> Command line asked for 3 of 673 tests
>>>> Of those: 0 Skipped, 0 Failed, 0 Warned, 3 Passed
>>>> [root@nfsvmf25 nfs4.0]#
>>>>
>>>> Do you have a network trace?
>>>>
>>>> -Dai
>>>>
>>>>> --b.
>>>>>
>>>>>> A server which does not immediately expunge the state on lease
>>>>>> expiration
>>>>>> is known as a Courteous Server.  A Courteous Server continues
>>>>>> to recognize
>>>>>> previously generated state tokens as valid until conflict
>>>>>> arises between
>>>>>> the expired state and the requests from another client, or the 
>>>>>> server
>>>>>> reboots.
>>>>>>
>>>>>> The v2 patch includes the following:
>>>>>>
>>>>>> . add new callback, lm_expire_lock, to lock_manager_operations to
>>>>>>     allow the lock manager to take appropriate action with
>>>>>> conflict lock.
>>>>>>
>>>>>> . handle conflicts of NFSv4 locks with NFSv3/NLM and local locks.
>>>>>>
>>>>>> . expire courtesy client after 24hr if client has not reconnected.
>>>>>>
>>>>>> . do not allow expired client to become courtesy client if there are
>>>>>>     waiters for client's locks.
>>>>>>
>>>>>> . modify client_info_show to show courtesy client and seconds from
>>>>>>     last renew.
>>>>>>
>>>>>> . fix a problem with NFSv4.1 server where the it keeps returning
>>>>>>     SEQ4_STATUS_CB_PATH_DOWN in the successful SEQUENCE reply, after
>>>>>>     the courtesy client re-connects, causing the client to keep 
>>>>>> sending
>>>>>>     BCTS requests to server.
>>>>>>
>>>>>> The v3 patch includes the following:
>>>>>>
>>>>>> . modified posix_test_lock to check and resolve conflict locks
>>>>>>     to handle NLM TEST and NFSv4 LOCKT requests.
>>>>>>
>>>>>> . separate out fix for back channel stuck in 
>>>>>> SEQ4_STATUS_CB_PATH_DOWN.
>>>>>>
>>>>>> The v4 patch includes:
>>>>>>
>>>>>> . rework nfsd_check_courtesy to avoid dead lock of fl_lock and
>>>>>> client_lock
>>>>>>     by asking the laudromat thread to destroy the courtesy client.
>>>>>>
>>>>>> . handle NFSv4 share reservation conflicts with courtesy client. 
>>>>>> This
>>>>>>     includes conflicts between access mode and deny mode and vice 
>>>>>> versa.
>>>>>>
>>>>>> . drop the patch for back channel stuck in SEQ4_STATUS_CB_PATH_DOWN.
>>>>>>
>>>>>> The v5 patch includes:
>>>>>>
>>>>>> . fix recursive locking of file_rwsem from posix_lock_file.
>>>>>>
>>>>>> . retest with LOCKDEP enabled.
>>>>>>
>>>>>> NOTE: I will submit pynfs tests for courteous server including tests
>>>>>> for share reservation conflicts in a separate patch.
>>>>>>