From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Dave Wysochanski <dwysocha@redhat.com>,
        Trond Myklebust <trond.myklebust@hammerspace.com>,
        Anna Schumaker <anna.schumaker@netapp.com>
CC:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        "linux-cachefs@redhat.com" <linux-cachefs@redhat.com>
Subject: Re: [PATCH 0/7] Cleanups for NFS fscache and convert from dfprintk to
 trace events
Thread-Topic: [PATCH 0/7] Cleanups for NFS fscache and convert from dfprintk
 to trace events
Thread-Index: AQHX3ADv2oWEXSsDwkedfJbhYLskMqwJejAA
Date:   Thu, 18 Nov 2021 16:26:55 +0000
Message-ID: <A26894CC-ECE3-4168-8038-1D05122F4A0F@oracle.com>
References: <1637187438-18858-1-git-send-email-dwysocha@redhat.com>
In-Reply-To: <1637187438-18858-1-git-send-email-dwysocha@redhat.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?N0dO/EGrlJJSinsjwuAUYfiy1XBL/Tdo0GrptlAQaK4oIgHfMKcUQq8Ui1c9?=
 =?us-ascii?Q?uUrRYmLg6qdbCGrknhN+NJR0j4/jPhDS8X5vWHjV+cxLQuhdUbWhqX0fxGi6?=
 =?us-ascii?Q?tjbNfnhyHACmnN6OguS/5HxGwSbqvqJfwNwXDF7b4ZV1eXXFirRrTiUfP/X9?=
 =?us-ascii?Q?E4kxKO+nPIlrjfDyXySdWVGtDB/kimYxWG+8vj9te53c5w+KJlj1/K7u72em?=
 =?us-ascii?Q?JsiZU3QNmay02MOzyrck4i0AoxYWQ/iBxQBsKLXIEGYlUsDZKlHRIMhrHcuu?=
 =?us-ascii?Q?aIILDsiuYVsOxXnHZXRV24wB0f6IMdAZjqKM4nwSOnCXrNA/JRCMj2a1hfvu?=
 =?us-ascii?Q?yaqoejrR5mzIlNKXWlwnd/6uq2XDcT/E2bQm+KhCaOSnpDhbNXOsaV7vwYI0?=
 =?us-ascii?Q?Byk6aXck23753ipRdiYj03voAebEYsLJNOWbq61mxcXElyWx2zLkENluGcwy?=
 =?us-ascii?Q?zzKGth8ETLWenotuAezh9NL+0s/hy8LrDbG0HoxoI+UUISddFsx7mHp+KxY8?=
 =?us-ascii?Q?c5EXzorYpTv10npKMgx8Avnm+jAKxoN1a9UJcCwtPBb+X55m3SxKFyAFFpiC?=
 =?us-ascii?Q?AjwHXwo3BdHUBTSDVpJsICiMjqG+wnPapx/87s2mjtksyNwXuSoKKCuzAQkq?=
 =?us-ascii?Q?LJdAM3e5APyWOJ3TYCrjh5mfYksWNqOe0l1g/1f1HiRtBVrG5QhReqcK6ey4?=
 =?us-ascii?Q?NdJNVLO/wP5zaO3ajX69kTudYcgS/omaKmwD9lKK4NKnN0MqZwK5hRfsmcU+?=
 =?us-ascii?Q?gP73LcU09+6brtRlsjcsT9GP8NH17beFADrtTZwZz+cNamz/iO7Z1qRR8zIo?=
 =?us-ascii?Q?stsZBTxKwo4X2vGlmxLGg6g2+F+OiXA+BoR8Wld4+yd0M7mB8IhUVzkZCSVr?=
 =?us-ascii?Q?1Mn7M1HuPF9hx69C8Eege4pW5Di4scZ87IJSLr6ATott/wgzHLHSfZlyyVz5?=
 =?us-ascii?Q?cUdu+1RL5MdR7BH2HjEA3Ttwywupmuy32PaaeJNXG/Ls35XQ+dySFTvPWAx7?=
 =?us-ascii?Q?YkInG+bL9Q2pxSEnLy4CQn18GSAbN02gZbgIDJgdr8A+IA4qc/s7wNNeDcPe?=
 =?us-ascii?Q?dt7MMIylGgp6Djw2sNcRlMQVhELy7FJv4ipsAabjWkGlj4grVrFRL4kcgzzY?=
 =?us-ascii?Q?JwP9vZIveT4qh9dyPE5sTnRXwfer6PcIEQv1lgC/4zeaWoYylFcnWKJw5t1p?=
 =?us-ascii?Q?utngfcmHV+Y1KzIFwc520flzyQuizdmf16OX+X4RVVYw0sCEXQBheDXcNr5L?=
 =?us-ascii?Q?1DkVVHwcG2AcQ0kpWUv9P1Pq2bhPcd1b+FULq7SclQ5TAgMZVF3+AyGOkHcA?=
 =?us-ascii?Q?zD5Or1cFV0hpXXHdcJbkaC2kF1cWx0imBbxiaXt1v1XTB+WNtz190+yBZIv2?=
 =?us-ascii?Q?orsm2LG5/vv/V7OLvjlVEzjxCDZecvOvT+5dF6eV6TQ8ZMFKjsmAiajaL9nl?=
 =?us-ascii?Q?bfdzFgztt09WQVMMzyZg6123fsx4cc5AizaoN34JP85F4anCI922j9noJn0s?=
 =?us-ascii?Q?qgjUBLSibLqfD/fyJPGvc6Doy/FRNQzSNqEh6w3jq4QSaIB/V0b/tLG1Kb0j?=
 =?us-ascii?Q?nh5mliBjeCFpJm58JqX7k9rQ7lU4PM9U0Ecbcct0UfuOq6cnD4+O1EQzqlJ+?=
 =?us-ascii?Q?ijoNz0pr/GuwxZdou7brSpE=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <021CAB36C9F10043B8F042E4AD5BE44B@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4688.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 55c86922-c340-4e73-7290-08d9aab03cc1
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Nov 2021 16:26:55.9295
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ejjNzX3vEHZECnxwXBOZ85QQ/RDWYJhEDV/iYQbniE/hmrTz0AuR2zeV4nlbxu72J21ecMCIBJ/mCLn3nuSZ2w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2711
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10172 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 bulkscore=0
 adultscore=0 mlxlogscore=999 malwarescore=0 mlxscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111180090
X-Proofpoint-ORIG-GUID: d3bGPbHmIAXGXjAehwp4uDBVnsy84mwD
X-Proofpoint-GUID: d3bGPbHmIAXGXjAehwp4uDBVnsy84mwD
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Nov 17, 2021, at 5:17 PM, Dave Wysochanski <dwysocha@redhat.com> wrote=
:
>=20
> The first 3 patches are cleanups and refactorings of the NFS fscache code=
.
> The last 4 patches convert dfprintks to trace events in the NFS fscache c=
ode.
> These patches were built / tested on 5.16.0-rc1.
>=20
> Dave Wysochanski (7):
>  NFS: Use nfs_i_fscache() consistently within NFS fscache code
>  NFS: Cleanup usage of nfs_inode in fscache interface and handle i_size
>    properly
>  NFS: Rename fscache read and write pages functions
>  NFS: Convert NFS fscache enable/disable dfprintks to tracepoints
>  NFS: Replace dfprintks with tracepoints in fscache read and write page
>    functions
>  NFS: Remove remaining dfprintks related to fscache cookies
>  NFS: Remove remaining usages of NFSDBG_FSCACHE
>=20
> fs/nfs/fscache-index.c      |   2 -
> fs/nfs/fscache.c            | 106 ++++++++++++++++-----------------------=
-----
> fs/nfs/fscache.h            |  33 +++++++-------
> fs/nfs/nfstrace.h           | 103 +++++++++++++++++++++++++++++++++++++++=
+++
> fs/nfs/read.c               |   6 +--
> include/uapi/linux/nfs_fs.h |   2 +-
> 6 files changed, 162 insertions(+), 90 deletions(-)

Series Reviewed-by: Chuck Lever <chuck.lever@oracle.com>


--
Chuck Lever