Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
From:   "NeilBrown" <neilb@suse.de>
To:     "J. Bruce Fields" <bfields@fieldses.org>
Cc:     "Chuck Lever" <chuck.lever@oracle.com>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 00/14] SUNRPC: clean up server thread management.
In-reply-to: <20211117141231.GA24762@fieldses.org>
References: <163710954700.5485.5622638225352156964.stgit@noble.brown>,
 <20211117141231.GA24762@fieldses.org>
Date:   Fri, 19 Nov 2021 14:24:15 +1100
Message-id: <163729225540.13692.3919900284802570106@noble.neil.brown.name>
Precedence: bulk

On Thu, 18 Nov 2021, J. Bruce Fields wrote:
> On Wed, Nov 17, 2021 at 11:46:49AM +1100, NeilBrown wrote:
> > I have a dream of making nfsd threads start and stop dynamically.
> 
> It's a good dream!
> 
> I haven't had a chance to look at these at all yet, I just kicked off
> tests to run overnight, and woke up to the below.
> 
> This happened on the client, probably the first time it attempted to do
> an nfsv4 mount, so something went wrong with setup of the callback
> server.
> 
> --b.
> 
> [  285.585061] divide error: 0000 [#1] PREEMPT SMP KASAN PTI

It appears that serv->sv_nrpools is zero.  I don't think I changed
anything relating to that.

I did think it off that nfs-callback uses svc_create_pooled, but doesn't
ensure it requests as many threads as pools....  probably not related
though.

I'll dig in a bit more later.

Thanks,
NeilBrown