From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Neil Brown <neilb@suse.de>
CC:     Bruce Fields <bfields@fieldses.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 00/20 v3] SUNRPC: clean up server thread management
Thread-Topic: [PATCH 00/20 v3] SUNRPC: clean up server thread management
Thread-Index: AQHX5NzwEbGLOvPS+EmjzIksy7I2AKwayBgA
Date:   Mon, 29 Nov 2021 17:45:36 +0000
Message-ID: <0CF1ED83-FE4A-435F-9403-943D74348696@oracle.com>
References: <163816133466.32298.13831616524908720974.stgit@noble.brown>
In-Reply-To: <163816133466.32298.13831616524908720974.stgit@noble.brown>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3DDEThc83zE96MkiNrM9bcEG9XDAnZ2sNv2CbcUw3ChshZvzrn1u8EaQaCGF?=
 =?us-ascii?Q?Wu6uEZOZpQn+ws8IzCk2XDbReqdGC6alRckLpHXx5tI/yArPP8rN3SnygWKs?=
 =?us-ascii?Q?6fqY/kw0Nh+vzJ5hkf7A3NuA1gZ6+QpeB+N87RjcDecx23caC9UVPkzPcVvs?=
 =?us-ascii?Q?gGGsdwIsHtHwJeR2RqmEV6/T4We43Eiz2Osh4WJTyH6ujsBa0mdkpPUnjMXf?=
 =?us-ascii?Q?Z1khj1SnQcFjqqRjnGl9pXxSsoqkeG7abbJXSEVQBIVY79azk4PfFZA8Y1WD?=
 =?us-ascii?Q?nTzm+AE8nn9dKrRZWDkkCLOzvgyGq5tdAfXp+0sqy2zEa1js3QTuT4vkz0CF?=
 =?us-ascii?Q?91se8uVvqd/h8HoYqy2nHjAkt045UuxC0XtjLZaUEg3/KgEnj3x5WrmyuEd8?=
 =?us-ascii?Q?HHy7VOQojqFZfPCyzr3KeGsCR2prQz+S/coTg1K2oPrxdESPHUJyTuhbffzM?=
 =?us-ascii?Q?4HT1JI9p9uxv8vgkSkx0BDIQI3G1UyBDcJV09LtdUwldtKKHeAzbuFtnY2jd?=
 =?us-ascii?Q?TR/RqPkFhUN3JyxTqSjVU/Hlzky8n49jhJ5/7MU8p9Mqlrp3xz1dVm1cyGnZ?=
 =?us-ascii?Q?DfcQp8edUNKhPmv7r/k3bLG0FgJUWiMGHJJupyyfS26RVq68LatWv2oema6e?=
 =?us-ascii?Q?DJ2oki2vExBeeqJ7CK6kqdr0Pam8xqLRXW1k4O94XFbluCeFRF9+NEq83ACs?=
 =?us-ascii?Q?m2dyNFfzyALJ4KE/9V1jJ+Y/hv6ngGUNeZSBdM4OjmX2V/napDNAUHPuf81B?=
 =?us-ascii?Q?1/ed91uR+ifV265ij0Yg/6oWSMS8tGdcVQbEv7mmftAyUkqdsT9HFqTnZfF9?=
 =?us-ascii?Q?luBJCkRsdrxSczytY36smEturGl1G929Ut/EgxDU+OEfp2QXsx/sdzKvfmXw?=
 =?us-ascii?Q?0IX4iCg1L1i9wb8MBuidGoD4d33FVQDGi07xHZ5c9eZq2MjVubbUngpbc0ND?=
 =?us-ascii?Q?MRonc+er6sAO9fXWdiwwu9CNMiNgRRtuFaKT12UnqgwlsaoMjbKtxZBZAH9H?=
 =?us-ascii?Q?5I3gK/YuXWYV+YMjiOwZfOBu45UFWgHqjeQdNzpLEH3ewBVeCyHQ8BHLJVaG?=
 =?us-ascii?Q?t5qXSDMT1y6Xg3Own0AsZHe2WdKXbYgdgSMXW+1lyt6tf/0bLhTMm4/T+yRA?=
 =?us-ascii?Q?ChmpioO2qh2vDpvWzeVOh8f4tATeYVoNT9BnGmryBWIuffoROov4AzcrZelJ?=
 =?us-ascii?Q?5WQRmnVtMzbtPJnc0SwTjGhu96KOMEwaCRfZD0AI8ankJvkjQ88+b9PMJXA0?=
 =?us-ascii?Q?Vb9WPybY48pz/C1PZcnboe9ryqqyyoykbUIpCDrDo7N8HnKPW+9trbN7RIwX?=
 =?us-ascii?Q?trfQsTFo2EuKza+4lYjc1zCTRoOPOQC+MKldsNgqd6BHqn2o/TymksGuut91?=
 =?us-ascii?Q?XwB6FlifA1cX71S6CHXUO2AgUWHqjJwn8J/6cP96mJrHD3FrbYjQTLbkfClV?=
 =?us-ascii?Q?bqDBpWTccPcmJ0/XuaCPq1uhy/mTjCq4DNPqDIeSBiNPW2tyYzAUXF0dGOG6?=
 =?us-ascii?Q?g4/YiSZ2YkfcuaWWLSvAn3aVEPK4jpVweWLLMhmkgFB67xnvvCs2LGSoRa3Z?=
 =?us-ascii?Q?P248FlH59Nlyhzrtq1YJEYmuilPko2g0aiG+d5EeP+RItwkPflQA8c1rLqP4?=
 =?us-ascii?Q?WMDm1HUYezbOs2TwAhQDbhA=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <C8B63DA9B2516645B130947E3AAE8A42@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4688.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6ae82805-fe14-44e6-bf48-08d9b3600cc1
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Nov 2021 17:45:36.0757
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: sqLyeOxcrQAyA/vVXw5erp6xL56yVTlXzVEZCxtr7HlHKHPZ7b6EftvOayJzvcYgk/DR/d4ULwC8Qu0pf7E/jw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3608
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10183 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999
 phishscore=0 suspectscore=0 spamscore=0 adultscore=0 mlxscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2111290083
X-Proofpoint-ORIG-GUID: NrtYAjR_JUim3kJ8XnP1HCOtvfnIgW1u
X-Proofpoint-GUID: NrtYAjR_JUim3kJ8XnP1HCOtvfnIgW1u
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Nov 28, 2021, at 11:51 PM, NeilBrown <neilb@suse.de> wrote:
>=20
> This is v3 of mt server thread management cleanup series.
> changes include:
> - splitting out a couple of patches, and moving simple bugfix to the
>   front.
> - Fixed a bug in previous series where lockd module count was being
>   incremented when the lockd thread started, but not decremented when
>   it exited.
> - minor improvement to patch descriptions.
>=20
> Thanks for the review and testing!
>=20
> NeilBrown
>=20
> ---
>=20
> NeilBrown (20):
>      NFSD: handle errors better in write_ports_addfd()
>      SUNRPC: change svc_get() to return the svc.
>      SUNRPC/NFSD: clean up get/put functions.
>      SUNRPC: stop using ->sv_nrthreads as a refcount
>      nfsd: make nfsd_stats.th_cnt atomic_t
>      SUNRPC: use sv_lock to protect updates to sv_nrthreads.
>      NFSD: narrow nfsd_mutex protection in nfsd thread
>      NFSD: Make it possible to use svc_set_num_threads_sync
>      SUNRPC: discard svo_setup and rename svc_set_num_threads_sync()
>      NFSD: simplify locking for network notifier.
>      lockd: introduce nlmsvc_serv
>      lockd: simplify management of network status notifiers
>      lockd: move lockd_start_svc() call into lockd_create_svc()
>      lockd: move svc_exit_thread() into the thread
>      lockd: introduce lockd_put()
>      lockd: rename lockd_create_svc() to lockd_get()
>      SUNRPC: move the pool_map definitions (back) into svc.c
>      SUNRPC: always treat sv_nrpools=3D=3D1 as "not pooled"
>      lockd: use svc_set_num_threads() for thread start and stop
>      NFS: switch the callback service back to non-pooled.
>=20
>=20
> fs/lockd/svc.c             | 200 +++++++++++--------------------------
> fs/nfs/callback.c          |  32 ++----
> fs/nfsd/netns.h            |  13 +--
> fs/nfsd/nfsctl.c           |  24 ++---
> fs/nfsd/nfsd.h             |   2 +-
> fs/nfsd/nfssvc.c           | 159 +++++++++++++++--------------
> fs/nfsd/stats.c            |   2 +-
> fs/nfsd/stats.h            |   4 +-
> include/linux/sunrpc/svc.h |  79 ++++++++-------
> net/sunrpc/svc.c           | 175 ++++++++++++++------------------
> 10 files changed, 286 insertions(+), 404 deletions(-)
>=20
> --
> Signature
>=20

Hi Neil-

For broader testing, I've added the patches in this version of the series t=
o
the for-next topic branch at

  git://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git


--
Chuck Lever