Message-ID: <56de55c4-d3f2-4671-f7b4-912d872315fd@redhat.com>
Date:   Mon, 29 Nov 2021 16:13:57 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH RFC 0/3] Remove NFS v2 support from the client and server
Content-Language: en-US
To:     NeilBrown <neilb@suse.de>
Cc:     Linux NFS Mailing list <linux-nfs@vger.kernel.org>
References: <20211129192731.783466-1-steved@redhat.com>
 <163821829080.26075.9477835708436642432@noble.neil.brown.name>
From:   Steve Dickson <steved@redhat.com>
In-Reply-To: <163821829080.26075.9477835708436642432@noble.neil.brown.name>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hey!

On 11/29/21 15:38, NeilBrown wrote:
> On Tue, 30 Nov 2021, Steve Dickson wrote:
>> These patches will remove the all references and
>> support of NFS v2 in both the server and client.
> 
> What is the motivation for this?
> I don't necessarily disagree, but I'm curious as to what you hope to
> gain.
Just to eliminate v2 support once and for all...
It is a dead version, IMHO, so I'm just trying
to clean things up by remove it from the man pages
and error out (on the client), if a v2 mount is tried...

We are coming out with a major fairly soon, so
I'm just trying make it clear v2 is no longer
an option... So I wanted to more eyes on what
we are thinking of doing.

steved.

> 
> Thanks,
> NeilBrown
> 
>>
>> On server side the support has been off, by default,
>> since 2013 (6b4e4965a6b). With this server patch the
>> ability to enable v2 will be remove.
>>
>> Currently even with CONFIG_NFS_V2 not set
>> v2 mounts are still tied (over-the-wire). I looked at creating
>> a kernel parameter module so support could re-enabled
>> but that got ugly quick.
>>
>> So I just decided to make all V2 mounts fail with
>> EOPNOTSUPP, with no way of turn them back on.
>>
>> Steve Dickson (3):
>>    nfsd: Remove the ability to enable NFS v2.
>>    nfs.man: Remove references to NFS v2 from the man pages
>>    mount: Remove NFS v2 support from mount.nfs
>>
>>   nfs.conf                  |  1 -
>>   utils/mount/configfile.c  |  2 +-
>>   utils/mount/mount.nfs.man |  2 +-
>>   utils/mount/network.c     |  4 ++--
>>   utils/mount/nfs.man       | 20 +++-----------------
>>   utils/mount/nfsmount.conf |  2 +-
>>   utils/mount/stropts.c     |  3 +++
>>   utils/nfsd/nfsd.c         |  2 --
>>   utils/nfsd/nfsd.man       |  4 ++--
>>   9 files changed, 13 insertions(+), 27 deletions(-)
>>
>> -- 
>> 2.31.1
>>
>>
>