Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17219C433EF for ; Mon, 29 Nov 2021 22:43:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234820AbhK2Wq7 (ORCPT ); Mon, 29 Nov 2021 17:46:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234889AbhK2Wo3 (ORCPT ); Mon, 29 Nov 2021 17:44:29 -0500 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5220C03AD68 for ; Mon, 29 Nov 2021 10:13:04 -0800 (PST) Received: by mail-ed1-x52a.google.com with SMTP id x15so75524008edv.1 for ; Mon, 29 Nov 2021 10:13:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=A1KpMLhPpZ3DtBAJ2H7WA1+eK6RBPvYL8JCpapFonpw=; b=hYrTDwhmtIHMqqbXGO1Kse+Z0mztn57tvq1yPxTQ6q8If5SiUN3r2mIlQQuhqQ5Ciu K5ZjiwPNhDNHwoG8b/skXzWnqGGnw5Xo6Kz7rDlvP/WRSBwiwJnbIMXZ+5EJLE2YnPsh 8oCcdh7mNJuIoeX8m73ktIFQqXot2Q8wW5BQM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=A1KpMLhPpZ3DtBAJ2H7WA1+eK6RBPvYL8JCpapFonpw=; b=JL4D7P3mofCzSfBb3M8x7wgkubU4eZOwbzIYOP5yCubC2g/5pp28l8L9oOLMOmL77U 3XJY+gmEfy/Zqt1ntahl9xDruyErOehlEWqavf7QZyckMuIDSL7ihFQ1JUSLaBJFpBff zwG+hlUc7ONgIxh8Z2iu3R8M4e8C5DWk7hKfABsh8x1D70bX3oz3WnR/1+CJVlDUpR8L 6J8NEUWREEz+3PB46g1M7Ce2MPMUCFjT4bpGGtNwJzWB8xaO4v9laYgUYJVt6FfXdxRe cDJKr4uFkbpIwIawXHqDUf+4shPNgYTZSUD5jnIqiM/oYNYzjFc1lj65vR84vquqv2FP Z4uA== X-Gm-Message-State: AOAM530TvYzeYpqPq//n87rO7oEtdVppkMO4xm2LBzsGLSRd7E7sD1KI dlL4tYqC7WuibnC/7/0T6mCffR3tyhsGP2rG X-Google-Smtp-Source: ABdhPJxWbE/xpc8OmIVaYaqTEzyymcyfBUhDcqPpPU22EW004MByz6KgbE9zw/HWvQnc3fgWifNixQ== X-Received: by 2002:a17:907:3f19:: with SMTP id hq25mr59805152ejc.225.1638209582947; Mon, 29 Nov 2021 10:13:02 -0800 (PST) Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com. [209.85.221.44]) by smtp.gmail.com with ESMTPSA id w22sm10513353edd.49.2021.11.29.10.13.01 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Nov 2021 10:13:01 -0800 (PST) Received: by mail-wr1-f44.google.com with SMTP id o13so38634686wrs.12 for ; Mon, 29 Nov 2021 10:13:01 -0800 (PST) X-Received: by 2002:adf:9d88:: with SMTP id p8mr36748101wre.140.1638209581186; Mon, 29 Nov 2021 10:13:01 -0800 (PST) MIME-Version: 1.0 References: <163819575444.215744.318477214576928110.stgit@warthog.procyon.org.uk> In-Reply-To: <163819575444.215744.318477214576928110.stgit@warthog.procyon.org.uk> From: Linus Torvalds Date: Mon, 29 Nov 2021 10:12:45 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 00/64] fscache, cachefiles: Rewrite To: David Howells Cc: linux-cachefs@redhat.com, Jeff Layton , Eric Van Hensbergen , Anna Schumaker , linux-afs@lists.infradead.org, Steve French , Dominique Martinet , Dave Wysochanski , Trond Myklebust , CIFS , "Matthew Wilcox (Oracle)" , Marc Dionne , "open list:NFS, SUNRPC, AND..." , Latchesar Ionkov , Shyam Prasad N , v9fs-developer@lists.sourceforge.net, Trond Myklebust , Alexander Viro , Omar Sandoval , ceph-devel@vger.kernel.org, linux-fsdevel , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Mon, Nov 29, 2021 at 6:22 AM David Howells wrote: > > The patchset is structured such that the first few patches disable fscache > use by the network filesystems using it, remove the cachefiles driver > entirely and as much of the fscache driver as can be got away with without > causing build failures in the network filesystems. The patches after that > recreate fscache and then cachefiles, attempting to add the pieces in a > logical order. Finally, the filesystems are reenabled and then the very > last patch changes the documentation. Thanks, this all looks conceptually sane to me. But I only really scanned the commit messages, not the actual new code. That obviously needs all the usual testing and feedback from the users of this all.. Linus