Message-ID: <22000fe0-9b17-3d88-1730-c8704417cb92@oracle.com>
Date:   Mon, 29 Nov 2021 16:11:49 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH RFC v5 0/2] nfsd: Initial implementation of NFSv4
 Courteous Server
Content-Language: en-US
To:     Chuck Lever III <chuck.lever@oracle.com>
Cc:     Bruce Fields <bfields@fieldses.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
References: <20210929005641.60861-1-dai.ngo@oracle.com>
 <20211001205327.GN959@fieldses.org>
 <a6c9ba13-43d7-4ea9-e05d-f454c2c9f4c2@oracle.com>
 <33c8ea5a-4187-a9fa-d507-a2dcec06416c@oracle.com>
 <20211117141433.GB24762@fieldses.org>
 <400143c8-c12a-6224-1b36-3e19f20a7ee4@oracle.com>
 <908ded64-6412-66d3-6ad5-429700610660@oracle.com>
 <20211118003454.GA29787@fieldses.org>
 <bef516d0-19cf-3f30-00cd-8359daeff6ab@oracle.com>
 <b7e3aee5-9496-7ede-ca88-34287876e2f4@oracle.com>
 <20211129173058.GD24258@fieldses.org>
 <da7394e0-26f6-b243-ce9a-d669e51c1a5e@oracle.com>
 <1285F7E2-5D5F-4971-9195-BA664CAFF65F@oracle.com>
 <e1093e42-2871-8810-de76-58d1ea357898@oracle.com>
 <C9C6AEC1-641C-4614-B149-5275EFF81C3D@oracle.com>
From:   dai.ngo@oracle.com
In-Reply-To: <C9C6AEC1-641C-4614-B149-5275EFF81C3D@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YjFDa3k3S0VhRmdLNmVWelBlN2FheWxrbHlSSkhzSng1Mm5ibFN1dkVLek5r?=
 =?utf-8?B?VHRteHk5SHZqN3p0cXJ0a05IOUE5cVpZdzNrcFNVT2JaL2JiS0NIYjZmUjd2?=
 =?utf-8?B?Q21UT3NIRTE3bWNTNi85U1NMVENEZFJEYzdoZDNBRkx2RkRnc3o3QXU2MjFK?=
 =?utf-8?B?MFZtVFF4Wk45YTBaQmN5MzVQbzZvN3VZQk1aQ290T3RrMkRDTC9QNkRmbEVx?=
 =?utf-8?B?Wk9FVlF1WjRIb09jNFl2QXA1R3pCaHRXNU5WNGZ0VDd3V2l1aWEzNjhpU2RC?=
 =?utf-8?B?WHc3ZnByNWpWMXFuWkh6Z2lkMDZvbHJ4QmYrcDljVkhjNHR2OGlPQ1RwcDNq?=
 =?utf-8?B?b0dNZTdKY0tvMlk5NGdsR2JQRDNFNi80RzRoM2c5UmFxK2lXb1BzcEdRZk94?=
 =?utf-8?B?TGM0SmNjNEhiUCtSYUppYnRHYjRUTmFYczh5RzN5NloxU01pVDVZZmR3azhW?=
 =?utf-8?B?czNKZlYvN1huSDdqS2NmdjhoTGFHYXFRWmJaUjQ4MVdHVlRhMWgxZXNtVW42?=
 =?utf-8?B?ZVdqUk5pSlBIWGFRN2dKRW9pdmlseXV6ellGKzcwbk82bk5CQUtNZGE0ZkQ4?=
 =?utf-8?B?cGd0MmtPRmJOTTV1cmRZUmhiT2Q1cGh3azA0K3NTUkJ4YjJPUlBJSU5TSTNU?=
 =?utf-8?B?eTkrLzZiampFdUlsNHJ3U21MVWE1V0Y4aVFScmZwSFRoRUV6SWRqUmlnYlo3?=
 =?utf-8?B?RzZZMkdrSldUMWZuc3R3RlJDSU5OVTlXaVBYUDhFMnZzd2hkVzdVb09GYnBt?=
 =?utf-8?B?K1FtQ1QzUU1uenJBcEJmN2JKZmRHZTFWa1F6cVBkY0lPMVI2amRFcnp4eGly?=
 =?utf-8?B?N29Rbk9aMlVmWHh1ejhhRDlEN2NlWWxVYVZ3RWJrVyt3V1ZTSmtKQ2h6MXo2?=
 =?utf-8?B?b25sKzh5cHEvS1FuMGJLaXh6R1RvSXZnWXV1NGFLTkY1QjdyLzcrWXBKYlMy?=
 =?utf-8?B?UlV2eTdiZ1RwSjNVNGVqU1NwZ0FTaUZVb2JZUnV3Y3FOenVqYmhtY0Uvc1JK?=
 =?utf-8?B?YW1VM2QxQ2svQUgvMnNYV284bk9OQUJ1Qk9lbTVTNThsNTZUbXdybDFPNk5n?=
 =?utf-8?B?anBZTW1pODM1d29IL0F3ZnhoN09ORFNhVWpHSzd5NUNpbk44ZHF6cFE1WFIv?=
 =?utf-8?B?WGpDUWNxb2x1MEgvc2dWSDBZUHMzaVJZS0ZnTTgrVkw2YU8vQ0dQa2tqSkVy?=
 =?utf-8?B?dDUrQXc5dGZxSTBoMnBuaEJsRWJhT3IrNFUvZ240Kzhrd0JDeU05VVAzbE50?=
 =?utf-8?B?L2JtYXdRODZJdEErNnlzSGhmMkQ0YkI1b0h3cVRkcE5MMkNqV3d6bWw2cXdh?=
 =?utf-8?B?cHM0NGc3Si8xY0g0N0c0VisyQkkrNW5MdUw5Ym5xbjFyb2hINWcrMU56ZTFB?=
 =?utf-8?B?cm5ydU9sYWR0WTBweFBKRTNvSEZDVVhGM3V0TXBINzVRazJ4elVNelNOZEtt?=
 =?utf-8?B?Q2craCt0MHRpVXUydWpkNTF1SDcwd2lnY05WamhxSGh0N2VxSHZIc0lRaEg3?=
 =?utf-8?B?eFUyUHV2bDNEMUltMmVzSXQyQXhxUnVXWS9saXlRWnArQzdERXBuNG14bm1m?=
 =?utf-8?B?eDNIOHpycWdKRWlSTVo4bFgxdXFpVTdveFpwMThWUjY2Qlo2cWlGRWpRaGJJ?=
 =?utf-8?B?bys0Mk5jU0RIRUExOVpva2phbkF6ZWwzNEhEUjg2cDYwMHhSQUNZdkYwNVV6?=
 =?utf-8?B?TTBpc1hGNFc0YXVYQTQwYkMvR3Z4NHRZVmZ2YlJXRWMzOWsxUThtWmlhaStp?=
 =?utf-8?B?OTl4WFJIWlNTM0o1Y29nTU1Md3E1a2hqcUZ1dk82RG5FYWJ2cTBQOEpueDI2?=
 =?utf-8?B?L0FMS3FDM1ptdDUyQ2YrR0pTb0R6U2xMOE9OWUV4clRReHB2dUdqbllEYjB1?=
 =?utf-8?B?Vi9KQzVZOEFDcS9yNHBOQzRTME85NWJiM1BoMTNaSmNxaTVybHVJV05JRHpi?=
 =?utf-8?B?Qzh5bE9vdnkwbTRLLzh5QW1aZU9MdUc2cFU5R083bzkvWmhDNnVNVEVPb3Yz?=
 =?utf-8?B?cTN5V1RsbUw1RjMwaTNoTWlEdlNIQzY3SXhISjkySkp3ZEM0RmpPeWdlT1Vt?=
 =?utf-8?B?LzBRNUovUmd4VjhyTGkwS0ZvWFp0M2xyaEt3dHdBcDZYUXJHZEsvUjBlT2Vj?=
 =?utf-8?B?RUZLQkM5a2U3blJ0RFdRdmw1M0tsL1BVOWIxY3RqS3BLVHVUM2txTUZyL3VM?=
 =?utf-8?Q?BbNECOf8CgID+WmG8LKcYpc=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 40ed9123-cfce-411b-700f-08d9b39602e8
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4257.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2021 00:11:52.6393
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: A7/EzMMCp/PmVTmtNDS/d+MCfr/FuimtKs9bzTjpT6iW958V3GY5kx2jK5XGa0YLIoVc7AbEAy8L892kl6ZANg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3269
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10183 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 mlxscore=0
 suspectscore=0 mlxlogscore=999 spamscore=0 phishscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111290116
X-Proofpoint-ORIG-GUID: v3Y3C0vDB0nzITiC1xQc4-830FbGRE3D
X-Proofpoint-GUID: v3Y3C0vDB0nzITiC1xQc4-830FbGRE3D
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


On 11/29/21 1:10 PM, Chuck Lever III wrote:
>
>> On Nov 29, 2021, at 2:36 PM, Dai Ngo <dai.ngo@oracle.com> wrote:
>>
>>
>> On 11/29/21 11:03 AM, Chuck Lever III wrote:
>>> Hello Dai!
>>>
>>>
>>>> On Nov 29, 2021, at 1:32 PM, Dai Ngo <dai.ngo@oracle.com> wrote:
>>>>
>>>>
>>>> On 11/29/21 9:30 AM, J. Bruce Fields wrote:
>>>>> On Mon, Nov 29, 2021 at 09:13:16AM -0800, dai.ngo@oracle.com wrote:
>>>>>> Hi Bruce,
>>>>>>
>>>>>> On 11/21/21 7:04 PM, dai.ngo@oracle.com wrote:
>>>>>>> On 11/17/21 4:34 PM, J. Bruce Fields wrote:
>>>>>>>> On Wed, Nov 17, 2021 at 01:46:02PM -0800, dai.ngo@oracle.com wrote:
>>>>>>>>> On 11/17/21 9:59 AM, dai.ngo@oracle.com wrote:
>>>>>>>>>> On 11/17/21 6:14 AM, J. Bruce Fields wrote:
>>>>>>>>>>> On Tue, Nov 16, 2021 at 03:06:32PM -0800, dai.ngo@oracle.com wrote:
>>>>>>>>>>>> Just a reminder that this patch is still waiting for your review.
>>>>>>>>>>> Yeah, I was procrastinating and hoping yo'ud figure out the pynfs
>>>>>>>>>>> failure for me....
>>>>>>>>>> Last time I ran 4.0 OPEN18 test by itself and it passed. I will run
>>>>>>>>>> all OPEN tests together with 5.15-rc7 to see if the problem you've
>>>>>>>>>> seen still there.
>>>>>>>>> I ran all tests in nfsv4.1 and nfsv4.0 with courteous and non-courteous
>>>>>>>>> 5.15-rc7 server.
>>>>>>>>>
>>>>>>>>> Nfs4.1 results are the same for both courteous and
>>>>>>>>> non-courteous server:
>>>>>>>>>> Of those: 0 Skipped, 0 Failed, 0 Warned, 169 Passed
>>>>>>>>> Results of nfs4.0 with non-courteous server:
>>>>>>>>>> Of those: 8 Skipped, 1 Failed, 0 Warned, 577 Passed
>>>>>>>>> test failed: LOCK24
>>>>>>>>>
>>>>>>>>> Results of nfs4.0 with courteous server:
>>>>>>>>>> Of those: 8 Skipped, 3 Failed, 0 Warned, 575 Passed
>>>>>>>>> tests failed: LOCK24, OPEN18, OPEN30
>>>>>>>>>
>>>>>>>>> OPEN18 and OPEN30 test pass if each is run by itself.
>>>>>>>> Could well be a bug in the tests, I don't know.
>>>>>>> The reason OPEN18 failed was because the test timed out waiting for
>>>>>>> the reply of an OPEN call. The RPC connection used for the test was
>>>>>>> configured with 15 secs timeout. Note that OPEN18 only fails when
>>>>>>> the tests were run with 'all' option, this test passes if it's run
>>>>>>> by itself.
>>>>>>>
>>>>>>> With courteous server, by the time OPEN18 runs, there are about 1026
>>>>>>> courtesy 4.0 clients on the server and all of these clients have opened
>>>>>>> the same file X with WRITE access. These clients were created by the
>>>>>>> previous tests. After each test completed, since 4.0 does not have
>>>>>>> session, the client states are not cleaned up immediately on the
>>>>>>> server and are allowed to become courtesy clients.
>>>>>>>
>>>>>>> When OPEN18 runs (about 20 minutes after the 1st test started), it
>>>>>>> sends OPEN of file X with OPEN4_SHARE_DENY_WRITE which causes the
>>>>>>> server to check for conflicts with courtesy clients. The loop that
>>>>>>> checks 1026 courtesy clients for share/access conflict took less
>>>>>>> than 1 sec. But it took about 55 secs, on my VM, for the server
>>>>>>> to expire all 1026 courtesy clients.
>>>>>>>
>>>>>>> I modified pynfs to configure the 4.0 RPC connection with 60 seconds
>>>>>>> timeout and OPEN18 now consistently passed. The 4.0 test results are
>>>>>>> now the same for courteous and non-courteous server:
>>>>>>>
>>>>>>> 8 Skipped, 1 Failed, 0 Warned, 577 Passed
>>>>>>>
>>>>>>> Note that 4.1 tests do not suffer this timeout problem because the
>>>>>>> 4.1 clients and sessions are destroyed after each test completes.
>>>>>> Do you want me to send the patch to increase the timeout for pynfs?
>>>>>> or is there any other things you think we should do?
>>>>> I don't know.
>>>>>
>>>>> 55 seconds to clean up 1026 clients is about 50ms per client, which is
>>>>> pretty slow.  I wonder why.  I guess it's probably updating the stable
>>>>> storage information.  Is /var/lib/nfs/ on your server backed by a hard
>>>>> drive or an SSD or something else?
>>>> My server is a virtualbox VM that has 1 CPU, 4GB RAM and 64GB of hard
>>>> disk. I think a production system that supports this many clients should
>>>> have faster CPUs, faster storage.
>>>>
>>>>> I wonder if that's an argument for limiting the number of courtesy
>>>>> clients.
>>>> I think we might want to treat 4.0 clients a bit different from 4.1
>>>> clients. With 4.0, every client will become a courtesy client after
>>>> the client is done with the export and unmounts it.
>>> It should be safe for a server to purge a client's lease immediately
>>> if there is no open or lock state associated with it.
>> In this case, each client has opened files so there are open states
>> associated with them.
>>
>>> When an NFSv4.0 client unmounts, all files should be closed at that
>>> point,
>> I'm not sure pynfs does proper clean up after each subtest, I will
>> check. There must be state associated with the client in order for
>> it to become courtesy client.
> Makes sense. Then a synthetic client like pynfs can DoS a courteous
> server.
>
>
>>> so the server can wait for the lease to expire and purge it
>>> normally. Or am I missing something?
>> When 4.0 client lease expires and there are still states associated
>> with the client then the server allows this client to become courtesy
>> client.
> I think the same thing happens if an NFSv4.1 client neglects to send
> DESTROY_SESSION / DESTROY_CLIENTID. Either such a client is broken
> or malicious, but the server faces the same issue of protecting
> itself from a DoS attack.
>
> IMO you should consider limiting the number of courteous clients
> the server can hold onto. Let's say that number is 1000. When the
> server wants to turn a 1001st client into a courteous client, it
> can simply expire and purge the oldest courteous client on its
> list. Otherwise, over time, the 24-hour expiry will reduce the
> set of courteous clients back to zero.
>
> What do you think?

Limiting the number of courteous clients to handle the cases of
broken/malicious 4.1 clients seems reasonable as the last resort.

I think if a malicious 4.1 clients could mount the server's export,
opens a file (to create state) and repeats the same with a different
client id then it seems like some basic security was already broken;
allowing unauthorized clients to mount server's exports.

I think if we have to enforce a limit, then it's only for handling
of seriously buggy 4.1 clients which should not be the norm. The
issue with this is how to pick an optimal number that is suitable
for the running server which can be a very slow or a very fast server.

Note that even if we impose an limit, that does not completely solve
the problem with pynfs 4.0 test since its RPC timeout is configured
with 15 secs which just enough to expire 277 clients based on 53ms
for each client, unless we limit it ~270 clients which I think it's
too low.

This is what I plan to do:

1. do not support 4.0 courteous clients, for sure.

2. limit the number of courteous clients to 1000 (?), if you still
think we need it.

Pls let me know what you think.

Thanks,
-Dai

>
>
>>>> Since there is
>>>> no destroy session/client with 4.0, the courteous server allows the
>>>> client to be around and becomes a courtesy client. So after awhile,
>>>> even with normal usage, there will be lots 4.0 courtesy clients
>>>> hanging around and these clients won't be destroyed until 24hrs
>>>> later, or until they cause conflicts with other clients.
>>>>
>>>> We can reduce the courtesy_client_expiry time for 4.0 clients from
>>>> 24hrs to 15/20 mins, enough for most network partition to heal?,
>>>> or limit the number of 4.0 courtesy clients. Or don't support 4.0
>>>> clients at all which is my preference since I think in general users
>>>> should skip 4.0 and use 4.1 instead.
>>>>
>>>> -Dai
>>> --
>>> Chuck Lever
>>>
>>>
>>>
> --
> Chuck Lever
>
>
>