From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Wei Yongjun <weiyongjun1@huawei.com>
CC:     Neil Brown <neilb@suse.de>, Bruce Fields <bfields@fieldses.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>,
        Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next] NFSD: make symbol 'nfsd_notifier_lock' static
Thread-Topic: [PATCH -next] NFSD: make symbol 'nfsd_notifier_lock' static
Thread-Index: AQHX5dx1rd4OTcROt0WbUE7C0kd8rqwcg4MA
Date:   Tue, 30 Nov 2021 20:19:47 +0000
Message-ID: <888F3743-AB98-41A6-9651-EFDE5987AA01@oracle.com>
References: <20211130113436.1770168-1-weiyongjun1@huawei.com>
In-Reply-To: <20211130113436.1770168-1-weiyongjun1@huawei.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?sNedteBi9p0OovspULzino96kWHakY6eFLnEshZaxq2X0fIVgP6OSI1PeJmt?=
 =?us-ascii?Q?x8hORHMEHPaoeIGCcYDKnF4HKCRheEXVOgU2MOmCIKAy/KU2Hif4Ufcnn0eq?=
 =?us-ascii?Q?dLnC7kSmcnaEvF1viEk7YLxkC13VBmO9yJg2eE3xjYW7i+rHfN6RQYcR3Ymw?=
 =?us-ascii?Q?DFFLvo6bnMq/NvKZpKpcmMnDM0Yz8qBzOgLFeYOyutPh+uNr3+v9Rn6Lp0P1?=
 =?us-ascii?Q?xv3iYDBMo6pgRv3pTl8lHMBNue1L7ZZ38OeoElBRrjEcy2zXCG5uPkOsM5Tj?=
 =?us-ascii?Q?3ht5oJSMQT4ub/FbUxkeqchtMhpSyKitmsZoFzm+ebFWVdXZcazpuJq0//YC?=
 =?us-ascii?Q?a6KZuKMpOb2oP5Os7Xe/T5Ng+9A9i9kz2jetmbTjnYEF5rJybVllndsO1Uv9?=
 =?us-ascii?Q?UgOG1B9yjNQod/W0AbHZKu9X/IRSAsqhLiy7lsyfNN6RxXkXH67n+UAoqFS9?=
 =?us-ascii?Q?nnd0ZtNmT4mKdkFJHZQewmYr3bQD1JCZCzkG2iLWEU5BjjynI3DfW43HcSDB?=
 =?us-ascii?Q?9Dil3e3/3CrIRg7heqXRhhni+JrGnZ/fzIEKW6/xPVNC4QXRigpzJkW8r6ZC?=
 =?us-ascii?Q?CDN0KBLY3vxJr6TCHfa0M/YtX5BRlWwEhn748aajQWpRGZ2R2e/CNUOwni4o?=
 =?us-ascii?Q?NrBHZCqpkSh58FfYQNR2607KylZORphi7sejWgPCTHF1iK1iSlGTMCbllUBb?=
 =?us-ascii?Q?VMtVVRmlQUuZSreERAPyjYSh6xqo1xIDABhwaBPw/yVoz829ImECRjDNLDCb?=
 =?us-ascii?Q?1P/yjJuwhRFwqYB3KDeH4xJbOvbhQaJCZ9v3z0ORqwh0Q28bqhpA3EIZyO4d?=
 =?us-ascii?Q?/7AG/rvoCECN70r9cgB46T0VCdCGoKjK7N6ufaSz33MxI3TfDZAykKa9WI1k?=
 =?us-ascii?Q?k0kDHbBqVClof1fufuGvTiUbGmovBMjYZd7Q9nz2RjqT4d6m71V+4R4Bq/VK?=
 =?us-ascii?Q?hs8gMP8U01ij11fqrmES/o49rqdo4DTb02/zLNBrTjSIj/K/rdq7e/UIMUPH?=
 =?us-ascii?Q?QLym+3du4GdCBH//9qG8sJTc3mY8/XAQwQTFnAaXTdvyTG3Av1WKFwZEVEou?=
 =?us-ascii?Q?SAowKCBTWTUtq86Sj5CA84dfx1dirb7y7Soh2YMtoRfVI1ITU0I6qteUA2iE?=
 =?us-ascii?Q?lnzGkVZmrqsWhdKoBb49n89jz4XZYqXJiGl8UpMH9ApwKwp+OU68gLGmWlPs?=
 =?us-ascii?Q?BW039y8xkXDuGgGd0j6JhvDyHQuoGusALevSTT3UEa1bhT2p4f7SzWVTH0v5?=
 =?us-ascii?Q?9HOaubfW/r0G9F37vpttdrTWUE681/6/8IgaqBbDjj2+ZgJg5s/6DeavZoFS?=
 =?us-ascii?Q?CQBP6l4T0EUIxLXkt6bkm2vm8SHvU/aPTqBFvYmBuV6Qzn5A6npEtghkPjoL?=
 =?us-ascii?Q?gIzZeDw6/GdixTTN5c0MHg4+BPLBjkn5qM9JgYToU1GWv+XBEvuFbdiZpLix?=
 =?us-ascii?Q?DeCypZjYGKQNqpLH5JrmIRjrSjwG+wjDP+MBt2/nEpBaTSwWpVS6WMZlk51k?=
 =?us-ascii?Q?Jav5SYkavOFaNPEPtw1XtZcexGPwAHvznYnHOmBl1KiKWv1dGzShseVU+dDI?=
 =?us-ascii?Q?Xmup1UwnmfgwbUxwsu4tCo6DPfvOpH8Lf9z4Ylw1NtqAaRIz8HvO/2N1p9aM?=
 =?us-ascii?Q?oFobDq6Y6jfAfNnKvjmV8lQ=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3196ADB50839224FB38E9433C5DB22D6@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4688.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dcc01fd4-c0d9-4da3-e552-08d9b43ec16b
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2021 20:19:47.4596
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: k8PRMnNaA9qMXrHGuxZWk1y5fQSI+IfTd8yAAFYzXhLmZKsDJGW2LVHTdxwDj7+BWB6NNdB/R5yXbohlUssNcA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3221
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10184 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 adultscore=0
 bulkscore=0 malwarescore=0 mlxlogscore=999 mlxscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111300104
X-Proofpoint-ORIG-GUID: jlY5zLyy307BgDurfaHu7tk3JWOcDytK
X-Proofpoint-GUID: jlY5zLyy307BgDurfaHu7tk3JWOcDytK
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Nov 30, 2021, at 6:34 AM, Wei Yongjun <weiyongjun1@huawei.com> wrote:
>=20
> The sparse tool complains as follows:
>=20
> fs/nfsd/nfssvc.c:437:1: warning:
> symbol 'nfsd_notifier_lock' was not declared. Should it be static?
>=20
> This symbol is not used outside of nfssvc.c, so marks it static.
>=20
> Fixes: 6ac25fbcbde9 ("NFSD: simplify locking for network notifier.")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> fs/nfsd/nfssvc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c
> index 070525fbc1ad..14c1ef6f8cc7 100644
> --- a/fs/nfsd/nfssvc.c
> +++ b/fs/nfsd/nfssvc.c
> @@ -434,7 +434,7 @@ static void nfsd_shutdown_net(struct net *net)
> 	nfsd_shutdown_generic();
> }
>=20
> -DEFINE_SPINLOCK(nfsd_notifier_lock);
> +static DEFINE_SPINLOCK(nfsd_notifier_lock);
> static int nfsd_inetaddr_event(struct notifier_block *this, unsigned long=
 event,
> 	void *ptr)
> {
>=20

Thanks! This was pushed to the tip of the for-next branch at

https://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git

I removed the Fixes: line because a backport is unnecessary, and
the commit ID is not yet permanent.


--
Chuck Lever