Date:   Fri, 3 Dec 2021 14:25:05 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Chuck Lever III <chuck.lever@oracle.com>
Cc:     Wei Yongjun <weiyongjun1@huawei.com>, Neil Brown <neilb@suse.de>,
        Bruce Fields <bfields@fieldses.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>,
        Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next] NFSD: make symbol 'nfsd_notifier_lock' static
Message-ID: <20211203112505.GI9522@kadam>
References: <20211130113436.1770168-1-weiyongjun1@huawei.com>
 <888F3743-AB98-41A6-9651-EFDE5987AA01@oracle.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <888F3743-AB98-41A6-9651-EFDE5987AA01@oracle.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dIx12IXUXM7It4tr+rBXv+0x+tBs81YdrkVkdy8myxKnJMGQnjyZdS8kzDjQ?=
 =?us-ascii?Q?wvp2sJTglLgK5pycDhlKVWirRL1Is2Ou3nCaWkRkI8PU5JuIaho25+qFlD2q?=
 =?us-ascii?Q?738YchM3lT/rQCF80u9pR+KVpX4BMgGMaNzYlhjyoa/K0wSAhkG47Xx07x9v?=
 =?us-ascii?Q?dwtKOciz6i3y8ueWhBf1Wkzvou5XjggW/T/wJ8JoCZxv3tyIVCyGSQ/eMar4?=
 =?us-ascii?Q?pgI2MkWLfNZz6P1ey5wFPRkqbv+bjy+W2hXwsLJ3EJV5YUCQSdw/0x1NQU/c?=
 =?us-ascii?Q?MRVUZ+wkHktxyAPQCUOLV9tbqE09MgGft+5TPwC9AB6CNZ5K5LcCjV1/Uu/f?=
 =?us-ascii?Q?/KIlY/hANCh2r637/fr5Q0xRFEwW0kvSzTDQt56ypSl0iSOcHKUar6vLiH4x?=
 =?us-ascii?Q?uRVJCG52yqXpEDbeuzmUofVVPEj3GgA7u1k37RrkWz66golyPcfv+r9UCTAZ?=
 =?us-ascii?Q?Nzn1Zlzy2VdP6h9aUMXdloYQuB5rAT3NICGIfgNU9ZYlDIMltqqBbkgBnMtp?=
 =?us-ascii?Q?LsHVh0RUq6OCAfZ6l5jZQjENG5lPDNwWcTrHuPHeKmaUPv+WZtGjB6KjfV3m?=
 =?us-ascii?Q?M+x8P9J8uCFBAzw2uhodIkljSdYHgS7BwhFR9Rc19e4NNQ3/aw46iCNFrIrv?=
 =?us-ascii?Q?0FxM4TfFEvrU+WcnMR0/pF2pwuWIo+TXMC4CaU9qw4OQCNm9dhfYpV2vzWax?=
 =?us-ascii?Q?z/OA3knHJRz18nn7x9vAOkTEAn0lnYQMGcgnl7TphEYb/bvcofgiIn7Hx/Yl?=
 =?us-ascii?Q?+M3uMB/6NXsHCZEJ1dT9RN4btjIE3iv9LGDsDfWNDtWCsAfeoRF6GI1uDYrU?=
 =?us-ascii?Q?HUL2qLJY7vLkEwhDUH+BLDhpB756FHvrJ5Do394ruPcP8HtmxCaXOYHaTdfT?=
 =?us-ascii?Q?hnrzHTsW+qKRwzoyMcAxmzYQvpG6MVkiJlyM5t51bX/RKTe+jzp6gDNyycJz?=
 =?us-ascii?Q?g6t7L39g3tXBMrGq10EI/LNEVnDEBuqBauhbSRXs6uXV4a3Olux4lMtx0Ykq?=
 =?us-ascii?Q?vWWSSoS0GuQGE8JqRkmbVFiJDHgbOYTI9G6pcnF/frNo9jXPExtJails0mdJ?=
 =?us-ascii?Q?dnW9Zkj6yL+FGCxCKKB2/Pj35vLcrdZimot+ANkfpknUk2pXGjjVdGnMYKqK?=
 =?us-ascii?Q?XP0XvDmcgJhIEBUS6OkTyRbF/xUOV+dpBrIe7KGdaHochKGBi5xEicgo6u0v?=
 =?us-ascii?Q?oWpgK0/lSugqKNn1rXMMf8pN8kiOAzpQ2XPA+I5FD0IqLcojGm1FrpE1YQRR?=
 =?us-ascii?Q?3amfDNwMtO05tcF6GEopPa4seqP1twRPZe8Bf+Cf4gnJQ2Dk8hRpgRk65Nqj?=
 =?us-ascii?Q?iDpxYtSfdsiX3hrqnJ6WmdHVbdcvN9uJixH2h5FWa7uvmo7xiSvekd5wLSbR?=
 =?us-ascii?Q?OQwxNd6HxmIbh/H0bk9hskuFfLSJ9A3qNhjfM/zBg9jm9/qYMLIkQtyt0Lwh?=
 =?us-ascii?Q?SgRD9XsMl1s4YajElR2K1tbMe6J9bEyVHdVYV/MdjRozIq61K+IRGyZhPg8A?=
 =?us-ascii?Q?isll7B7gAOPApbgDa6JjqsYdCkkn8mtspnAPCOcmoFkzt7hiugo2vZObLb0k?=
 =?us-ascii?Q?+y0MFtBNarrcYGRxzupJXkCCsLgZPgTXeOBoct1Q+kHLF1nEu9CNavoZDmm6?=
 =?us-ascii?Q?VmFnmLklVOBVumCA4mLHASD5+6i6e7pa7SqftJOFIxK0bBxRMTdwbvH2nOHy?=
 =?us-ascii?Q?qbudzxU5igp9jxxqiT7Ot1K4wzQ=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 25304bc6-1f8b-4e99-48e6-08d9b64f9a48
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 11:25:26.1803
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QvMVHIHonuURlzKx03fatmNO7gMCFdOA1jh+GC4EPA1U9ZApyxPg2iWrI8ZF8djuWwFSsIdMxsBdXIgWkO7iF9LvUwbwzj53fgrn6oFfYRo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1486
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10186 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999
 phishscore=0 suspectscore=0 spamscore=0 adultscore=0 mlxscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112030068
X-Proofpoint-GUID: ECRV5JVDBJNvRDLipmrhAx2HvYwubcTa
X-Proofpoint-ORIG-GUID: ECRV5JVDBJNvRDLipmrhAx2HvYwubcTa
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

On Tue, Nov 30, 2021 at 08:19:47PM +0000, Chuck Lever III wrote:
> > 
> > -DEFINE_SPINLOCK(nfsd_notifier_lock);
> > +static DEFINE_SPINLOCK(nfsd_notifier_lock);
> > static int nfsd_inetaddr_event(struct notifier_block *this, unsigned long event,
> > 	void *ptr)
> > {
> > 
> 
> Thanks! This was pushed to the tip of the for-next branch at
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git
> 
> I removed the Fixes: line because a backport is unnecessary, and
> the commit ID is not yet permanent.

Removing the tag, makes it more complicated for backporters.  Before
they could tell automatically from the Fixes tag that backporting was
not necessary.

On the other hand, does this patch really need a Fixes tag since it's
not a runtime bug?  Different maintainers take different sides in that
argument.

If the patch needed a fixes tag then a lot of maintainers have scripts
to update the tag during a rebase.  There are also automated tool run on
linux-next which emails a warning when the Fixes tags point to an
invalid hash.

regards,
dan carpenter