From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Dan Carpenter <dan.carpenter@oracle.com>
CC:     Wei Yongjun <weiyongjun1@huawei.com>, Neil Brown <neilb@suse.de>,
        Bruce Fields <bfields@fieldses.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>,
        Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next] NFSD: make symbol 'nfsd_notifier_lock' static
Thread-Topic: [PATCH -next] NFSD: make symbol 'nfsd_notifier_lock' static
Thread-Index: AQHX5dx1rd4OTcROt0WbUE7C0kd8rqwcg4MAgAQhm4CAAEDugA==
Date:   Fri, 3 Dec 2021 15:17:30 +0000
Message-ID: <0428D783-49FE-451E-827B-6DB8F03347D1@oracle.com>
References: <20211130113436.1770168-1-weiyongjun1@huawei.com>
 <888F3743-AB98-41A6-9651-EFDE5987AA01@oracle.com>
 <20211203112505.GI9522@kadam>
In-Reply-To: <20211203112505.GI9522@kadam>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?PZE5FVmrmPmvm9h2i4UXRA0QQOutKVFw8r85io/YZPUj/VPk9nW/thSQrl4N?=
 =?us-ascii?Q?n4Nc6NvHWMoeVXOCv96uF14+jRDoY996vqRmCF1RqAx4cRZKaTRsYtKqGo3N?=
 =?us-ascii?Q?Alp7TpMetUQYlMbAfRqH6XAOv2IDAWwroHw/PbGnL/kXZLYY+z9GfCXYg3P3?=
 =?us-ascii?Q?EGScTB6C8B8hTV6dRSGzsS2HxR56I9uNCIk4mgy4qzay9pD9SXCr095TZMGE?=
 =?us-ascii?Q?+Kh9lRKFyF/xMTKlDxdOUBQlkcwl4Jb2Vpv5E7jHxJfAB36whZwqlaw+k79o?=
 =?us-ascii?Q?QrUc1KrAl2JF52UtE/Tto8onT8gy9/QXkR5nVoNMcRNsC6YS5fD5cUXBj0HL?=
 =?us-ascii?Q?BPdwjTgKvJAeAfNXAxEgE3fqCSZcblc5/80gaPISRKwc7KCFfpZPcQdv+5k7?=
 =?us-ascii?Q?U4w+6oqsyZFhTyMBAuD4H3dOCDb6rPFwDI3MdcFP/D4CdOtExilINfIO7ZYb?=
 =?us-ascii?Q?6fGf1i++nOIMitcXPttCbDsI8Pl1WvA2BDS4eLMQe2VWabC+wG5K8dPGadOS?=
 =?us-ascii?Q?OqiLbBlfBFuMRm0cnOxAaBddm503ITFhzHWanSWM8G/3/9bXmPRiBDNgbb9L?=
 =?us-ascii?Q?LPLRP590/hrYgjIUNCZrKW/cYYpuzDEkMNZD8Q08v7m8QY2daFr6CF36PxFV?=
 =?us-ascii?Q?n121f/Avcdw3n+e+u+ADFGJdZArPXyRpI31cqUI2zzF6/oeX77Rsfd6ugzJK?=
 =?us-ascii?Q?8MenMnWVMs3VZTuSmEsXQsdAiIKrUpFS6A5nELJDkHUZjNm9onpftHw9t6z8?=
 =?us-ascii?Q?/PnXW+56tjGpuyCFmLJpISCU7cRT+sYlfuNMSKw2ORrCvEikuIluznyPnAje?=
 =?us-ascii?Q?ax+Ar9sizXMS31mAmud29bZjnPYMSyNL/7l8uHnpH4pu4b19KnEf3qX/GUFz?=
 =?us-ascii?Q?xq/OgEHDK2gu4qxsreJD6oBDummSZQ4UZB6zZYtriLl+HcvvG8JL0ikek0sh?=
 =?us-ascii?Q?Kwf6N/IcgCSzxB5EMxtNc//9rx26c3OQi/cCYGQAhLyStCTyxbHo0QXC0yNX?=
 =?us-ascii?Q?jzEViJKhPQkpxENmRx0wA8omJiGMrrDfFGE2ZFGMM9eOKCNeN83XrhlcIf8J?=
 =?us-ascii?Q?PSZBfdWJaL9E5c5EWSSEabbyzE1sS/f0UlqzArj+D08RLLp0rmrz6NXV+06z?=
 =?us-ascii?Q?Omo0ouVMa40w8ldQSzHp0phGUz0IwUQhSnXX30BdKXA0bKlzii82t3WXOkGn?=
 =?us-ascii?Q?uqeDF3kL+BNtQ6Ov0bl/yZMn9G7AyjDSUumtZxN4p8FnKEHM7kRZmCD0MbHG?=
 =?us-ascii?Q?ALnXumvM7wC+TEJ0MrM4+kCKRfwdpV3jDlP+kStV2plbh1krmkip83fd9miu?=
 =?us-ascii?Q?31gys4GCNR8Zc4YjKuEioJq8JOXUe1dD8TZu6OF6vNT+sumQ8nLaX6iWuvB8?=
 =?us-ascii?Q?hgGi2JTSSYyiWaPlV8PiFzW5XfPLVhaTiRTUc8TWUI2jxoV93ve+KfyLscd7?=
 =?us-ascii?Q?migYjtjrAH8xi7spYOmmruAnr9bfYbddvn3zfAy0beKo4O6jqHN26trciSEo?=
 =?us-ascii?Q?yVKg+y2PArNrnjoRnqpOkgscoWislX1qoEpWBCtX1TVuQloNyZlEREDZhAp4?=
 =?us-ascii?Q?Vc3NgXAlycCgWnQ2dCzHfnH/UXmSshpvguOQawhHcQemMDPZE+XLIQIZbkT3?=
 =?us-ascii?Q?a13PPiW1RPQ+vRX4VA3ZLzk=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <F3A975D8E09FCB44B0FFEB9CAF2F5EE1@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH0PR10MB4858.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aa8bd6b3-2146-4703-da4f-08d9b670064b
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Dec 2021 15:17:30.7225
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: VHSAzfRVErPr+Q8Otg4dWzALcE4Z7C7T1ABVRMO2Ynpo4AP9mvT5Lh3Pwp0bsHa6qHHZn4TSHRXR0VhD5lIQvw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB3960
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10186 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999
 phishscore=0 suspectscore=0 spamscore=0 adultscore=0 mlxscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112030096
X-Proofpoint-ORIG-GUID: 6IBHwKMACGV7JKZoXD1l8NMF8_kyp60p
X-Proofpoint-GUID: 6IBHwKMACGV7JKZoXD1l8NMF8_kyp60p
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Dec 3, 2021, at 6:25 AM, Dan Carpenter <dan.carpenter@oracle.com> wrot=
e:
>=20
> On Tue, Nov 30, 2021 at 08:19:47PM +0000, Chuck Lever III wrote:
>>>=20
>>> -DEFINE_SPINLOCK(nfsd_notifier_lock);
>>> +static DEFINE_SPINLOCK(nfsd_notifier_lock);
>>> static int nfsd_inetaddr_event(struct notifier_block *this, unsigned lo=
ng event,
>>> 	void *ptr)
>>> {
>>>=20
>>=20
>> Thanks! This was pushed to the tip of the for-next branch at
>>=20
>> https://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git
>>=20
>> I removed the Fixes: line because a backport is unnecessary, and
>> the commit ID is not yet permanent.
>=20
> Removing the tag, makes it more complicated for backporters.  Before
> they could tell automatically from the Fixes tag that backporting was
> not necessary.
>=20
> On the other hand, does this patch really need a Fixes tag since it's
> not a runtime bug?  Different maintainers take different sides in that
> argument.
>=20
> If the patch needed a fixes tag then a lot of maintainers have scripts
> to update the tag during a rebase.  There are also automated tool run on
> linux-next which emails a warning when the Fixes tags point to an
> invalid hash.

Hi Dan, the patch fixes a bug in my for-next branch, not in mainline.
There's really no need for a Fixes: tag.


--
Chuck Lever