Date:   Fri, 3 Dec 2021 10:19:56 -0500
From:   Bruce Fields <bfields@fieldses.org>
To:     Chuck Lever III <chuck.lever@oracle.com>
Cc:     Dan Carpenter <dan.carpenter@oracle.com>,
        Wei Yongjun <weiyongjun1@huawei.com>,
        Neil Brown <neilb@suse.de>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>,
        Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next] NFSD: make symbol 'nfsd_notifier_lock' static
Message-ID: <20211203151956.GA24150@fieldses.org>
References: <20211130113436.1770168-1-weiyongjun1@huawei.com>
 <888F3743-AB98-41A6-9651-EFDE5987AA01@oracle.com>
 <20211203112505.GI9522@kadam>
 <0428D783-49FE-451E-827B-6DB8F03347D1@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0428D783-49FE-451E-827B-6DB8F03347D1@oracle.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Precedence: bulk

On Fri, Dec 03, 2021 at 03:17:30PM +0000, Chuck Lever III wrote:
> 
> 
> > On Dec 3, 2021, at 6:25 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > 
> > On Tue, Nov 30, 2021 at 08:19:47PM +0000, Chuck Lever III wrote:
> >>> 
> >>> -DEFINE_SPINLOCK(nfsd_notifier_lock);
> >>> +static DEFINE_SPINLOCK(nfsd_notifier_lock);
> >>> static int nfsd_inetaddr_event(struct notifier_block *this, unsigned long event,
> >>> 	void *ptr)
> >>> {
> >>> 
> >> 
> >> Thanks! This was pushed to the tip of the for-next branch at
> >> 
> >> https://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git
> >> 
> >> I removed the Fixes: line because a backport is unnecessary, and
> >> the commit ID is not yet permanent.
> > 
> > Removing the tag, makes it more complicated for backporters.  Before
> > they could tell automatically from the Fixes tag that backporting was
> > not necessary.
> > 
> > On the other hand, does this patch really need a Fixes tag since it's
> > not a runtime bug?  Different maintainers take different sides in that
> > argument.
> > 
> > If the patch needed a fixes tag then a lot of maintainers have scripts
> > to update the tag during a rebase.  There are also automated tool run on
> > linux-next which emails a warning when the Fixes tags point to an
> > invalid hash.
> 
> Hi Dan, the patch fixes a bug in my for-next branch, not in mainline.
> There's really no need for a Fixes: tag.

Assuming it doesn't get folded into the fixed patch before going
upstream, it'd be useful information to have there.

--b.