From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Bruce Fields <bfields@fieldses.org>
CC:     Dan Carpenter <dan.carpenter@oracle.com>,
        Wei Yongjun <weiyongjun1@huawei.com>,
        Neil Brown <neilb@suse.de>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>,
        Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next] NFSD: make symbol 'nfsd_notifier_lock' static
Thread-Topic: [PATCH -next] NFSD: make symbol 'nfsd_notifier_lock' static
Thread-Index: AQHX5dx1rd4OTcROt0WbUE7C0kd8rqwcg4MAgAQhm4CAAEDugIAAAK8AgAACRAA=
Date:   Fri, 3 Dec 2021 15:28:03 +0000
Message-ID: <2DF935AD-CBD4-4C31-A08D-1C8127700C77@oracle.com>
References: <20211130113436.1770168-1-weiyongjun1@huawei.com>
 <888F3743-AB98-41A6-9651-EFDE5987AA01@oracle.com>
 <20211203112505.GI9522@kadam>
 <0428D783-49FE-451E-827B-6DB8F03347D1@oracle.com>
 <20211203151956.GA24150@fieldses.org>
In-Reply-To: <20211203151956.GA24150@fieldses.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kPPbNHGNjg68Q9jZ7n6q8y0jIRCXxrk75wpRm0L3jKn1Z7a0bpfrXjztYjb6?=
 =?us-ascii?Q?Kq6JiwHBjPwAyqIp/nd6HDs+6nE7CqEkSnoyTsp3Tzl98DwZVTWsjN9cMg0m?=
 =?us-ascii?Q?gO0Tt2TAfNr7+TujBP5xnANIosakqqXjYeHkA8N5EDY7EMPC49TbOSpJYECb?=
 =?us-ascii?Q?f2J3Q1lKBx+uxsKRNPfhOS2Yl9Mj48RPxdblaDhrTHsq4HGfApCNkkE5Sr4V?=
 =?us-ascii?Q?iCDwo+Gaei8+PQlILf0OzzwDjn9ly9EQvE1XlNMKKTnj19bk1cf3o75fmENv?=
 =?us-ascii?Q?DbshvLcDr5OImomb4Z/EmkAFgT8vOe5E3qKE1VaLDR+OSDOhAO0tXMuhj+TG?=
 =?us-ascii?Q?qVU8GL8RFIc3w5D+3gq4esN8xustPHZTYF1HN+JfCxMwMwQSUsPxkZqhr76G?=
 =?us-ascii?Q?ZVZiAgNj2P+wTrw/ZZLUgni8invrKRfrzfDh01cDf4kORkFtv4iypoPYMFKE?=
 =?us-ascii?Q?o4raLhmUYrLYlOy3feXDqq29622Yb0uBlk9dTqwEQfC6cYtSOM6PajNdbOCZ?=
 =?us-ascii?Q?jTeKFpdy5pS57HKhSG+Rxzvsoj6cFTyD/292T9GMIiw2XiYcLXOEluDQmRPv?=
 =?us-ascii?Q?Wy/XKnd9t9rnGZOr+OxAKO+bICXRr0FD1u87GRDF/otE57uAh/jzGwZrObw+?=
 =?us-ascii?Q?LLLnE5RdtVGCKiy+x4Pb+wHCP69ZZEoqVZzCNS4DqNonxYqQ+fxt9wF9EgW2?=
 =?us-ascii?Q?qI5J4vY5tSFky0O/ibHZYGbvlHVW+qr4bpV522L4er5QJooipu3SHCXe9Zl0?=
 =?us-ascii?Q?Bh2kxprKiUYqCXAFAxe+vKK3zmy1j8JRgrpgTouZT1NrwvIixhcDUvupOqbj?=
 =?us-ascii?Q?w0T9yWBR8SMn+zYwIs7VJBI1X5AgicCOGPowhMIsgODuPcpazemN8TimCWId?=
 =?us-ascii?Q?g4mYJ7hpxiGvT31Wr37ZtNyQCUQ/6R3rcfRkD8Iltv24LCW7H+VUpaBX9G0m?=
 =?us-ascii?Q?mQZVGzS3OjX6oFNbN4IlskQj4ZG5WXEGQU2RCeZorZTbXkXrAJtPFXI9EFze?=
 =?us-ascii?Q?Qc4rEyBXU0BDS4/V/MvZJ66AZOJriDxJZG69sFqSyfCce3rKBguCTWEguJxo?=
 =?us-ascii?Q?aAZo7qn9i0g2xREMCtPRo9ygNX+rbYPwlz7DTXx0xhD+Kr7AfMsf06MhrjjI?=
 =?us-ascii?Q?IdlPY630tEYjL6ovV+lv8Jsm000TPU5/Ivhl35agtkRQBNyDL/cb6myiuvBN?=
 =?us-ascii?Q?RngN9dCqk8EqAKEVS4WbY+NQv5wJybosoj88Fqqv7CDQaHDvSD1CxE6OJ0Xo?=
 =?us-ascii?Q?Q47SrUnlqYo1BW0m21VtOH6nb9ebRucF5eEBHT9FLctUB+dpMZh6c7gJCi/z?=
 =?us-ascii?Q?UOUoYGZn1o37ywARr2Omy0OtjMUg7GKrxQV4mS1thOgCkH0ch0b9aEsDX9qk?=
 =?us-ascii?Q?00k9MjfcGkHi1C16maOtmMOzmszCYfgA+PytTtx4YX8z/lg58Pxvx8J9u/0C?=
 =?us-ascii?Q?+2YU/MsYr4TX9tFh9zd3HPgdoR++AewwpCNSiPioeXMJqsDmdPoRyZv2Ib7G?=
 =?us-ascii?Q?KzOVSkVavek1PbiaOyggTduATVWqPTicYXIhBaPip96wxhTMMh6WO9tCB4ba?=
 =?us-ascii?Q?9I6eTf1HglDq1u23OOYAUj0BMRLOkAaOal9AfsKLSQ/Od8zGnib78l3WJBic?=
 =?us-ascii?Q?eSDQgz/MNNUh8vllOjuEZPM=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <85936C0AAB1CDB4AB0690168B492652C@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH0PR10MB4858.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4582d136-5f15-4f74-16b4-08d9b6717f51
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Dec 2021 15:28:03.1712
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: cPJxDQCNc2SM0SqM7uj2x1xISV0TfbcZ+TqSG3DtAujemODT0cCqaH7UEO3YxrkZ9d3tx9Pm1hKRJi6UuvyLMA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB4873
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10186 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 mlxscore=0
 suspectscore=0 mlxlogscore=999 spamscore=0 phishscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2112030097
X-Proofpoint-ORIG-GUID: PkzRArbUxVY6Oyr6RaAjDHzrgR5majEK
X-Proofpoint-GUID: PkzRArbUxVY6Oyr6RaAjDHzrgR5majEK
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Dec 3, 2021, at 10:19 AM, Bruce Fields <bfields@fieldses.org> wrote:
>=20
> On Fri, Dec 03, 2021 at 03:17:30PM +0000, Chuck Lever III wrote:
>>=20
>>=20
>>> On Dec 3, 2021, at 6:25 AM, Dan Carpenter <dan.carpenter@oracle.com> wr=
ote:
>>>=20
>>> On Tue, Nov 30, 2021 at 08:19:47PM +0000, Chuck Lever III wrote:
>>>>>=20
>>>>> -DEFINE_SPINLOCK(nfsd_notifier_lock);
>>>>> +static DEFINE_SPINLOCK(nfsd_notifier_lock);
>>>>> static int nfsd_inetaddr_event(struct notifier_block *this, unsigned =
long event,
>>>>> 	void *ptr)
>>>>> {
>>>>>=20
>>>>=20
>>>> Thanks! This was pushed to the tip of the for-next branch at
>>>>=20
>>>> https://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git
>>>>=20
>>>> I removed the Fixes: line because a backport is unnecessary, and
>>>> the commit ID is not yet permanent.
>>>=20
>>> Removing the tag, makes it more complicated for backporters.  Before
>>> they could tell automatically from the Fixes tag that backporting was
>>> not necessary.
>>>=20
>>> On the other hand, does this patch really need a Fixes tag since it's
>>> not a runtime bug?  Different maintainers take different sides in that
>>> argument.
>>>=20
>>> If the patch needed a fixes tag then a lot of maintainers have scripts
>>> to update the tag during a rebase.  There are also automated tool run o=
n
>>> linux-next which emails a warning when the Fixes tags point to an
>>> invalid hash.
>>=20
>> Hi Dan, the patch fixes a bug in my for-next branch, not in mainline.
>> There's really no need for a Fixes: tag.
>=20
> Assuming it doesn't get folded into the fixed patch before going
> upstream, it'd be useful information to have there.

I'm sorry, but I don't see how that information is useful for a
fixing a patch that is in the same merge set. I'll fold it in.


--
Chuck Lever